[ 
https://issues.apache.org/jira/browse/IMPALA-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779119#comment-16779119
 ] 

ASF subversion and git services commented on IMPALA-8223:
---------------------------------------------------------

Commit adced30896ade0f71e64cc2d5bad1cd9f43119b7 in impala's branch 
refs/heads/master from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=adced30 ]

IMPALA-8223: remove {mem-pool,hash-table}.total-bytes

These metrics have some issues (see the JIRA) and are not very relevant
in a world where most of the memory comes from the BufferPool

Change-Id: I61c8ca1ddf20676252eae958bc2d293e0ec67ecf
Reviewed-on: http://gerrit.cloudera.org:8080/12528
Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com>


> Remove mem-pool.total-bytes and hash-table.total-bytes metrics
> --------------------------------------------------------------
>
>                 Key: IMPALA-8223
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8223
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> I think we should remove these metrics - I'm not aware of a use case for them 
> and I haven't seen them be of use since I've been working on Impala's memory 
> management. Generally memory consumption is only interesting when broken down 
> by query.
> The hash-table metric is also wrong since it doesn't include the actual hash 
> table buckets. 
> The description of the mem-pool metric is totally wrong - "The current size 
> of the memory pool shared by all queries".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org

Reply via email to