Paul Rogers created IMPALA-8023:
-----------------------------------
Summary: Fix PlannerTest to handle error lines consistently
Key: IMPALA-8023
URL: https://issues.apache.org/jira/browse/IMPALA-8023
Project: IMPALA
Issue Type: Improvement
Components: Frontend
Affects Versions: Impala 3.1.0
Reporter: Paul Rogers
{{PlannerTest}} works by running a query from a .test file, generating a plan,
and comparing that plan to a "golden" expected result. It work well for most
cases. We can use Eclipse's diff tools to compare the actual with expected
files, and to copy across any expected changes that result from changes to the
planner code.
Once case that does *not* work are exceptions. When PlannerTest indicates
encounters failure, it emits a line such as the following to the actual results
file:
{noformat}
org.apache.impala.common.NotImplementedException: Scan of table 't' in format
'RC_FILE' is not supported because the table has a column 's' with a complex
type 'STRUCT<f1:STRING,f2:INT>'.
{noformat}
Yet, in order for the comparison to pass, the golden file must contain the
error in the following form:
{noformat}
NotImplementedException: Scan of table 'functional.complextypes_fileformat' in
format 'TEXT' is not supported because the table has a column 's' with a
complex type 'STRUCT<f1:STRING,f2:INT>'.
{noformat}
Note that the actual output includes the package prefix, the expected error
must *not* include that prefix.
The result is that:
* When comparing files, one must learn to ignore the differences between these
lines: the differences are *not* the reason why a test might fail, and
* When "rebasing" a file, one must copy all expected changes *except* the error
lines.
In short, this is a real nuisance. Use a filter mechanism to fix this once and
for all.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
