[jira] [Commented] (IMPALA-13560) test_admission_controller_with_quota_configs fails with assertion error
[
https://issues.apache.org/jira/browse/IMPALA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901324#comment-17901324
]
ASF subversion and git services commented on IMPALA-13560:
--
Commit 8416432cc3e656b6c5fa230d4075ba64e0f3d091 in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=8416432cc ]
IMPALA-13560: Second attempt at fixing
test_admission_controller_with_quota_configs test.
The test test_admission_controller_with_quota_configs() is designed to
be a similar test to test_admission_controller_with_configs() which
uses the 'queueB' queue. The newer test uses a newly added
queue 'queueF'. Because Admission Control configuration is split across
two files, and because of user stupidity, the queue timeout
configuration for 'queueB' was not copied when the new test was
created. This causes queued queries to be timed out while waiting for
admission, which confuses the test.
Set pool-queue-timeout-ms.root to 60 for queueF in
llama-site-test2.xml.
Change-Id: I1378cd4e42ed5629b92b1c16dd17d4d16ec4a19d
Reviewed-on: http://gerrit.cloudera.org:8080/22126
Reviewed-by: Impala Public Jenkins
Tested-by: Impala Public Jenkins
> test_admission_controller_with_quota_configs fails with assertion error
> ---
>
> Key: IMPALA-13560
> URL: https://issues.apache.org/jira/browse/IMPALA-13560
> Project: IMPALA
> Issue Type: Bug
>Reporter: Zoltán Borók-Nagy
>Assignee: Andrew Sherman
>Priority: Major
> Labels: broken-build
>
> *I saw the following in an ASAN build:*
> h2. Error Message
> {noformat}
> assert 0 >= 5
> {noformat}
> h2. Stacktrace
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2453: in run_admission_test
> assert metric_deltas['admitted'] >= expected_admitted
> E assert 0 >= 5
> {noformat}
> Also saw the following error in an other build:
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2463: in run_admission_test
> assert metric_deltas['timed-out'] == 0
> E assert 1 == 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-13560) test_admission_controller_with_quota_configs fails with assertion error
[
https://issues.apache.org/jira/browse/IMPALA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901007#comment-17901007
]
Andrew Sherman commented on IMPALA-13560:
-
I observe that my change has not fixed the problem. I will look some more
> test_admission_controller_with_quota_configs fails with assertion error
> ---
>
> Key: IMPALA-13560
> URL: https://issues.apache.org/jira/browse/IMPALA-13560
> Project: IMPALA
> Issue Type: Bug
>Reporter: Zoltán Borók-Nagy
>Assignee: Andrew Sherman
>Priority: Major
> Labels: broken-build
>
> *I saw the following in an ASAN build:*
> h2. Error Message
> {noformat}
> assert 0 >= 5
> {noformat}
> h2. Stacktrace
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2453: in run_admission_test
> assert metric_deltas['admitted'] >= expected_admitted
> E assert 0 >= 5
> {noformat}
> Also saw the following error in an other build:
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2463: in run_admission_test
> assert metric_deltas['timed-out'] == 0
> E assert 1 == 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-13560) test_admission_controller_with_quota_configs fails with assertion error
[
https://issues.apache.org/jira/browse/IMPALA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900403#comment-17900403
]
ASF subversion and git services commented on IMPALA-13560:
--
Commit 201e7becadf960caa76f1acd901dafc0989d27b7 in impala's branch
refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=201e7beca ]
IMPALA-13560: Fix test_admission_controller_with_quota_configs test.
The intention of test_admission_controller_with_quota_configs() is to
run a workload with a variety of outcomes in a pool that has Admission
Control User Quotas Configured. The idea was that the User Quotas
configuration would not affect the workload that is run by
run_admission_test(). The configuration for 'queueF' limits the number
of concurrent queries that can be run by any user to 30. In the test
there is only one user, and the number of queries that are run is 50,
so there is potential for the User Quotas configuration to affect the
operation of the test. Fix this by bumping the Quota limit to 50.
TESTING
I ran tests in a similar environment to that where failures were
observed. Without the fix I saw a failure, and with the fix there were
no failures. This isn't sufficient to prove this fix is all that is
needed, but the change is safe and isolated.
Change-Id: Ie2cc81a5b95d07154b73d32daf67617c79283ac8
Reviewed-on: http://gerrit.cloudera.org:8080/22096
Reviewed-by: Impala Public Jenkins
Tested-by: Impala Public Jenkins
> test_admission_controller_with_quota_configs fails with assertion error
> ---
>
> Key: IMPALA-13560
> URL: https://issues.apache.org/jira/browse/IMPALA-13560
> Project: IMPALA
> Issue Type: Bug
>Reporter: Zoltán Borók-Nagy
>Assignee: Andrew Sherman
>Priority: Major
> Labels: broken-build
>
> *I saw the following in an ASAN build:*
> h2. Error Message
> {noformat}
> assert 0 >= 5
> {noformat}
> h2. Stacktrace
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2453: in run_admission_test
> assert metric_deltas['admitted'] >= expected_admitted
> E assert 0 >= 5
> {noformat}
> Also saw the following error in an other build:
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2463: in run_admission_test
> assert metric_deltas['timed-out'] == 0
> E assert 1 == 0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-13560) test_admission_controller_with_quota_configs fails with assertion error
[
https://issues.apache.org/jira/browse/IMPALA-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17900054#comment-17900054
]
Zoltán Borók-Nagy commented on IMPALA-13560:
[~asherman] could you please take a look? Please feel free to reassign.
> test_admission_controller_with_quota_configs fails with assertion error
> ---
>
> Key: IMPALA-13560
> URL: https://issues.apache.org/jira/browse/IMPALA-13560
> Project: IMPALA
> Issue Type: Bug
>Reporter: Zoltán Borók-Nagy
>Assignee: Andrew Sherman
>Priority: Major
> Labels: broken-build
>
> *I saw the following in an ASAN build:*
> h2. Error Message
> {noformat}
> assert 0 >= 5
> {noformat}
> h2. Stacktrace
> {noformat}
> custom_cluster/test_admission_controller.py:2542: in
> test_admission_controller_with_quota_configs
> check_user_aggregates=True)
> custom_cluster/test_admission_controller.py:2453: in run_admission_test
> assert metric_deltas['admitted'] >= expected_admitted
> E assert 0 >= 5
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
