[jira] [Commented] (IMPALA-6995) False-positive DCHECK when converting whitespace-only strings to timestamp
[
https://issues.apache.org/jira/browse/IMPALA-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480155#comment-16480155
]
ASF subversion and git services commented on IMPALA-6995:
-
Commit 88facf3fbc56a62a383a4be6cd7a5ff77c0c9589 in impala's branch
refs/heads/2.x from [~tarmstr...@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=88facf3 ]
IMPALA-6995: avoid DCHECK in TimestampParse::Parse()
The bug was that the string's length is checked before trimming leading
and trailing spaces instead of afterwards. The bug has been present for
a long time but couldn't hit a DCHECK until recently.
Testing:
Added some backend tests that reproduce the crash.
Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1
Reviewed-on: http://gerrit.cloudera.org:8080/10349
Reviewed-by: Tim Armstrong
Tested-by: Impala Public Jenkins
> False-positive DCHECK when converting whitespace-only strings to timestamp
> --
>
> Key: IMPALA-6995
> URL: https://issues.apache.org/jira/browse/IMPALA-6995
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
>Affects Versions: Impala 3.0, Impala 2.12.0
>Reporter: Tim Armstrong
>Assignee: Tim Armstrong
>Priority: Critical
> Labels: crash
> Fix For: Impala 2.13.0, Impala 3.1.0
>
>
> {noformat}
> select cast(' ' as timestamp);
> {noformat}
> {noformat}
> F0508 14:32:07.245255 11824 timestamp-parse-util.cc:241] Check failed:
> dt_ctx->fmt_len > 0 (0 vs. 0)
> *** Check failure stack trace: ***
> @ 0x428956d google::LogMessage::Fail()
> @ 0x428ae12 google::LogMessage::SendToLog()
> @ 0x4288f47 google::LogMessage::Flush()
> @ 0x428c50e google::LogMessageFatal::~LogMessageFatal()
> @ 0x1c3f485 impala::TimestampParser::ParseFormatTokensByStr()
> @ 0x1c40553 impala::TimestampParser::Parse()
> @ 0x1c4712a impala::TimestampValue::Parse()
> @ 0x2e5d8fa impala::CastFunctions::CastToTimestampVal()
> @ 0x2e45322 impala::ScalarFnCall::InterpretEval<>()
> @ 0x2e27de5 impala::ScalarFnCall::GetTimestampVal()
> @ 0x2de72de impala::ScalarExprEvaluator::GetValue()
> @ 0x2de6e69 impala::ScalarExprEvaluator::GetValue()
> @ 0x1d1dbbf
> Java_org_apache_impala_service_FeSupport_NativeEvalExprsWithoutRow
> @ 0x7fb7cc1d07e8 (unknown)
> Picked up JAVA_TOOL_OPTIONS:
> -agentlib:jdwp=transport=dt_socket,address=3,server=y,suspend=n
> Wrote minidump to
> /home/tarmstrong/Impala/incubator-impala/logs/cluster/minidumps/impalad/42afc7f9-5b4a-4ed7-b34ad782-d7904747.dmp
> {noformat}
> It seems to work fine on a release build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-6995) False-positive DCHECK when converting whitespace-only strings to timestamp
[
https://issues.apache.org/jira/browse/IMPALA-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478064#comment-16478064
]
ASF subversion and git services commented on IMPALA-6995:
-
Commit 02ee2d1c509bffc71817fdc4bd25b9589e7085e5 in impala's branch
refs/heads/master from [~tarmstr...@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=02ee2d1 ]
IMPALA-6995: avoid DCHECK in TimestampParse::Parse()
The bug was that the string's length is checked before trimming leading
and trailing spaces instead of afterwards. The bug has been present for
a long time but couldn't hit a DCHECK until recently.
Testing:
Added some backend tests that reproduce the crash.
Change-Id: I02a18ffd8893fe74f5830144300f745ce31477b1
Reviewed-on: http://gerrit.cloudera.org:8080/10349
Reviewed-by: Tim Armstrong
Tested-by: Impala Public Jenkins
> False-positive DCHECK when converting whitespace-only strings to timestamp
> --
>
> Key: IMPALA-6995
> URL: https://issues.apache.org/jira/browse/IMPALA-6995
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
>Affects Versions: Impala 3.0, Impala 2.12.0
>Reporter: Tim Armstrong
>Assignee: Tim Armstrong
>Priority: Critical
> Labels: crash
>
> {noformat}
> select cast(' ' as timestamp);
> {noformat}
> {noformat}
> F0508 14:32:07.245255 11824 timestamp-parse-util.cc:241] Check failed:
> dt_ctx->fmt_len > 0 (0 vs. 0)
> *** Check failure stack trace: ***
> @ 0x428956d google::LogMessage::Fail()
> @ 0x428ae12 google::LogMessage::SendToLog()
> @ 0x4288f47 google::LogMessage::Flush()
> @ 0x428c50e google::LogMessageFatal::~LogMessageFatal()
> @ 0x1c3f485 impala::TimestampParser::ParseFormatTokensByStr()
> @ 0x1c40553 impala::TimestampParser::Parse()
> @ 0x1c4712a impala::TimestampValue::Parse()
> @ 0x2e5d8fa impala::CastFunctions::CastToTimestampVal()
> @ 0x2e45322 impala::ScalarFnCall::InterpretEval<>()
> @ 0x2e27de5 impala::ScalarFnCall::GetTimestampVal()
> @ 0x2de72de impala::ScalarExprEvaluator::GetValue()
> @ 0x2de6e69 impala::ScalarExprEvaluator::GetValue()
> @ 0x1d1dbbf
> Java_org_apache_impala_service_FeSupport_NativeEvalExprsWithoutRow
> @ 0x7fb7cc1d07e8 (unknown)
> Picked up JAVA_TOOL_OPTIONS:
> -agentlib:jdwp=transport=dt_socket,address=3,server=y,suspend=n
> Wrote minidump to
> /home/tarmstrong/Impala/incubator-impala/logs/cluster/minidumps/impalad/42afc7f9-5b4a-4ed7-b34ad782-d7904747.dmp
> {noformat}
> It seems to work fine on a release build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org
For additional commands, e-mail: issues-all-h...@impala.apache.org
