[jira] [Commented] (ARTEMIS-1345) Concurrent Modification Exceptions after Message.copy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390453#comment-16390453
 ] 

ASF GitHub Bot commented on ARTEMIS-1345:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1937


> Concurrent Modification Exceptions after Message.copy
> -
>
> Key: ARTEMIS-1345
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1345
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.3.0
>Reporter: Jiri Daněk
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>
> Consider tests
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.AutoCreateQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TemporaryQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TopicClusterTest}}
> When they are adapted to run through multiple JMS ConnectionFactories in 
> turn, these test are always passing with Core, one test method fails with 
> OpenWire (reported as ARTEMIS-1344), but all fail with AMQP.
> The broker prints the following error (every time)
> {noformat}
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,380 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: 
> removing consumer which did not handle a message, 
> consumer=org.apache.activemq.artemis.core.server.cluster.impl.Redistributor@6c72718c,
>  
> message=Reference[28]:RELIABLE:org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage@799ad5a1:
>  java.lang.UnsupportedOperationException
>   at java.util.AbstractMap.put(AbstractMap.java:209) [rt.jar:1.8.0_131]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:690)
>  [:]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:743)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.addRouteContextToMessage(RemoteQueueBindingImpl.java:334)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.route(RemoteQueueBindingImpl.java:175)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl.redistribute(BindingsImpl.java:222)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.redistribute(PostOfficeImpl.java:868)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.Redistributor.handle(Redistributor.java:150)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.handle(QueueImpl.java:2802)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2187)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
>  [:]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_131]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [rt.jar:1.8.0_131]
>   at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_131]
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,381 ERROR [org.apache.activemq.artemis.core.server] AMQ224041: 
> Failed to deliver: java.util.NoSuchElementException
>   at 
> org.apache.activemq.artemis.utils.collections.PriorityLinkedListImpl$PriorityLinkedListIterator.repeat(PriorityLinkedListImpl.java:161)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2205)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
>  [:]
>   at 
> 

[jira] [Commented] (ARTEMIS-1345) Concurrent Modification Exceptions after Message.copy

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390451#comment-16390451
 ] 

ASF subversion and git services commented on ARTEMIS-1345:
--

Commit 8831a570de575f19cbb238e8e1956119061057f2 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8831a57 ]

ARTEMIS-1345 ConcurrentModificationException after copy


> Concurrent Modification Exceptions after Message.copy
> -
>
> Key: ARTEMIS-1345
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1345
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.3.0
>Reporter: Jiri Daněk
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>
> Consider tests
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.AutoCreateQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TemporaryQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TopicClusterTest}}
> When they are adapted to run through multiple JMS ConnectionFactories in 
> turn, these test are always passing with Core, one test method fails with 
> OpenWire (reported as ARTEMIS-1344), but all fail with AMQP.
> The broker prints the following error (every time)
> {noformat}
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,380 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: 
> removing consumer which did not handle a message, 
> consumer=org.apache.activemq.artemis.core.server.cluster.impl.Redistributor@6c72718c,
>  
> message=Reference[28]:RELIABLE:org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage@799ad5a1:
>  java.lang.UnsupportedOperationException
>   at java.util.AbstractMap.put(AbstractMap.java:209) [rt.jar:1.8.0_131]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:690)
>  [:]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:743)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.addRouteContextToMessage(RemoteQueueBindingImpl.java:334)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.route(RemoteQueueBindingImpl.java:175)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl.redistribute(BindingsImpl.java:222)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.redistribute(PostOfficeImpl.java:868)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.Redistributor.handle(Redistributor.java:150)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.handle(QueueImpl.java:2802)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2187)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
>  [:]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_131]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [rt.jar:1.8.0_131]
>   at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_131]
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,381 ERROR [org.apache.activemq.artemis.core.server] AMQ224041: 
> Failed to deliver: java.util.NoSuchElementException
>   at 
> org.apache.activemq.artemis.utils.collections.PriorityLinkedListImpl$PriorityLinkedListIterator.repeat(PriorityLinkedListImpl.java:161)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2205)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> 

[jira] [Commented] (ARTEMIS-1345) Concurrent Modification Exceptions after Message.copy

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390295#comment-16390295
 ] 

ASF GitHub Bot commented on ARTEMIS-1345:
-

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1937

ARTEMIS-1345 ConcurrentModificationException after copy



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1345

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1937


commit 75501031b2076d00df3b7ec32cffa8e407a7e1f9
Author: Clebert Suconic 
Date:   2018-03-07T20:04:39Z

ARTEMIS-1345 ConcurrentModificationException after copy




> Concurrent Modification Exceptions after Message.copy
> -
>
> Key: ARTEMIS-1345
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1345
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.3.0
>Reporter: Jiri Daněk
>Assignee: clebert suconic
>Priority: Major
> Fix For: 2.5.0
>
>
> Consider tests
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.AutoCreateQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TemporaryQueueClusterTest}}
> {{org.apache.activemq.artemis.tests.integration.jms.cluster.TopicClusterTest}}
> When they are adapted to run through multiple JMS ConnectionFactories in 
> turn, these test are always passing with Core, one test method fails with 
> OpenWire (reported as ARTEMIS-1344), but all fail with AMQP.
> The broker prints the following error (every time)
> {noformat}
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,380 WARN  [org.apache.activemq.artemis.core.server] AMQ222151: 
> removing consumer which did not handle a message, 
> consumer=org.apache.activemq.artemis.core.server.cluster.impl.Redistributor@6c72718c,
>  
> message=Reference[28]:RELIABLE:org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage@799ad5a1:
>  java.lang.UnsupportedOperationException
>   at java.util.AbstractMap.put(AbstractMap.java:209) [rt.jar:1.8.0_131]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:690)
>  [:]
>   at 
> org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.putBytesProperty(AMQPMessage.java:743)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.addRouteContextToMessage(RemoteQueueBindingImpl.java:334)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.RemoteQueueBindingImpl.route(RemoteQueueBindingImpl.java:175)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl.redistribute(BindingsImpl.java:222)
>  [:]
>   at 
> org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.redistribute(PostOfficeImpl.java:868)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.cluster.impl.Redistributor.handle(Redistributor.java:150)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.handle(QueueImpl.java:2802)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2187)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$1900(QueueImpl.java:105)
>  [:]
>   at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:2994)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [:]
>   at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase$ExecutorTask.run(ProcessorBase.java:53)
>  [:]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [rt.jar:1.8.0_131]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [rt.jar:1.8.0_131]
>   at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_131]
> [Thread-3 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$5@18e36d14)]
>  10:30:51,381 ERROR [org.apache.activemq.artemis.core.server] AMQ224041: 
> Failed to deliver: java.util.NoSuchElementException
>   at 
>