[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356860#comment-16356860 ] Christopher L. Shannon commented on ARTEMIS-1633: - I pushed a small commit to fix a bug with this, I didn't do a PR because it a super small change. > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356859#comment-16356859 ] ASF subversion and git services commented on ARTEMIS-1633: -- Commit 33b265ca6bf5b84553500dddcf096b13683bb8c8 in activemq-artemis's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=33b265c ] ARTEMIS-1633 - Include populated RoutingContext in beforeMessageRoute call There was a small bug in the previous commit, the beforeMessageRoute callback was being executed too early so the RoutingCountext wasn't being filled in > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339607#comment-16339607 ] ASF GitHub Bot commented on ARTEMIS-1633: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1816 > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339605#comment-16339605 ] ASF subversion and git services commented on ARTEMIS-1633: -- Commit 37cc1e3e7a6defb55193440a533c1c71ad1e163d in activemq-artemis's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=37cc1e3 ] ARTEMIS-1633 - fire message routing callbacks for all results Make sure ActiveMQServer plugin implementations are always notified of message route events > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339606#comment-16339606 ] ASF subversion and git services commented on ARTEMIS-1633: -- Commit 24b1f2efbcd60e985d652e7ae970cecb1378a8d0 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=24b1f2e ] ARTEMIS-1633 proper initialize route result > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339585#comment-16339585 ] ASF GitHub Bot commented on ARTEMIS-1633: - Github user cshannon commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1816#discussion_r163924828 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -772,6 +772,8 @@ public RoutingStatus route(final Message message, message.cleanupInternalProperties(); + server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null); --- End diff -- If there were messages sent to an address with no bindings the message would get dropped because of lack of bindings. But with the old way the message route methods were only triggered if the routing status was OK. With the change the methods are called even if there are no bindings but the status will say NO_BINDINGS, etc. > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339508#comment-16339508 ] ASF GitHub Bot commented on ARTEMIS-1633: - Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1816#discussion_r163905434 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java --- @@ -772,6 +772,8 @@ public RoutingStatus route(final Message message, message.cleanupInternalProperties(); + server.callBrokerPlugins(server.hasBrokerPlugins() ? plugin -> plugin.beforeMessageRoute(message, context, direct, rejectDuplicates) : null); --- End diff -- in what situation this was not happening? paging? > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337813#comment-16337813 ] ASF GitHub Bot commented on ARTEMIS-1633: - GitHub user cshannon opened a pull request: https://github.com/apache/activemq-artemis/pull/1816 ARTEMIS-1633 - fire message routing callbacks for all results Make sure ActiveMQServer plugin implementations are always notified of message route events You can merge this pull request into a Git repository by running: $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1816.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1816 commit 713c48fd26ce6577b870845ea883b2d90e5915b5 Author: Christopher L. Shannon (cshannon) Date: 2018-01-24T16:03:12Z ARTEMIS-1633 - fire message routing callbacks for all results Make sure ActiveMQServer plugin implementations are always notified of message route events > ActiveMQServerPlugin message routing callbacks should fire for all results > -- > > Key: ARTEMIS-1633 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1633 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.4.0 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 2.5.0 > > > When I added the callbacks for beforeMessageRoute and afterMessageRoute I > accidentally inserted them so that they will only be called when the > RoutingStatus result is OK. They should always be called even if the status > is no bindings, or no bindings DLA, etc to allow the plugin writer to handle > events depending on the routing status. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
