[jira] [Commented] (ARTEMIS-1679) Stopping consumer no need to wait until all queued tasks done
[ https://issues.apache.org/jira/browse/ARTEMIS-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372025#comment-16372025 ] ASF GitHub Bot commented on ARTEMIS-1679: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1867 > Stopping consumer no need to wait until all queued tasks done > - > > Key: ARTEMIS-1679 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1679 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > > Sping's SimpleMessageListenerContainer shutdown will stop consumers and then > close them. It will take lots of time(each consumer costs 10s at most) if > there are lots of consumers bcs stop process will wait until all queued tasks > done. We assume that waiting for the current task is enough and this will > accelerate spring shutting down process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1679) Stopping consumer no need to wait until all queued tasks done
[ https://issues.apache.org/jira/browse/ARTEMIS-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372024#comment-16372024 ] ASF GitHub Bot commented on ARTEMIS-1679: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1867 I will merge this.. but if there's any failures from the full testsuite.. I may have to revert this. > Stopping consumer no need to wait until all queued tasks done > - > > Key: ARTEMIS-1679 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1679 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > Fix For: 2.5.0 > > > Sping's SimpleMessageListenerContainer shutdown will stop consumers and then > close them. It will take lots of time(each consumer costs 10s at most) if > there are lots of consumers bcs stop process will wait until all queued tasks > done. We assume that waiting for the current task is enough and this will > accelerate spring shutting down process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1679) Stopping consumer no need to wait until all queued tasks done
[ https://issues.apache.org/jira/browse/ARTEMIS-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361815#comment-16361815 ] ASF GitHub Bot commented on ARTEMIS-1679: - GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/1867 ARTEMIS-1679 Stopping consumer no need to wait until all queued tasks… Sping's SimpleMessageListenerContainer shutdown will stop consumers and then close them. It will take lots of time(each consumer costs 10s at most) if there are lots of consumers bcs stop process will wait until all queued tasks done. We assume that waiting for the current task is enough and this will accelerate spring shutting down process. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wy96f/activemq-artemis consumer-stop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1867 commit 3b882d05c31ec8401cfcaa61ec4ad69f04c9f562 Author: yang wei Date: 2018-02-13T04:44:10Z ARTEMIS-1679 Stopping consumer no need to wait until all queued tasks done > Stopping consumer no need to wait until all queued tasks done > - > > Key: ARTEMIS-1679 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1679 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.4.0 >Reporter: yangwei >Priority: Major > > Sping's SimpleMessageListenerContainer shutdown will stop consumers and then > close them. It will take lots of time(each consumer costs 10s at most) if > there are lots of consumers bcs stop process will wait until all queued tasks > done. We assume that waiting for the current task is enough and this will > accelerate spring shutting down process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)