[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-04-17 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440972#comment-16440972
 ] 

ASF subversion and git services commented on ARTEMIS-1763:
--

Commit f2916754a1e89f5fbc371b040a90550cb677 in activemq-artemis's branch 
refs/heads/master from [~gaohoward]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f29 ]

NO-JIRA: Fix test regression

QuorumFailOverTest.testQuorumVotingLiveNotDead fails
because the quorum vote takes longer time to finish than
the test expects to.
(The test used to pass until commit ARTEMIS-1763)


> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: 2.5.1
>
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-04-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440973#comment-16440973
 ] 

ASF GitHub Bot commented on ARTEMIS-1763:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2021


> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: 2.5.1
>
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-04-16 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439550#comment-16439550
 ] 

ASF GitHub Bot commented on ARTEMIS-1763:
-

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2021

NO-JIRA: Fix test regression

QuorumFailOverTest.testQuorumVotingLiveNotDead fails
because the quorum vote takes longer time to finish than
the test expects to.
(The test used to pass until commit ARTEMIS-1763)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis h_fix_regress

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2021


commit 64f974ff52470553de8520ec7b374a78494d861e
Author: Howard Gao 
Date:   2018-04-16T14:02:32Z

NO-JIRA: Fix test regression

QuorumFailOverTest.testQuorumVotingLiveNotDead fails
because the quorum vote takes longer time to finish than
the test expects to.
(The test used to pass until commit ARTEMIS-1763)




> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: 2.5.1
>
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-03-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410240#comment-16410240
 ] 

ASF GitHub Bot commented on ARTEMIS-1763:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1967


> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-03-22 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410239#comment-16410239
 ] 

ASF subversion and git services commented on ARTEMIS-1763:
--

Commit 3a548a9df5a284d4b391fb0055a46507e6f63a87 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3a548a9 ]

ARTEMIS-1763 - Remove 'quick check' before quorum

https://issues.apache.org/jira/browse/ARTEMIS-1763


> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-03-22 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410238#comment-16410238
 ] 

ASF subversion and git services commented on ARTEMIS-1763:
--

Commit 3a548a9df5a284d4b391fb0055a46507e6f63a87 in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=3a548a9 ]

ARTEMIS-1763 - Remove 'quick check' before quorum

https://issues.apache.org/jira/browse/ARTEMIS-1763


> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1763) Remove 'quick check' before quorum

2018-03-22 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409376#comment-16409376
 ] 

ASF GitHub Bot commented on ARTEMIS-1763:
-

GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/1967

ARTEMIS-1763 - Remove 'quick check' before quorum

https://issues.apache.org/jira/browse/ARTEMIS-1763

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1967


commit 2abab1a43cad5f9ba94d4bf97ed21e2af60c3793
Author: andytaylor 
Date:   2018-03-22T10:58:11Z

ARTEMIS-1763 - Remove 'quick check' before quorum

https://issues.apache.org/jira/browse/ARTEMIS-1763




> Remove 'quick check' before quorum
> --
>
> Key: ARTEMIS-1763
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1763
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
>
> A check was added to SharedNothingBackupQuorum in isLiveDown method to 
> quickly check if the backup could still connect to the live. This should be 
> removed as it is unreliable and by passes the actual quorum vote.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)