[jira] [Commented] (ARTEMIS-1787) Openwire message should not contain internal property

2018-05-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468504#comment-16468504
 ] 

ASF GitHub Bot commented on ARTEMIS-1787:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
So issue i see here, is on the noLocal the internal property will still be 
present on noLocal, so if the argument is that including it breaks spec, then 
surely it still breaks spec even for noLocal as it would be included there 
still. 


> Openwire message should not contain internal property
> -
>
> Key: ARTEMIS-1787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> Openwire message contains __AMQ_CID property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1787) Openwire message should not contain internal property

2018-04-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430162#comment-16430162
 ] 

ASF GitHub Bot commented on ARTEMIS-1787:
-

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
This PR is partly reverting 
https://github.com/apache/activemq-artemis/pull/1734

AFAIK including some internal properties break JMS API specification.



> Openwire message should not contain internal property
> -
>
> Key: ARTEMIS-1787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> Openwire message contains __AMQ_CID property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1787) Openwire message should not contain internal property

2018-04-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428694#comment-16428694
 ] 

ASF GitHub Bot commented on ARTEMIS-1787:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
same thing I asked on the JIRA. Why it shouldn't? why only on noLocal?

trying to get some context on the why it should not be included...


it would be nice to include such thing on the commit description please.


> Openwire message should not contain internal property
> -
>
> Key: ARTEMIS-1787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> Openwire message contains __AMQ_CID property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1787) Openwire message should not contain internal property

2018-04-06 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428691#comment-16428691
 ] 

clebert suconic commented on ARTEMIS-1787:
--

Why? :) Why it should not include the connectionID?

> Openwire message should not contain internal property
> -
>
> Key: ARTEMIS-1787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> Openwire message contains __AMQ_CID property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1787) Openwire message should not contain internal property

2018-04-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427160#comment-16427160
 ] 

ASF GitHub Bot commented on ARTEMIS-1787:
-

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1994

ARTEMIS-1787 Openwire message should not contain internal property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1787

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1994


commit 0210fee3bc3731e3173f012987bfd9d9f2965958
Author: Stanislav Knot 
Date:   2018-04-05T16:01:41Z

ARTEMIS-1787 Openwire message should not contain internal property




> Openwire message should not contain internal property
> -
>
> Key: ARTEMIS-1787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1787
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Major
>
> Openwire message contains __AMQ_CID property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)