[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546573#comment-16546573 ] ASF subversion and git services commented on ARTEMIS-1966: -- Commit e4ccbb929b722a31af2d14f17e4c96d6bbe2b10e in activemq-artemis's branch refs/heads/2.6.x from yang wei [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e4ccbb9 ] ARTEMIS-1966 Replication channel closed but not connection if flow controlled during replication (cherry picked from commit 9f8288c0156072b3ae02efd04e1adbcd0abca2c2) > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > Fix For: 2.7.0, 2.6.3 > > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542086#comment-16542086 ] ASF subversion and git services commented on ARTEMIS-1966: -- Commit 8647ef65c1ff88c8f50366b12798bb573ce1f331 in activemq-artemis's branch refs/heads/2.6.x from yang wei [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8647ef6 ] ARTEMIS-1966 Replication channel closed but not connection if flow controlled during replication (cherry picked from commit 9f8288c0156072b3ae02efd04e1adbcd0abca2c2) > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > Fix For: 2.7.0, 2.6.3 > > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542087#comment-16542087 ] ASF subversion and git services commented on ARTEMIS-1966: -- Commit 16f8674ae758af49e091f2526deacae68ff2399c in activemq-artemis's branch refs/heads/2.6.x from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=16f8674 ] ARTEMIS-1966 Improving SharedNothingReplicationFlowControlTest Tests should always extend ActiveMQTestBase whenever is possible. This is because there are a few rules to avoid thread leakages. The test was also leaking an executor and I believe it was not always stopping the servers, which I fixed here. (cherry picked from commit 2a30b291be94b0283172b15fa573b86769a32070) > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > Fix For: 2.7.0, 2.6.3 > > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542019#comment-16542019 ] ASF GitHub Bot commented on ARTEMIS-1966: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2171 > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542018#comment-16542018 ] ASF subversion and git services commented on ARTEMIS-1966: -- Commit 2a30b291be94b0283172b15fa573b86769a32070 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2a30b29 ] ARTEMIS-1966 Improving SharedNothingReplicationFlowControlTest Tests should always extend ActiveMQTestBase whenever is possible. This is because there are a few rules to avoid thread leakages. The test was also leaking an executor and I believe it was not always stopping the servers, which I fixed here. > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542017#comment-16542017 ] ASF subversion and git services commented on ARTEMIS-1966: -- Commit 9f8288c0156072b3ae02efd04e1adbcd0abca2c2 in activemq-artemis's branch refs/heads/master from yang wei [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9f8288c ] ARTEMIS-1966 Replication channel closed but not connection if flow controlled during replication > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542005#comment-16542005 ] ASF GitHub Bot commented on ARTEMIS-1966: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/2171 Thanks... I'm also adding a commit to improve the test you added. Take a look please for future references. (I decided to just change it instead of asking the change here). thanks a lot. > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1966) Replication channel closed but not connection if flow controlled during replication
[ https://issues.apache.org/jira/browse/ARTEMIS-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533456#comment-16533456 ] ASF GitHub Bot commented on ARTEMIS-1966: - GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2171 ARTEMIS-1966 Replication channel closed but not connection if flow co… We use SharedNothing Activation. If flow control occurs during replication, replication channel would be closed and enabled flag is set to false. After it, the message would not be sent to backup node. If live server crashes at this time, the backup node will fail over, resulting in data loss. So we close connection if flow controlled, then backup node would be signaled failure replicating and restart server. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wy96f/activemq-artemis stop_connection_if_flowcontrolled Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2171 commit 0781b1d8407105aeeeb1ae1437cb8ee490e1cc9f Author: yang wei Date: 2018-07-05T09:48:11Z ARTEMIS-1966 Replication channel closed but not connection if flow controlled during replication > Replication channel closed but not connection if flow controlled during > replication > --- > > Key: ARTEMIS-1966 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1966 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: yangwei >Priority: Major > > We use SharedNothing Activation. If flow control occurs during replication, > replication channel would be closed and enabled flag is set to false. After > it, the message would not be sent to backup node. If live server crashes at > this time, the backup node will fail over, resulting in data loss. > So we close connection if flow controlled, then backup node would be signaled > failure replicating and restart server. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
