[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-19 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587863#comment-15587863
 ] 

ASF GitHub Bot commented on ARTEMIS-808:


Github user jmesnil commented on the issue:

https://github.com/apache/activemq-artemis/pull/847
  
@jbertram thanks, I checked that with that changes our tests with security 
manager pass again.


> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Assignee: Justin Bertram
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586758#comment-15586758
 ] 

ASF GitHub Bot commented on ARTEMIS-808:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/847


> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Assignee: Justin Bertram
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-18 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586756#comment-15586756
 ] 

ASF subversion and git services commented on ARTEMIS-808:
-

Commit 0df30712b979e4fd2f413da4f3c3913a9a51956c in activemq-artemis's branch 
refs/heads/master from jbertram
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=0df3071 ]

ARTEMIS-808 use privileges to stop executor


> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Assignee: Justin Bertram
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586663#comment-15586663
 ] 

ASF GitHub Bot commented on ARTEMIS-808:


Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/847
  
@jmesnil, is this what you're looking for?


> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586660#comment-15586660
 ] 

ASF GitHub Bot commented on ARTEMIS-808:


GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/847

ARTEMIS-808 use privileges to stop executor



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-808

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/847.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #847


commit d720c5e47c4282ea323d065dd2b02442270dc72a
Author: jbertram 
Date:   2016-10-18T21:03:59Z

ARTEMIS-808 use privileges to stop executor




> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-808) AccessControlException when closing a connection with a security manager.

2016-10-18 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586287#comment-15586287
 ] 

clebert suconic commented on ARTEMIS-808:
-

[~jmesnil] do you have a Patch?

> AccessControlException when closing a connection with a security manager.
> -
>
> Key: ARTEMIS-808
> URL: https://issues.apache.org/jira/browse/ARTEMIS-808
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.4.0
>Reporter: Jeff Mesnil
>Priority: Blocker
> Fix For: 1.5.0
>
>
> We have spotted a regression from Artemis 1.1.x to 1.4.0 when a client with a 
> security manager closes a JMS connection:
> {noformat}
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage: 
> java.security.AccessControlException: WFSM01: Permission check failed 
> (permission "("java.lang.RuntimePermission" "modifyThread")" in code source 
> "(vfs:/content/test.jar )" of "ModuleClassLoader for 
> Module "deployment.test.jar:main" from Service Module Loader")
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:278)
> at 
> org.wildfly.security.manager.WildFlySecurityManager.checkPermission(WildFlySecurityManager.java:175)
> at 
> java.util.concurrent.ThreadPoolExecutor.checkShutdownAccess(ThreadPoolExecutor.java:735)
> at 
> java.util.concurrent.ThreadPoolExecutor.shutdown(ThreadPoolExecutor.java:1387)
> at 
> org.apache.activemq.artemis.jms.client.ActiveMQConnection.close(ActiveMQConnection.java:366)
> at 
> org.jboss.as.test.smoke.jms.SendToJMSTopicTest.sendMessage(SendToJMSTopicTest.java:113)
> {noformat}
> I suspect that the change that was made for ARTEMIS-538 must ensure that the 
> executor is shutdown in an priviledged block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)