[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870331#comment-15870331 ] ASF subversion and git services commented on ARTEMIS-815: - Commit 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a in activemq-artemis's branch refs/heads/master from [~dejanb] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=21b64b3 ] https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870334#comment-15870334 ] ASF subversion and git services commented on ARTEMIS-815: - Commit 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a in activemq-artemis's branch refs/heads/master from [~dejanb] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=21b64b3 ] https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870333#comment-15870333 ] ASF subversion and git services commented on ARTEMIS-815: - Commit 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a in activemq-artemis's branch refs/heads/master from [~dejanb] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=21b64b3 ] https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870332#comment-15870332 ] ASF subversion and git services commented on ARTEMIS-815: - Commit 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a in activemq-artemis's branch refs/heads/master from [~dejanb] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=21b64b3 ] https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870335#comment-15870335 ] ASF GitHub Bot commented on ARTEMIS-815: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1021 > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869760#comment-15869760 ] ASF GitHub Bot commented on ARTEMIS-815: Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1021 This is a rebased version of #964 > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869762#comment-15869762 ] ASF GitHub Bot commented on ARTEMIS-815: Github user dejanb closed the pull request at: https://github.com/apache/activemq-artemis/pull/964 > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869761#comment-15869761 ] ASF GitHub Bot commented on ARTEMIS-815: Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/964 Great. Thanks! > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869757#comment-15869757 ] ASF GitHub Bot commented on ARTEMIS-815: Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb I've rebased and pushed another PR (so we get the PR checks) at #1021. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869756#comment-15869756 ] ASF GitHub Bot commented on ARTEMIS-815: GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/1021 https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard … …address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis ARTEMIS-815 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1021.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1021 commit 46e6c609508e771fb1af9bdb24c2c647de738107 Author: Dejan Bosanac Date: 2017-01-17T14:44:28Z https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method https://issues.apache.org/jira/browse/ARTEMIS-815 - added tests for mqtt-openwire integration and fixed openwire layer https://issues.apache.org/jira/browse/ARTEMIS-815 - remove unused imports > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856029#comment-15856029 ] ASF GitHub Bot commented on ARTEMIS-815: Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/964 Looks like you may need to rebase. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854669#comment-15854669 ] ASF GitHub Bot commented on ARTEMIS-815: Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb, where are you on the test effort? Also, can you amend your commit message to follow the 50/72 format discussed in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails)? > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1582#comment-1582 ] ASF GitHub Bot commented on ARTEMIS-815: Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @clebertsuconic It's not a new functionality, it's just adjusting mqtt layer code, which used hard-coded wildcard characters. I'll add a test to verify wildcard syntax of ActiveMQ 5, works fine and that we can exchange messages between mqtt and JMS clients. That should help with future migrations > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826342#comment-15826342 ] ASF GitHub Bot commented on ARTEMIS-815: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/964 @dejanb I am confused.. is this new functionality, or this is just a refactoring of an existing one (on which case you wouldn't need tests). > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826329#comment-15826329 ] ASF GitHub Bot commented on ARTEMIS-815: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/964 A test would be nice > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826173#comment-15826173 ] ASF GitHub Bot commented on ARTEMIS-815: GitHub user dejanb opened a pull request: https://github.com/apache/activemq-artemis/pull/964 https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard … …address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejanb/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/964.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #964 commit 79e695872d713089d79c93297d5d72545f3bba5a Author: Dejan Bosanac Date: 2017-01-17T14:44:28Z https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer https://issues.apache.org/jira/browse/ARTEMIS-815 - support wildcard address configuration in mqtt layer - remove old swap method > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac >Assignee: Justin Bertram > Fix For: 2.0.0 > > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798570#comment-15798570 ] ASF GitHub Bot commented on ARTEMIS-815: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/941 > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798568#comment-15798568 ] ASF subversion and git services commented on ARTEMIS-815: - Commit 668f4721f045c18d95e2dc524694b8ac725809b1 in activemq-artemis's branch refs/heads/master from [~dejanb] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=668f472 ] https://issues.apache.org/jira/browse/ARTEMIS-815 - implement configurable wildcard addresses syntax Rename WildCardConfigurationTest.java to WildcardConfigurationTest.java adjust schema > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798539#comment-15798539 ] ASF GitHub Bot commented on ARTEMIS-815: Github user jbertram commented on the issue: https://github.com/apache/activemq-artemis/pull/941 I'm running the PR build locally. I'll merge it if all goes well. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798088#comment-15798088 ] ASF GitHub Bot commented on ARTEMIS-815: Github user dejanb commented on the issue: https://github.com/apache/activemq-artemis/pull/941 retest this please > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798082#comment-15798082 ] ASF GitHub Bot commented on ARTEMIS-815: Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/941 retest this please > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15798081#comment-15798081 ] ASF GitHub Bot commented on ARTEMIS-815: Github user andytaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/941 please retest this > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772577#comment-15772577 ] Dejan Bosanac commented on ARTEMIS-815: --- It also makes the old `wild-card-routing-enabled` configuration parameter deprecated. I didn't removed it yet, but there's a log message if it's used. We can remove it in future versions. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772572#comment-15772572
]
Dejan Bosanac commented on ARTEMIS-815:
---
This PR implements configurable wildcards. The syntax is configured in
broker.xml like
{code}
true
.
#
*
{code}
> Make address path separator configurable
>
>
> Key: ARTEMIS-815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-815
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
>Reporter: Dejan Bosanac
>
> Currently address path separator is '.' character, like USERS.TEST. In some
> environments, other characters are used, mostly '/' (e.g. USERS/TEST). We
> should make the broker work properly with those addresses as well (wildcards,
> configurations, etc.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772561#comment-15772561 ] ASF GitHub Bot commented on ARTEMIS-815: GitHub user dejanb opened a pull request: https://github.com/apache/activemq-artemis/pull/941 https://issues.apache.org/jira/browse/ARTEMIS-815 - implement configu… …rable wildcard addresses syntax You can merge this pull request into a Git repository by running: $ git pull https://github.com/dejanb/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #941 commit 5136a829dea320309e939f9f3f472144133d43d7 Author: Dejan Bosanac Date: 2016-12-23T11:02:30Z https://issues.apache.org/jira/browse/ARTEMIS-815 - implement configurable wildcard addresses syntax > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670701#comment-15670701 ] clebert suconic commented on ARTEMIS-815: - Good point, this issue actually duplicated ARTEMIS-410 (that you opened) > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670682#comment-15670682 ] clebert suconic commented on ARTEMIS-815: - this duplicates https://issues.apache.org/jira/browse/ARTEMIS-410 > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664158#comment-15664158 ] Justin Bertram commented on ARTEMIS-815: In general, greater configurability is certainly a win. I understand that point. Perhaps I misunderstood, but your previous comment didn't appear to me to be making this general point (at least not exclusively). You seemed to be requesting configurability for specific options for some features which don't exist in Artemis. I just meant to clarify the options which would be made configurable as part of the work for ARTEMIS-780. I appreciate your feed-back. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662972#comment-15662972 ] Lionel Cons commented on ARTEMIS-815: - Justin, you know better than me what is supported or not in Artemis. The point is: if you want to make Artemis flexible and easy to use in replacement of other brokers such as ActiveMQ or Apollo then you should make all of these options configurable in Artemis. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[ https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657295#comment-15657295 ] Justin Bertram commented on ARTEMIS-815: The destination prefixes for STOMP will be made configurable as part of the work for ARTEMIS-780. However, the rest of those configuration options appear to be applicable to composite destination and subscription wild-card use-cases which, to my knowledge, are not yet supported in Artemis. Please correct me if I'm wrong on this. > Make address path separator configurable > > > Key: ARTEMIS-815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-815 > Project: ActiveMQ Artemis > Issue Type: Sub-task >Reporter: Dejan Bosanac > > Currently address path separator is '.' character, like USERS.TEST. In some > environments, other characters are used, mostly '/' (e.g. USERS/TEST). We > should make the broker work properly with those addresses as well (wildcards, > configurations, etc.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-815) Make address path separator configurable
[
https://issues.apache.org/jira/browse/ARTEMIS-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657005#comment-15657005
]
Lionel Cons commented on ARTEMIS-815:
-
IMHO, address path separators are just one of several things that should be
configurable in Artemis.
Here is for instance what can be configured in Apollo:
{noformat}
queue_prefix : Defaults to /queue/
topic_prefix : Defaults to /topic/
path_separator : Defaults to .
destination_separator : Defaults to ,
any_child_wildcard : Defaults to *
regex_wildcard_start : Defaults to {
regex_wildcard_end : Defaults to }
any_descendant_wildcard : Defaults to **
{noformat}
(https://activemq.apache.org/apollo/documentation/stomp-manual.html#Stomp_Protocol_Options)
> Make address path separator configurable
>
>
> Key: ARTEMIS-815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-815
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
>Reporter: Dejan Bosanac
>
> Currently address path separator is '.' character, like USERS.TEST. In some
> environments, other characters are used, mostly '/' (e.g. USERS/TEST). We
> should make the broker work properly with those addresses as well (wildcards,
> configurations, etc.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
