[jira] [Work logged] (ARTEMIS-2477) create quieter check dependencies warning
[ https://issues.apache.org/jira/browse/ARTEMIS-2477?focusedWorklogId=309282=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309282 ] ASF GitHub Bot logged work on ARTEMIS-2477: --- Author: ASF GitHub Bot Created on: 09/Sep/19 21:43 Start Date: 09/Sep/19 21:43 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2827: ARTEMIS-2477 - create a less verbose and more descriptive warning whe… URL: https://github.com/apache/activemq-artemis/pull/2827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 309282) Time Spent: 40m (was: 0.5h) > create quieter check dependencies warning > - > > Key: ARTEMIS-2477 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2477 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The current checkdependencies checks print a whole stack trace which is > overkill if the Netty class isnt on the classpath, if its a class not found > we should give more descriptive help -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2477) create quieter check dependencies warning
[ https://issues.apache.org/jira/browse/ARTEMIS-2477?focusedWorklogId=308892=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308892 ] ASF GitHub Bot logged work on ARTEMIS-2477: --- Author: ASF GitHub Bot Created on: 09/Sep/19 14:09 Start Date: 09/Sep/19 14:09 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2827: ARTEMIS-2477 - create a less verbose and more descriptive warning whe… URL: https://github.com/apache/activemq-artemis/pull/2827#discussion_r322262800 ## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ## @@ -410,6 +410,15 @@ format = Message.Format.MESSAGE_FORMAT) void confirmationNotSet(); + @LogMessage(level = Logger.Level.WARN) + @Message(id = 212075, value = "KQueue is not available, please add to the classpath or configure useKQueue=false to remove this warning", + format = Message.Format.MESSAGE_FORMAT) + void unableToCheckKQueueAvailabilityNoClass(); + + @LogMessage(level = Logger.Level.WARN) + @Message(id = 212076, value = "epoll is not available, please add to the classpath or configure useEpoll=false to remove this warning", Review comment: I will merge it with some git-fu, ```sh ./scripts/checkout-PR.sh 2827 # ammend myself git commit -a --amend ./scripts/merge-branch 2827 git push apache master ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308892) Time Spent: 0.5h (was: 20m) > create quieter check dependencies warning > - > > Key: ARTEMIS-2477 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2477 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The current checkdependencies checks print a whole stack trace which is > overkill if the Netty class isnt on the classpath, if its a class not found > we should give more descriptive help -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2477) create quieter check dependencies warning
[ https://issues.apache.org/jira/browse/ARTEMIS-2477?focusedWorklogId=308779=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308779 ] ASF GitHub Bot logged work on ARTEMIS-2477: --- Author: ASF GitHub Bot Created on: 09/Sep/19 12:46 Start Date: 09/Sep/19 12:46 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2827: ARTEMIS-2477 - create a less verbose and more descriptive warning whe… URL: https://github.com/apache/activemq-artemis/pull/2827#discussion_r32104 ## File path: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/ActiveMQClientLogger.java ## @@ -410,6 +410,15 @@ format = Message.Format.MESSAGE_FORMAT) void confirmationNotSet(); + @LogMessage(level = Logger.Level.WARN) + @Message(id = 212075, value = "KQueue is not available, please add to the classpath or configure useKQueue=false to remove this warning", + format = Message.Format.MESSAGE_FORMAT) + void unableToCheckKQueueAvailabilityNoClass(); + + @LogMessage(level = Logger.Level.WARN) + @Message(id = 212076, value = "epoll is not available, please add to the classpath or configure useEpoll=false to remove this warning", Review comment: nit: Epoll This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308779) Time Spent: 20m (was: 10m) > create quieter check dependencies warning > - > > Key: ARTEMIS-2477 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2477 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The current checkdependencies checks print a whole stack trace which is > overkill if the Netty class isnt on the classpath, if its a class not found > we should give more descriptive help -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2477) create quieter check dependencies warning
[ https://issues.apache.org/jira/browse/ARTEMIS-2477?focusedWorklogId=308717=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308717 ] ASF GitHub Bot logged work on ARTEMIS-2477: --- Author: ASF GitHub Bot Created on: 09/Sep/19 10:13 Start Date: 09/Sep/19 10:13 Worklog Time Spent: 10m Work Description: andytaylor commented on pull request #2827: ARTEMIS-2477 - create a less verbose and more descriptive warning whe… URL: https://github.com/apache/activemq-artemis/pull/2827 …n the native Netty jars are not present on the classpath https://issues.apache.org/jira/browse/ARTEMIS-2477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308717) Remaining Estimate: 0h Time Spent: 10m > create quieter check dependencies warning > - > > Key: ARTEMIS-2477 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2477 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The current checkdependencies checks print a whole stack trace which is > overkill if the Netty class isnt on the classpath, if its a class not found > we should give more descriptive help -- This message was sent by Atlassian Jira (v8.3.2#803003)
