[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=368291=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368291 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 08/Jan/20 17:26 Start Date: 08/Jan/20 17:26 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368291) Time Spent: 1h 50m (was: 1h 40m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=368262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368262 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 08/Jan/20 16:50 Start Date: 08/Jan/20 16:50 Worklog Time Spent: 10m Work Description: jbertram commented on issue #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#issuecomment-572157569 @k-wall can you rebase this? Conflicts have developed. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 368262) Time Spent: 1h 40m (was: 1.5h) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=324023=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324023 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 06/Oct/19 08:06 Start Date: 06/Oct/19 08:06 Worklog Time Spent: 10m Work Description: k-wall commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r331776305 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java ## @@ -306,6 +306,8 @@ private Long globalMaxSize; + private boolean amqpTreatRejectAsUnmodifiedDeliveryFailed = ActiveMQDefaultConfiguration.getDefaultTreatRejectAsUnmodifiedDeliveryFailed(); Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324023) Time Spent: 1.5h (was: 1h 20m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=324022=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324022 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 06/Oct/19 08:05 Start Date: 06/Oct/19 08:05 Worklog Time Spent: 10m Work Description: k-wall commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r331776294 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -54,6 +54,15 @@ + Review comment: Done This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324022) Time Spent: 1h 20m (was: 1h 10m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=324021=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324021 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 06/Oct/19 08:05 Start Date: 06/Oct/19 08:05 Worklog Time Spent: 10m Work Description: k-wall commented on issue #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#issuecomment-538721906 @clebertsuconic review comments addressed and commits squashed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 324021) Time Spent: 1h 10m (was: 1h) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=319769=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319769 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 27/Sep/19 19:32 Start Date: 27/Sep/19 19:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r329220926 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java ## @@ -306,6 +306,8 @@ private Long globalMaxSize; + private boolean amqpTreatRejectAsUnmodifiedDeliveryFailed = ActiveMQDefaultConfiguration.getDefaultTreatRejectAsUnmodifiedDeliveryFailed(); Review comment: Are you changing this similar to your other featrure? add it to ProtonProtocolManager instead? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 319769) Time Spent: 1h (was: 50m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=316690=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316690 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 23/Sep/19 14:03 Start Date: 23/Sep/19 14:03 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#issuecomment-534113676 @k-wall I'm trying to minimize the number of options someone can configure on ConfigurationImpl. for protocol specific semantics, please use the ProtocolManager properties. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316690) Time Spent: 50m (was: 40m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=316659=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316659 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 23/Sep/19 13:31 Start Date: 23/Sep/19 13:31 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#issuecomment-534099706 Can you move this into the ProtonProtocolManager as a property, the acceptors can then configure this with a simple property. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316659) Time Spent: 40m (was: 0.5h) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=316654=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316654 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 23/Sep/19 13:30 Start Date: 23/Sep/19 13:30 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r327114316 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java ## @@ -306,6 +306,8 @@ private Long globalMaxSize; + private boolean amqpTreatRejectAsUnmodifiedDeliveryFailed = ActiveMQDefaultConfiguration.getDefaultTreatRejectAsUnmodifiedDeliveryFailed(); Review comment: I would use the ProtocolManager configuration, being a property of the acceptor, instead of a global property for such thing. That way you can configure this as part of the acceptor properties. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316654) Time Spent: 20m (was: 10m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=316656=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316656 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 23/Sep/19 13:30 Start Date: 23/Sep/19 13:30 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848#discussion_r327114631 ## File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd ## @@ -54,6 +54,15 @@ + Review comment: If you use the protocol manager (AMQP Protocol Manager, such property would just be part of BeanUtils, and you wouldn't need to change any schema. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316656) Time Spent: 0.5h (was: 20m) > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2497) Allow configuring alternative reject behavior for AMQP
[ https://issues.apache.org/jira/browse/ARTEMIS-2497?focusedWorklogId=316609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316609 ] ASF GitHub Bot logged work on ARTEMIS-2497: --- Author: ASF GitHub Bot Created on: 23/Sep/19 11:32 Start Date: 23/Sep/19 11:32 Worklog Time Spent: 10m Work Description: k-wall commented on pull request #2848: ARTEMIS-2497: [AMQP] Allow handling of the reject disposition to be configured URL: https://github.com/apache/activemq-artemis/pull/2848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 316609) Remaining Estimate: 0h Time Spent: 10m > Allow configuring alternative reject behavior for AMQP > -- > > Key: ARTEMIS-2497 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2497 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.10.0 >Reporter: Ulf Lilleengen >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In EnMasse, we use a broker plugin to forward messages to a remote AMQP > endpoint. If the remote endpoint responds with a reject, we would like to > retry the message. > > At present, the AMQP implementation will deal with rejects by immediately > putting the messages on a DLQ (if exists). > > It would be nice to have a configuration option to have rejects be treated > similarly to released by attempting retransmit before moving to DLQ. -- This message was sent by Atlassian Jira (v8.3.4#803005)
