[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570375#comment-15570375
 ] 

Hudson commented on AMBARI-18575:
-

SUCCESS: Integrated in Jenkins build Ambari-branch-2.5 #140 (See 
[https://builds.apache.org/job/Ambari-branch-2.5/140/])
AMBARI-18575. Fix for improving time taken by (sshridhar: 
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=4512f5525d129bdd4f73b68dfa139631d0368c35])
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java


> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0, 2.4.2
>
> Attachments: AMBARI-18575.patch
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Swapan Shridhar (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570147#comment-15570147
 ] 

Swapan Shridhar commented on AMBARI-18575:
--


*commits:*


*trunk:*

{code}
commit 911deb744485aa0366aad168c98566cf6381d4cc
Author: Swapan Shridhar 
Date:   Tue Oct 11 16:09:00 2016 -0700

AMBARI-18575. Fix for improving time taken by 
'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
{code}

*branch-2.4:*

{code}
commit fdc5bd3fdf23b2035a27648d2db20e22c2159a0b
Author: Swapan Shridhar 
Date:   Wed Oct 12 15:51:26 2016 -0700

AMBARI-18575. Fix for improving time taken by 
'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
{code}


*branch-2.5:*

{code}
commit 4512f5525d129bdd4f73b68dfa139631d0368c35
Author: Swapan Shridhar 
Date:   Tue Oct 11 16:09:00 2016 -0700

AMBARI-18575. Fix for improving time taken by 
'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.
{code}

> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0, 2.4.2
>
> Attachments: AMBARI-18575.patch
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570015#comment-15570015
 ] 

Hudson commented on AMBARI-18575:
-

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #5791 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/5791/])
AMBARI-18575. Fix for improving time taken by (sshridhar: 
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=911deb744485aa0366aad168c98566cf6381d4cc])
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java


> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0, 2.4.2
>
> Attachments: AMBARI-18575.patch
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Swapan Shridhar (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569448#comment-15569448
 ] 

Swapan Shridhar commented on AMBARI-18575:
--

After the fix, improved timings are as follows:


*ExecutionScheduleManagerTest :*


||After Improvements|| Before Improvement||
|~11.3 secs| ~30.6 secs|


*UpgradeCatalog221Test :* 


||After Improvements|| Before Improvement||
|~11.0 secs| ~30.5 secs|



> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0, 2.4.2
>
> Attachments: AMBARI-18575.patch
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567184#comment-15567184
 ] 

Hadoop QA commented on AMBARI-18575:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12832790/AMBARI-18575.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8845//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8845//console

This message is automatically generated.

> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0, 2.4.2
>
> Attachments: AMBARI-18575.patch
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMBARI-18575) Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-11 Thread Swapan Shridhar (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566908#comment-15566908
 ] 

Swapan Shridhar commented on AMBARI-18575:
--

Individual tests time taken is as follows:

*UpgradeCatalog221Test:*

- init() function takes most of the time.

||Test No.||Test||Time (micro secs)||
| |init()|10197|
|1|testUpdateAmsHbaseSiteConfigs| 198|
| |init()|3140|
|2|testExecuteDDLUpdates| 17|
| |init()|2377|
|3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
| |init()|2396|
|4|testExecuteDMLUpdates| 18|
| |init()|2203|
|5|testUpdateTezConfigs| 11|
| |init()|2011|
|6|testUpdateAmsHbaseEnvContent| 0|
| |init()|1953|
|7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
| |init()|1882|
|8|testUpdateOozieConfigs| 2|
| |init()|1871|
|9|testUpdateAmsEnvContent| 0|
| |init()|1801|
|10|testUpdateRangerKmsDbksConfigs| 2|
| |init()|1735|
|11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
| |init()|1693|
|12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
| |init()|1626|
|13|testUpdateAlertDefinitions| 19|





*ExecutionScheduleManagerTest:*
- setup() function takes most of the time.

||Test No.||Test||Time (micro secs)||
| |setup()|10111|
|1|testUpdateBatchRequest| 249|
| |after()|2|
| |setup()|3234|
|2|testExecuteBatchRequest| 59|
| |after()|1|
| |setup()|2480|
|3|testScheduleBatch| 40|
| |after()|1|
| |setup()|2381|
|4|testFinalizeBeforeExit| 28|
| |after()|1|
| |setup()|2312|
|5|testDeleteAllJobs| 17|
| |after()|1|
| |setup()|2141|
|6|testFinalizeBatch| 64|
| |after()|1|
| |setup()|1970|
|7|testPointInTimeExecutionJob| 18|
| |after()|2|
| |setup()|1944|
|8|testHasToleranceThresholdExceeded| 68|
| |after()|1|
| |setup()|1994|
|9|testGetBatchRequestResponse| 59|
| |after()|1|


- Thus, majority time is taken by the setup methods, and they are @Before 
methods.

*Fix:* Make then @BeforeClass methods.

> Fix for improving time taken by 'ExecutionScheduleManagerTest' and 
> 'UpgradeCatalog221Test' java tests.
> --
>
> Key: AMBARI-18575
> URL: https://issues.apache.org/jira/browse/AMBARI-18575
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.4.2
>Reporter: Swapan Shridhar
>Assignee: Swapan Shridhar
> Fix For: 2.5.0
>
>
> Current time taken:
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> Initially reported as part of test improvements (along with other tests) in 
> BUG : BUG-65777



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)