[jira] [Commented] (AMBARI-18594) AMBARI-18051 Breaks Stack Upgrade Checks

2016-10-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575767#comment-15575767
 ] 

Hudson commented on AMBARI-18594:
-

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #5801 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/5801/])
AMBARI-18594 - AMBARI-18051 Breaks Stack Upgrade Checks (tthorpe: 
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=10c7595a4ac858ac5a095f2caf8770f1ea685c1c])
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java
* (edit) 
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java


> AMBARI-18051 Breaks Stack Upgrade Checks
> 
>
> Key: AMBARI-18594
> URL: https://issues.apache.org/jira/browse/AMBARI-18594
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: trunk
>Reporter: Jonathan Hurley
>Assignee: Tim Thorpe
>Priority: Blocker
> Fix For: trunk, 2.5.0, 2.4.2
>
> Attachments: AMBARI-18594.patch
>
>
> AMBARI-18051 adds logic which breaks upgrades. The following adds:
> https://github.com/apache/ambari/commit/87423d64f54d896c62d1a9245eb03a97763e35a4#diff-5a960f81153cabb6a060631fd802d076R197
> {code}
> Map services = 
> getManagementController().getAmbariMetaInfo().getServices(stackName, 
> upgradePack.getTarget());
> {code}
> Which translates into {{getServices("HDP", "2.4.\*.\*")}}
> When attempting an upgrade, we now see this exception thrown and some of the 
> upgrade checks do not run:
> {code}
> 2016-10-13 16:44:18,806 ERROR [ambari-client-thread-34] 
> (PreUpgradeCheckResourceProvider.java:202) getResources() - Unable to 
> register all the custom prechecks from the services
> org.apache.ambari.server.ParentObjectNotFoundException: Parent Stack Version 
> resource doesn't exist.  Stack data, Stack HDP 2.4.*.* is not found in Ambari 
> metainfo.  Stack data, Stack HDP 2.4.*.* is not found in Ambari metainfo
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.getServices(AmbariMetaInfo.java:529)
>   at 
> org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider.getResources(PreUpgradeCheckResourceProvider.java:198)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl$ExtendedResourceProviderWrapper.queryForResources(ClusterControllerImpl.java:966)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.getResources(ClusterControllerImpl.java:141)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.doQuery(QueryImpl.java:529)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.queryForResources(QueryImpl.java:398)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:222)
>   at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
>   at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
>   at 
> org.apache.ambari.server.api.services.PreUpgradeCheckService.getPreUpgradeChecks(PreUpgradeCheckService.java:61)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.W

[jira] [Commented] (AMBARI-18594) AMBARI-18051 Breaks Stack Upgrade Checks

2016-10-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575751#comment-15575751
 ] 

Hudson commented on AMBARI-18594:
-

SUCCESS: Integrated in Jenkins build Ambari-branch-2.5 #148 (See 
[https://builds.apache.org/job/Ambari-branch-2.5/148/])
AMBARI-18594 - AMBARI-18051 Breaks Stack Upgrade Checks (tthorpe: 
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=cb9db0aef3d2ee6c11d9d7f15c4a4709c14dd1a8])
* (edit) 
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
* (edit) 
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java


> AMBARI-18051 Breaks Stack Upgrade Checks
> 
>
> Key: AMBARI-18594
> URL: https://issues.apache.org/jira/browse/AMBARI-18594
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: trunk
>Reporter: Jonathan Hurley
>Assignee: Tim Thorpe
>Priority: Blocker
> Fix For: trunk, 2.5.0, 2.4.2
>
> Attachments: AMBARI-18594.patch
>
>
> AMBARI-18051 adds logic which breaks upgrades. The following adds:
> https://github.com/apache/ambari/commit/87423d64f54d896c62d1a9245eb03a97763e35a4#diff-5a960f81153cabb6a060631fd802d076R197
> {code}
> Map services = 
> getManagementController().getAmbariMetaInfo().getServices(stackName, 
> upgradePack.getTarget());
> {code}
> Which translates into {{getServices("HDP", "2.4.\*.\*")}}
> When attempting an upgrade, we now see this exception thrown and some of the 
> upgrade checks do not run:
> {code}
> 2016-10-13 16:44:18,806 ERROR [ambari-client-thread-34] 
> (PreUpgradeCheckResourceProvider.java:202) getResources() - Unable to 
> register all the custom prechecks from the services
> org.apache.ambari.server.ParentObjectNotFoundException: Parent Stack Version 
> resource doesn't exist.  Stack data, Stack HDP 2.4.*.* is not found in Ambari 
> metainfo.  Stack data, Stack HDP 2.4.*.* is not found in Ambari metainfo
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.getServices(AmbariMetaInfo.java:529)
>   at 
> org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider.getResources(PreUpgradeCheckResourceProvider.java:198)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl$ExtendedResourceProviderWrapper.queryForResources(ClusterControllerImpl.java:966)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.getResources(ClusterControllerImpl.java:141)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.doQuery(QueryImpl.java:529)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.queryForResources(QueryImpl.java:398)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:222)
>   at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
>   at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
>   at 
> org.apache.ambari.server.api.services.PreUpgradeCheckService.getPreUpgradeChecks(PreUpgradeCheckService.java:61)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebAppl

[jira] [Commented] (AMBARI-18594) AMBARI-18051 Breaks Stack Upgrade Checks

2016-10-14 Thread Tim Thorpe (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15575580#comment-15575580
 ] 

Tim Thorpe commented on AMBARI-18594:
-

[~jonathan.hurley] I have been trying to get all the changes related to custom 
service support into one branch.  I had planned on putting them in 2.5 but then 
one related to this went in 2.4.  
https://issues.apache.org/jira/browse/AMBARI-15538

This was the last item that I was aware of to help custom services be fully 
integrated in the stack for role command order, stack advisor and upgrade.

> AMBARI-18051 Breaks Stack Upgrade Checks
> 
>
> Key: AMBARI-18594
> URL: https://issues.apache.org/jira/browse/AMBARI-18594
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.5.0
>Reporter: Jonathan Hurley
>Assignee: Tim Thorpe
>Priority: Blocker
> Fix For: 2.5.0
>
>
> AMBARI-18051 adds logic which breaks upgrades. The following adds:
> https://github.com/apache/ambari/commit/87423d64f54d896c62d1a9245eb03a97763e35a4#diff-5a960f81153cabb6a060631fd802d076R197
> {code}
> Map services = 
> getManagementController().getAmbariMetaInfo().getServices(stackName, 
> upgradePack.getTarget());
> {code}
> Which translates into {{getServices("HDP", "2.4.\*.\*")}}
> When attempting an upgrade, we now see this exception thrown and some of the 
> upgrade checks do not run:
> {code}
> 2016-10-13 16:44:18,806 ERROR [ambari-client-thread-34] 
> (PreUpgradeCheckResourceProvider.java:202) getResources() - Unable to 
> register all the custom prechecks from the services
> org.apache.ambari.server.ParentObjectNotFoundException: Parent Stack Version 
> resource doesn't exist.  Stack data, Stack HDP 2.4.*.* is not found in Ambari 
> metainfo.  Stack data, Stack HDP 2.4.*.* is not found in Ambari metainfo
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.getServices(AmbariMetaInfo.java:529)
>   at 
> org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider.getResources(PreUpgradeCheckResourceProvider.java:198)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl$ExtendedResourceProviderWrapper.queryForResources(ClusterControllerImpl.java:966)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.getResources(ClusterControllerImpl.java:141)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.doQuery(QueryImpl.java:529)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.queryForResources(QueryImpl.java:398)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:222)
>   at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
>   at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
>   at 
> org.apache.ambari.server.api.services.PreUpgradeCheckService.getPreUpgradeChecks(PreUpgradeCheckService.java:61)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
>   at 
> com

[jira] [Commented] (AMBARI-18594) AMBARI-18051 Breaks Stack Upgrade Checks

2016-10-13 Thread Jonathan Hurley (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMBARI-18594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573137#comment-15573137
 ] 

Jonathan Hurley commented on AMBARI-18594:
--

cc [~Tim Thorpe] ...

Why was the breaking commit pushed to {{branch-2.4}}? We probably shouldn't be 
pushing these changes to branches which are in maintenance.

> AMBARI-18051 Breaks Stack Upgrade Checks
> 
>
> Key: AMBARI-18594
> URL: https://issues.apache.org/jira/browse/AMBARI-18594
> Project: Ambari
>  Issue Type: Bug
>  Components: ambari-server
>Affects Versions: 2.5.0
>Reporter: Jonathan Hurley
>Priority: Blocker
> Fix For: 2.5.0
>
>
> AMBARI-18051 adds logic which breaks upgrades. The following adds:
> https://github.com/apache/ambari/commit/87423d64f54d896c62d1a9245eb03a97763e35a4#diff-5a960f81153cabb6a060631fd802d076R197
> {code}
> Map services = 
> getManagementController().getAmbariMetaInfo().getServices(stackName, 
> upgradePack.getTarget());
> {code}
> Which translates into {{getServices("HDP", "2.4.\*.\*")}}
> When attempting an upgrade, we now see this exception thrown and some of the 
> upgrade checks do not run:
> {code}
> 2016-10-13 16:44:18,806 ERROR [ambari-client-thread-34] 
> (PreUpgradeCheckResourceProvider.java:202) getResources() - Unable to 
> register all the custom prechecks from the services
> org.apache.ambari.server.ParentObjectNotFoundException: Parent Stack Version 
> resource doesn't exist.  Stack data, Stack HDP 2.4.*.* is not found in Ambari 
> metainfo.  Stack data, Stack HDP 2.4.*.* is not found in Ambari metainfo
>   at 
> org.apache.ambari.server.api.services.AmbariMetaInfo.getServices(AmbariMetaInfo.java:529)
>   at 
> org.apache.ambari.server.controller.internal.PreUpgradeCheckResourceProvider.getResources(PreUpgradeCheckResourceProvider.java:198)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl$ExtendedResourceProviderWrapper.queryForResources(ClusterControllerImpl.java:966)
>   at 
> org.apache.ambari.server.controller.internal.ClusterControllerImpl.getResources(ClusterControllerImpl.java:141)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.doQuery(QueryImpl.java:529)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.queryForResources(QueryImpl.java:398)
>   at 
> org.apache.ambari.server.api.query.QueryImpl.execute(QueryImpl.java:222)
>   at 
> org.apache.ambari.server.api.handlers.ReadHandler.handleRequest(ReadHandler.java:77)
>   at 
> org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:145)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
>   at 
> org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
>   at 
> org.apache.ambari.server.api.services.PreUpgradeCheckService.getPreUpgradeChecks(PreUpgradeCheckService.java:61)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.SubLocatorRule.accept(SubLocatorRule.java:137)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
>   at 
> com.sun.jersey.spi.container.serv