[
https://issues.apache.org/jira/browse/AMBARI-18614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589229#comment-15589229
]
Hudson commented on AMBARI-18614:
-
FAILURE: Integrated in Jenkins build Ambari-trunk-Commit #5826 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/5826/])
AMBARI-18614 - Remove Unnecessary Locks Inside Of SCH Business Object (jhurley:
[http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=2c6008293a664ab3b0f24a3f22be54fe0e5f1faf])
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/HostConfig.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ServiceComponentHostConcurrentWriteDeadlockTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/agent/HeartbeatProcessorTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceComponentTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java
* (edit)
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterImplTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/configuration/RecoveryConfigHelperTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
* (edit)
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
> Remove Unnecessary Locks Inside Of SCH Business Object Implementations
> --
>
> Key: AMBARI-18614
> URL: https://issues.apache.org/jira/browse/AMBARI-18614
> Project: Ambari
> Issue Type: Task
> Components: ambari-server
>Affects Versions: 2.5.0
>Reporter: Jonathan Hurley
>Assignee: Jonathan Hurley
>Priority: Critical
> Fix For: 2.5.0
>
> Attachments: AMBARI-18614.patch
>
>
> Many of the business object implementations include needless locks which
> simply add the overhead and contention in larger clusters. Some examples of
> these are :
> - HostImpl
> -- get/set DisksInfo()
> -- get/set TotalMemBytes()
> - ServiceComponentHostImpl
> -- get/set MaintenanceState()
> -- get/set LastOpLastUpdateTime()
> These types of methods are found on other business classes as well, like
> {{ClusterImpl}} and {{ServiceImpl}}. Additionally, methods like
> {{convertToResponse()}} and {{debugDump()}} need not acquire locks since they
> are used mostly for serialization of data to the web client where the data
> will then immediately become stale anyway.
> The {{ServiceComponentHost}} business object should have the following work
> performed:
> - Remove locking around areas where its no longer required
> - Replace collections with thread-safe concurrent versions
> - Remove some reliance on state-full business objects (caches)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
