[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558446#comment-15558446 ] Leif Walsh commented on ARROW-189: -- I can take this, I have it working, just need to clean

[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558447#comment-15558447 ] Leif Walsh commented on ARROW-189: -- Do you also want to remove the ability to use the old

[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558671#comment-15558671 ] Leif Walsh commented on ARROW-189: -- What is "the right thing"? How can I test what you nee

[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558688#comment-15558688 ] Leif Walsh commented on ARROW-189: -- Right, so I'd delete that if I didn't know better. Wha

[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558695#comment-15558695 ] Leif Walsh commented on ARROW-189: -- Oh, I see, you still want downstream packagers to be a

[jira] [Commented] (ARROW-112) [C++] Style fix for constants/enums

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558850#comment-15558850 ] Leif Walsh commented on ARROW-112: -- I've done most of this I think, did you also want to c

[jira] [Commented] (ARROW-112) [C++] Style fix for constants/enums

2016-10-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558882#comment-15558882 ] Leif Walsh commented on ARROW-112: -- Ok, cool. Glad I put them in separate commits then :)

[jira] [Commented] (ARROW-189) C++: Use ExternalProject to build thirdparty dependencies

2016-10-10 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563958#comment-15563958 ] Leif Walsh commented on ARROW-189: -- https://github.com/apache/arrow/pull/167 > C++: Use E

[jira] [Commented] (ARROW-112) [C++] Style fix for constants/enums

2016-10-10 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563959#comment-15563959 ] Leif Walsh commented on ARROW-112: -- https://github.com/apache/arrow/pull/168 > [C++] Sty

[jira] [Commented] (ARROW-317) [C++] Implement zero-copy Slice method on arrow::Buffer that retains reference to parent

2016-10-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15567513#comment-15567513 ] Leif Walsh commented on ARROW-317: -- How does this relate to ARROW-33? > [C++] Implement z

[jira] [Created] (ARROW-2403) [C++] arrow::CpuInfo::model_name_ destructed twice on exit

2018-04-05 Thread Leif Walsh (JIRA)
Leif Walsh created ARROW-2403: - Summary: [C++] arrow::CpuInfo::model_name_ destructed twice on exit Key: ARROW-2403 URL: https://issues.apache.org/jira/browse/ARROW-2403 Project: Apache Arrow Iss

[jira] [Commented] (ARROW-2403) [C++] arrow::CpuInfo::model_name_ destructed twice on exit

2018-04-06 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428436#comment-16428436 ] Leif Walsh commented on ARROW-2403: --- I'll take a look at that, thanks.  That's the form

[jira] [Commented] (ARROW-2403) [C++] arrow::CpuInfo::model_name_ destructed twice on exit

2018-04-06 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429152#comment-16429152 ] Leif Walsh commented on ARROW-2403: --- Ok, my problem was that parquet-cpp was built linki

[jira] [Resolved] (ARROW-2403) [C++] arrow::CpuInfo::model_name_ destructed twice on exit

2018-04-06 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Walsh resolved ARROW-2403. --- Resolution: Fixed Assignee: Leif Walsh > [C++] arrow::CpuInfo::model_name_ destructed twice on e

[jira] [Commented] (ARROW-585) [C++] Define public API for user-defined data types

2019-02-09 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16764273#comment-16764273 ] Leif Walsh commented on ARROW-585: -- Could you describe the planned interface for defining

[jira] [Commented] (ARROW-585) [C++] Define public API for user-defined data types

2019-02-18 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771338#comment-16771338 ] Leif Walsh commented on ARROW-585: -- Looks reasonable, I'm curious how the java side would

[jira] [Commented] (ARROW-379) Python: Use setuptools_scm/setuptools_scm_git_archive to provide the version number

2016-12-17 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15757648#comment-15757648 ] Leif Walsh commented on ARROW-379: -- Did anyone add a conda-forge package for {{setuptools_

[jira] [Commented] (ARROW-379) Python: Use setuptools_scm/setuptools_scm_git_archive to provide the version number

2016-12-17 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758348#comment-15758348 ] Leif Walsh commented on ARROW-379: -- Perfect, thanks. > Python: Use setuptools_scm/setupto

[jira] [Commented] (ARROW-379) Python: Use setuptools_scm/setuptools_scm_git_archive to provide the version number

2016-12-17 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15758361#comment-15758361 ] Leif Walsh commented on ARROW-379: -- Hmm, maybe not perfect. With the pyarrow-feedstock re

[jira] [Assigned] (ARROW-783) Integration tests fail for length-0 record batch

2017-04-07 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Walsh reassigned ARROW-783: Assignee: Leif Walsh > Integration tests fail for length-0 record batch > --

[jira] [Commented] (ARROW-783) Integration tests fail for length-0 record batch

2017-04-07 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961381#comment-15961381 ] Leif Walsh commented on ARROW-783: -- Hi all. How can I run the tests that fail and does an

[jira] [Commented] (ARROW-773) [C++] Add function to create arrow::Table with column appended to existing table

2017-04-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961994#comment-15961994 ] Leif Walsh commented on ARROW-773: -- [~wesmckinn] where should I add this and what should i

[jira] [Commented] (ARROW-773) [C++] Add function to create arrow::Table with column appended to existing table

2017-04-08 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961997#comment-15961997 ] Leif Walsh commented on ARROW-773: -- Welp. Ok, that's better tested than mine. Awesome.

[jira] [Created] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
Leif Walsh created ARROW-805: Summary: listing empty HDFS directory returns an error instead of returning empty list Key: ARROW-805 URL: https://issues.apache.org/jira/browse/ARROW-805 Project: Apache Arr

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964439#comment-15964439 ] Leif Walsh commented on ARROW-805: -- Does that fix look right? If so I can implement and te

[jira] [Assigned] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Walsh reassigned ARROW-805: Assignee: Leif Walsh > listing empty HDFS directory returns an error instead of returning empty list

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964458#comment-15964458 ] Leif Walsh commented on ARROW-805: -- How should I use that? docker run bash and build/run

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964499#comment-15964499 ] Leif Walsh commented on ARROW-805: -- Okay, I got it set up but got a failure, I think it mi

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965024#comment-15965024 ] Leif Walsh commented on ARROW-805: -- Good news, everyone! I got these tests to pass. I ha

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965027#comment-15965027 ] Leif Walsh commented on ARROW-805: -- Living proof: {noformat} ubuntu@49b5b4f128cb:~/build$

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965046#comment-15965046 ] Leif Walsh commented on ARROW-805: -- Ok then, let's just focus on merging this then. > li

[jira] [Commented] (ARROW-805) listing empty HDFS directory returns an error instead of returning empty list

2017-04-11 Thread Leif Walsh (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965047#comment-15965047 ] Leif Walsh commented on ARROW-805: -- Ok then, let's just focus on merging this then. > li