[GitHub] [arrow-testing] wesm commented on pull request #31: update int64 columns to use string values

2020-06-29 Thread GitBox 


wesm commented on pull request #31:
URL: https://github.com/apache/arrow-testing/pull/31#issuecomment-651422520


   OK, passing now (fun times with emacs regexp-replace).
   
   https://gist.github.com/wesm/b7ed6934ef7753c2087919156c751bf4
   
   +1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-testing] wesm commented on pull request #31: update int64 columns to use string values

2020-06-29 Thread GitBox 


wesm commented on pull request #31:
URL: https://github.com/apache/arrow-testing/pull/31#issuecomment-651418744


   Ah the interval and datetime tests also have the issue
   
   https://gist.github.com/wesm/bf650d27557e90b4833054ab01783623
   
   I'll try to fix them locally



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-testing] wesm commented on pull request #31: update int64 columns to use string values

2020-06-29 Thread GitBox 


wesm commented on pull request #31:
URL: https://github.com/apache/arrow-testing/pull/31#issuecomment-651145516


   @emkornfield @pitrou I'll try to test these locally



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow-testing] wesm commented on pull request #31: update int64 columns to use string values

2020-06-28 Thread GitBox 


wesm commented on pull request #31:
URL: https://github.com/apache/arrow-testing/pull/31#issuecomment-650894424


   It's possible this dictionary test uses strings too 
https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/datagen.py#L1426



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org