Re: [I] [C++] Lost are_cols_in_encoding_order condition in NullUpdateColumnToRowImp_avx2 [arrow]

2024-05-07 Thread via GitHub 


pitrou closed issue #40997: [C++] Lost are_cols_in_encoding_order condition in 
NullUpdateColumnToRowImp_avx2
URL: https://github.com/apache/arrow/issues/40997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[I] [C++] Lost are_cols_in_encoding_order condition in NullUpdateColumnToRowImp_avx2 [arrow]

2024-04-03 Thread via GitHub 


ZhangHuiGui opened a new issue, #40997:
URL: https://github.com/apache/arrow/issues/40997

   ### Describe the bug, including details regarding any error messages, 
version, and platform.
   
   Recently, we find that the compare internal's avx2 function 
`NullUpdateColumnToRowImp_avx2` lost the `are_cols_in_encoding_order` check 
when get `null_bit_id`. It may cause grouper's compare result 
wrong(are_cols_in_encoding_order = true in grouper).
   
   avx2:
   
https://github.com/apache/arrow/blob/36ed0328b43ca39533e58a889f8e091d1f1ca7dc/cpp/src/arrow/compute/row/compare_internal_avx2.cc#L47
   
   non-avx2:
   
https://github.com/apache/arrow/blob/36ed0328b43ca39533e58a889f8e091d1f1ca7dc/cpp/src/arrow/compute/row/compare_internal.cc#L53-L54
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org