[jira] [Commented] (ARROW-1339) [C++] Use boost::filesystem for handling of platform-specific file path encodings

2017-08-11 Thread Wes McKinney (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123406#comment-16123406
 ] 

Wes McKinney commented on ARROW-1339:
-

I don't think so. The only complexity is getting the UTF8-encoded path so that 
console error messages displayed properly. But we have a unit test for this 
now, so it should be safe to refactor

> [C++] Use boost::filesystem for handling of platform-specific file path 
> encodings
> -
>
> Key: ARROW-1339
> URL: https://issues.apache.org/jira/browse/ARROW-1339
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
>Assignee: Max Risuhin
> Fix For: 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ARROW-1339) [C++] Use boost::filesystem for handling of platform-specific file path encodings

2017-08-10 Thread Max Risuhin (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-1339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122080#comment-16122080
 ] 

Max Risuhin commented on ARROW-1339:


[~wesmckinn], it seems that boost::filesystem::path can be used to replace 
recently introduced `PlatformFilename` struct.
I have tried to use 
[path::wstring|http://www.boost.org/doc/libs/1_53_0/libs/filesystem/doc/reference.html#wstring]
 and path::string, it seems it works fine.
I'm wondering if it was supposed here more changes than just replace 
`PlatformFilename` struct with `boost::filesystem::path`?

> [C++] Use boost::filesystem for handling of platform-specific file path 
> encodings
> -
>
> Key: ARROW-1339
> URL: https://issues.apache.org/jira/browse/ARROW-1339
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: C++
>Reporter: Wes McKinney
>Assignee: Max Risuhin
> Fix For: 0.7.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)