[jira] [Commented] (ARROW-2551) [Plasma] Improve notification logic

2018-06-06 Thread Zhijun Fu (JIRA)


[ 
https://issues.apache.org/jira/browse/ARROW-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504230#comment-16504230
 ] 

Zhijun Fu commented on ARROW-2551:
--

[~ovidiumarcu]  Sorry for the late reply. Good to know that it fixed your 
issue:)

For the order of notifications, there are two cases:

1) When a client subscribes to plasma store, the store will push notifications 
for all existing objects to the new client, in this case there's *no specific 
order* among these notifications - the store simply loop through all the 
objects from an unordered_map and push notification for each of them.

2) When a new object is sealed, a notification is pushed to all the clients 
that have subscribed for notifications. In this case, the object notifications 
are sent in the order of their *sealed* time, instead of creation time.

> [Plasma] Improve notification logic
> ---
>
> Key: ARROW-2551
> URL: https://issues.apache.org/jira/browse/ARROW-2551
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Plasma (C++)
>Reporter: Zhijun Fu
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> There are a few issues in current Plasma notification code:
>  * When a client subscribes to Plasma, the store pushes notifications about 
> existing objects to ALL subscribers, while it should only push to the new 
> subscriber.
>  * And in the above scenario, it should only push "sealed" objects to the new 
> subscriber, while currently it pushes all objects regardless of the state.
>  * When a client disconnects, it will no longer be able to receive 
> notifications, thus the NotificationQueue for the client should be removed 
> from global map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ARROW-2551) [Plasma] Improve notification logic

2018-05-17 Thread Ovidiu Marcu (JIRA)

[ 
https://issues.apache.org/jira/browse/ARROW-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478859#comment-16478859
 ] 

Ovidiu Marcu commented on ARROW-2551:
-

Thanks for #2028, it fixed a bug when the client crashed the run will crash the 
plasma store (could change issue type from improvement to bug?).

 

I am using plasma notifications and I have some issues:

1) I do not get objects in order of their creation and

2) it seems some objects are somehow lost.

> [Plasma] Improve notification logic
> ---
>
> Key: ARROW-2551
> URL: https://issues.apache.org/jira/browse/ARROW-2551
> Project: Apache Arrow
>  Issue Type: Improvement
>  Components: Plasma (C++)
>Reporter: Zhijun Fu
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> There are a few issues in current Plasma notification code:
>  * When a client subscribes to Plasma, the store pushes notifications about 
> existing objects to ALL subscribers, while it should only push to the new 
> subscriber.
>  * And in the above scenario, it should only push "sealed" objects to the new 
> subscriber, while currently it pushes all objects regardless of the state.
>  * When a client disconnects, it will no longer be able to receive 
> notifications, thus the NotificationQueue for the client should be removed 
> from global map.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)