[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540028#comment-16540028 ] Dimitri Vorona commented on ARROW-2816: --- I sent a PR with proposed changes. > [Python] Add

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539745#comment-16539745 ] Antoine Pitrou commented on ARROW-2816: --- Yes, we should be able to register NativeFile with the

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539679#comment-16539679 ] Dimitri Vorona commented on ARROW-2816: --- On a unrelated note: is it normal that I don't receive 

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539676#comment-16539676 ] Dimitri Vorona commented on ARROW-2816: --- Hi Antoine. Since RawIOBase is an ABC, couldn't we just

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539670#comment-16539670 ] Antoine Pitrou commented on ARROW-2816: --- Dimitri, hmm, you are right. It could be possible to solve

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-11 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539658#comment-16539658 ] Dimitri Vorona commented on ARROW-2816: --- Antoine, are you sure? I maybe missunderstand [the

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-10 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538866#comment-16538866 ] Antoine Pitrou commented on ARROW-2816: --- {{NativeFile}} is a Cython-defined class, it can subclass

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-10 Thread Dimitri Vorona (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538862#comment-16538862 ] Dimitri Vorona commented on ARROW-2816: --- We can't subclass Python classes in extension types, can

[jira] [Commented] (ARROW-2816) [Python] Add __iter__ method to NativeFile

2018-07-09 Thread Antoine Pitrou (JIRA)
[ https://issues.apache.org/jira/browse/ARROW-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16537594#comment-16537594 ] Antoine Pitrou commented on ARROW-2816: --- Subclassing {{RawIOBase}} is probably the right thing to