[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746337#comment-16746337
]
Pindikura Ravindra commented on ARROW-4275:
---
After the fix,
99/99 Test #128: gandiva-decimal_single_test ... Passed 143.53 sec
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746293#comment-16746293
]
Pindikura Ravindra commented on ARROW-4275:
---
gandiva has a cache of JITs to solve these kind of issues. but, there is a bug
in the cache lookup.
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744728#comment-16744728
]
Pindikura Ravindra commented on ARROW-4275:
---
> What is the "static" variant of the test supposed to do?
early on, the static variant used to give some unresolved symbol errors from
LLVM. We don't see such issues any longer - we get such errors mostly from
java/jni.
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744341#comment-16744341
]
Antoine Pitrou commented on ARROW-4275:
---
What is the "static" variant of the test supposed to do?
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744340#comment-16744340
]
Antoine Pitrou commented on ARROW-4275:
---
I think reducing the number of JIT compilations would already be a welcome
improvement.
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744337#comment-16744337
]
Pindikura Ravindra commented on ARROW-4275:
---
* I can remove the gandiva-decimal_single_test_static, since it's testing the
same code.
* The JIT is different for different precision/scale and so, we need multiple
of them. I can re-order/group the tests using the same precision/scale. Or,
cache and reuse the JIT.
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Assignee: Pindikura Ravindra
>Priority: Major
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARROW-4275) [C++] gandiva-decimal_single_test extremely slow
[
https://issues.apache.org/jira/browse/ARROW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744331#comment-16744331
]
Antoine Pitrou commented on ARROW-4275:
---
Judging by the source code, it seems the JIT compiler is launched anew for each
different test input.
cc [~Pindikura Ravindra]
> [C++] gandiva-decimal_single_test extremely slow
>
>
> Key: ARROW-4275
> URL: https://issues.apache.org/jira/browse/ARROW-4275
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++, Continuous Integration, Gandiva
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> {{gandiva-decimal_single_test}} is extremely slow on CI builds with Valgrind:
> {code}
> 99/100 Test #128: gandiva-decimal_single_test ... Passed
> 397.11 sec
> 100/100 Test #130: gandiva-decimal_single_test_static Passed
> 338.97 sec
> {code}
> (full log: https://travis-ci.org/apache/arrow/jobs/480198116#L2707)
> Something should be done to make it faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
