[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041965#comment-17041965 ] Max Burke commented on ARROW-: -- We've put together a PR for implementing this functionality: [https://github.com/apache/arrow/pull/6469] > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner, pull-request-available > Fix For: 1.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033963#comment-17033963 ] Morgan Cassels commented on ARROW-: --- [~andygrove] Has anyone had a chance to look further at this issue? String literal selection (SELECT c1 FROM test WHERE c1 = 'Hello' ) functionality would be very useful to me. If there is a plan/idea for how this should be implemented I would be happy to try working on it. > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Assignee: Kyle McCarthy >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951347#comment-16951347 ] Kyle McCarthy commented on ARROW-: -- Does this require for rust's arrow to implement a [StringType|[https://arrow.apache.org/docs/cpp/api/datatype.html#classarrow_1_1_string_type]] similar to the one in the C++ implementation? > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947432#comment-16947432 ] Andy Grove commented on ARROW-: --- I realize now that we didn't ever support this this will basically involve a different code path than how we deal with primitive types ... I have moved this out of the ARROW-5227 story and can take a look at this soon and maybe just show you some sample code if you're still interested in taking this on. > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947362#comment-16947362 ] Davis Silverman commented on ARROW-: Hah, I actually worked on this a teensy bit more, and got up to implementing `ArrowNativeType for String`, but `ArrowNativeType: Copy`, so it seems like String cannot be used. Anyways, still feel free to take this. > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947357#comment-16947357 ] Davis Silverman commented on ARROW-: Looking more into this, it seems like more difficulty than I am prepared to take on right now. It seems I would need to do a lot of plumbing to allow the Utf8 type to be allowed, so i tried to create an ArrowPrimitiveType for some Utf8Type, but there isnt any examples on how to do this for a variable-sized datatype. So maybe I wont take it after all! Sorry for wasting time here, I see this is the last task in 5227, so feel free to take it if you want. > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947343#comment-16947343 ] Andy Grove commented on ARROW-: --- Yes, exactly that ... there are a few places where we can use string literals (and we can make separate stories) ... Projection: SELECT 'hello' FROM test ... not too useful, but valid Selection: SELECT c1 FROM test WHERE c1 = 'Hello' OR c1 < 'Goodbye' Aggregate: SELECT COUNT(name), MIN(name), MAX(name) FROM test > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[
https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947336#comment-16947336
]
Davis Silverman commented on ARROW-:
Sorry, I have been a little slow on working on this. I have some questions on
what is needed exactly.
Are the expressions you are looking for like `SELECT c1 FROM test WHERE c1 =
'Hello';`{{}}
or is it something else? Which code exactly in the logical plan are you looking
to crib from? Sorry, thanks :)
> [Rust] [DataFusion] Implement string literal expression
> ---
>
> Key: ARROW-
> URL: https://issues.apache.org/jira/browse/ARROW-
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Rust, Rust - DataFusion
>Reporter: Andy Grove
>Priority: Major
> Labels: beginner
> Fix For: 1.0.0
>
>
> Implement string literal expression in the new physical query plan. It is
> already implemented in the code that executed directly from the logical plan
> so it should largely be a copy and paste exercise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945419#comment-16945419 ] Andy Grove commented on ARROW-: --- Probably best to just ask here if the questions are specific to this JIRA, or the mailing list if they are more general. > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6666) [Rust] [DataFusion] Implement string literal expression
[ https://issues.apache.org/jira/browse/ARROW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945194#comment-16945194 ] Davis Silverman commented on ARROW-: Hi, I would like to take this. Ill take a look at the logical plan stuff and ask any questions if I have any. Where is the best place to do that, just the mailing list? > [Rust] [DataFusion] Implement string literal expression > --- > > Key: ARROW- > URL: https://issues.apache.org/jira/browse/ARROW- > Project: Apache Arrow > Issue Type: Sub-task > Components: Rust, Rust - DataFusion >Reporter: Andy Grove >Priority: Major > Labels: beginner > Fix For: 1.0.0 > > > Implement string literal expression in the new physical query plan. It is > already implemented in the code that executed directly from the logical plan > so it should largely be a copy and paste exercise. -- This message was sent by Atlassian Jira (v8.3.4#803005)
