[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958490#comment-16958490 ] Neal Richardson commented on ARROW-6977: I made ARROW-6983 for the threading issue. ARROW-6979 is for the jemalloc for macOS R packages; do I remember correctly that jemalloc isn't available for Windows? As for this issue, assuming it's innocuous, it's just annoying that every time I load the package I get this message. I don't know how to suppress it though. It would be nice if we could set background_thread: true in our code based on the same condition that jemalloc is checking. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958435#comment-16958435 ] Wes McKinney commented on ARROW-6977: - The thread pool thing seems to be a new issue, can we open a JIRA for that? What do you want to do about the background thread issue? We can set decay_ms=0 by default with no background thread, but I'm not sure what the performance impact will be. Creating packages without jemalloc is not a good idea because of the performance implications. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958403#comment-16958403 ] Neal Richardson commented on ARROW-6977: I applied the patch and have run the R test suite 10 times in a row, all good. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958328#comment-16958328 ] Neal Richardson commented on ARROW-6977: Just a reminder that this is on master but I've rebuilt C++ with jemalloc off, so I'm no longer seeing that warning message. So this may be unrelated to the initial report. Feel free to move this to a different issue if you see fit. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958329#comment-16958329 ] Antoine Pitrou commented on ARROW-6977: --- Can you give this patch a try? Run with it a number of times. https://gist.github.com/pitrou/87f3091c226db3306c45b2c32dd9aea8 > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958327#comment-16958327 ] Neal Richardson commented on ARROW-6977: Re-running a bunch now, I've crashed here (to the best of my estimation): * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L43 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L44 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L45 (3x) * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L58-L59 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-Table.R#L133-L135 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-Table.R#L140 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-Table.R#L189-L192 * https://github.com/apache/arrow/blob/master/r/tests/testthat/test-Table.R#L196-L205 The common thread (excuse the pun) I *think* is that they take a Table and bring it into R as a data.frame. This function: https://github.com/apache/arrow/blob/master/r/src/array_to_vector.cpp#L811-L828 About 2 out of 3 times the test suite completes cleanly. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958318#comment-16958318 ] Neal Richardson commented on ARROW-6977: On this particular crash (after 14 assertions passed), it looks like https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L119 was the line that crashed. But like I said, it sometimes doesn't fail there, sometimes fails earlier, and sometimes fails in a different test file. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958316#comment-16958316 ] Neal Richardson commented on ARROW-6977: It doesn't always fail in the same place. Sometimes I see three test assertions pass and then it fails, which means that it errors before the next assertion. Which would put it somewhere around https://github.com/apache/arrow/blob/master/r/tests/testthat/test-csv.R#L43-L45. But other times it doesn't fail on that block and fails later. I'll try rewriting the tests to disambiguate and see if there's a pattern of where exactly it fails. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958313#comment-16958313 ] Antoine Pitrou commented on ARROW-6977: --- Yeah, but what does the test it fails in precisely do? > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958309#comment-16958309 ] Neal Richardson commented on ARROW-6977: {code} (lldb) bt all libR.dylib was compiled with optimization - stepping may behave oddly; variables may not be available. thread #1, queue = 'com.apple.main-thread' frame #0: 0x000100170660 libR.dylib`R_HashGet(hashcode=117, symbol=0x0001010689f8, table=) at envir.c:0 [opt] frame #1: 0x000100171246 libR.dylib`Rf_findFun3(symbol=0x0001010689f8, rho=0x00010583a680, call=) at envir.c:1521:11 [opt] frame #2: 0x0001001875d3 libR.dylib`bcEval(body=, rho=0x00011284c468, useCache=) at eval.c:6560:15 [opt] frame #3: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #4: 0x0001001a13a9 libR.dylib`R_execClosure(call=0x000105f48098, newrho=, sysparent=, rho=0x000112852f20, arglist=, op=) at eval.c:0:19 [opt] frame #5: 0x0001001a02aa libR.dylib`Rf_applyClosure(call=0x000105f48098, op=0x00010995f8b0, arglist=0x00011284c190, rho=0x000112852f20, suppliedvars=0x0001018058e0) at eval.c:1706:16 [opt] frame #6: 0x000100189f11 libR.dylib`bcEval(body=, rho=0x000112852f20, useCache=) at eval.c:6733:12 [opt] frame #7: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #8: 0x0001001a13a9 libR.dylib`R_execClosure(call=0x0001193dcc80, newrho=, sysparent=, rho=0x0001193eb620, arglist=, op=) at eval.c:0:19 [opt] frame #9: 0x0001001a02aa libR.dylib`Rf_applyClosure(call=0x0001193dcc80, op=0x000105f34f28, arglist=0x000112852d28, rho=0x0001193eb620, suppliedvars=0x0001018058e0) at eval.c:1706:16 [opt] frame #10: 0x00010018301d libR.dylib`Rf_eval(e=0x0001193dcc80, rho=0x0001193eb620) at eval.c:743:12 [opt] frame #11: 0x0001001a3a20 libR.dylib`do_begin(call=0x0001193da158, op=0x00010180f000, args=0x0001193dcba0, rho=) at eval.c:2382:10 [opt] frame #12: 0x000100182ce0 libR.dylib`Rf_eval(e=, rho=0x0001193eb620) at eval.c:695:12 [opt] frame #13: 0x00010019fa63 libR.dylib`forcePromise(e=0x0001129e8938) at eval.c:516:8 [opt] frame #14: 0x000100182dd0 libR.dylib`Rf_eval(e=, rho=) at eval.c:643:9 [opt] frame #15: 0x0001001a3a20 libR.dylib`do_begin(call=0x000109947450, op=0x00010180f000, args=0x0001099476b8, rho=) at eval.c:2382:10 [opt] frame #16: 0x000100182ce0 libR.dylib`Rf_eval(e=, rho=0x0001129dae78) at eval.c:695:12 [opt] frame #17: 0x0001001a4d66 libR.dylib`do_eval(call=, op=0x0001018260b0, args=, rho=) at eval.c:3186:13 [opt] frame #18: 0x00010018a326 libR.dylib`bcEval(body=, rho=0x0001129d60e8, useCache=) at eval.c:6765:14 [opt] frame #19: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #20: 0x0001001a13a9 libR.dylib`R_execClosure(call=0x00010990aa40, newrho=, sysparent=, rho=0x0001129e6f58, arglist=, op=) at eval.c:0:19 [opt] frame #21: 0x0001001a02aa libR.dylib`Rf_applyClosure(call=0x00010990aa40, op=0x0001028046d8, arglist=0x0001129d9ea8, rho=0x0001129e6f58, suppliedvars=0x0001018058e0) at eval.c:1706:16 [opt] frame #22: 0x000100189f11 libR.dylib`bcEval(body=, rho=0x0001129e6f58, useCache=) at eval.c:6733:12 [opt] frame #23: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #24: 0x00010019fa63 libR.dylib`forcePromise(e=0x0001129d9310) at eval.c:516:8 [opt] frame #25: 0x0001001aa2ec libR.dylib`getvar [inlined] FORCE_PROMISE(value=, symbol=, rho=, keepmiss=) at eval.c:4897:15 [opt] frame #26: 0x0001001aa2e4 libR.dylib`getvar(symbol=0x000101851fc8, rho=0x0001129d97e0, dd=, keepmiss=, vcache=, sidx=, stack_base=0x000100b04ff0) at eval.c:4970 [opt] frame #27: 0x000100187094 libR.dylib`bcEval(body=, rho=0x0001129d97e0, useCache=) at eval.c:6517:20 [opt] frame #28: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #29: 0x0001001a13a9 libR.dylib`R_execClosure(call=0x00010990ab20, newrho=, sysparent=, rho=0x0001129e6f58, arglist=, op=) at eval.c:0:19 [opt] frame #30: 0x0001001a02aa libR.dylib`Rf_applyClosure(call=0x00010990ab20, op=0x0001017539b8, arglist=0x0001129d9348, rho=0x0001129e6f58, suppliedvars=0x0001018058e0) at eval.c:1706:16 [opt] frame #31: 0x000100189f11 libR.dylib`bcEval(body=, rho=0x0001129e6f58, useCache=) at eval.c:6733:12 [opt] frame #32: 0x000100182aed libR.dylib`Rf_eval(e=, rho=) at eval.c:620:8 [opt] frame #33: 0x00010019fa63 libR.dylib`forcePromise(e=0x0001129daee8) at eval.c:516:8 [opt] frame #34: 0x0001001aa2ec
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958305#comment-16958305 ] Neal Richardson commented on ARROW-6977: It most often fails in the CSV reader, which itself has multithreading (recently revised?) and when the data is pulled from Arrow into and R data.frame, it also uses threads. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958304#comment-16958304 ] Antoine Pitrou commented on ARROW-6977: --- Also, it would be nice if you could give a bit of context? (why is the test doing? can you run them in verbose mode to see where it's crashing?) > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958302#comment-16958302 ] Antoine Pitrou commented on ARROW-6977: --- Could you post the backtrace for all threads? Something like "thread apply all bt" should do. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958299#comment-16958299 ] Neal Richardson commented on ARROW-6977: With lldb: {code} Assertion failed: (ec == 0), function unlock, file /BuildRoot/Library/Caches/com.apple.xbs/Sources/libcxx/libcxx-400.9.4/src/mutex.cpp, line 48. Process 36128 stopped * thread #10, stop reason = signal SIGABRT frame #0: 0x7fff729182c6 libsystem_kernel.dylib`__pthread_kill + 10 libsystem_kernel.dylib`__pthread_kill: -> 0x7fff729182c6 <+10>: jae0x7fff729182d0; <+20> 0x7fff729182c8 <+12>: movq %rax, %rdi 0x7fff729182cb <+15>: jmp0x7fff72912457; cerror_nocancel 0x7fff729182d0 <+20>: retq Target 0: (R) stopped. (lldb) bt * thread #10, stop reason = signal SIGABRT * frame #0: 0x7fff729182c6 libsystem_kernel.dylib`__pthread_kill + 10 frame #1: 0x7fff729cdbf1 libsystem_pthread.dylib`pthread_kill + 284 frame #2: 0x7fff728826a6 libsystem_c.dylib`abort + 127 frame #3: 0x7fff7284b20d libsystem_c.dylib`__assert_rtn + 324 frame #4: 0x7fff6f7e79a4 libc++.1.dylib`std::__1::mutex::unlock() + 46 frame #5: 0x00010a8d991a libarrow.100.dylib`std::__1::unique_lock::~unique_lock(this=0x7935db70) at __mutex_base:153:19 frame #6: 0x00010a8d9715 libarrow.100.dylib`std::__1::unique_lock::~unique_lock(this=0x7935db70) at __mutex_base:151:5 frame #7: 0x00010a8d96c1 libarrow.100.dylib`arrow::internal::ThreadedTaskGroup::OneTaskDone(this=0x000102373b00) at task_group.cc:152:5 frame #8: 0x00010a8dbe5f libarrow.100.dylib`arrow::internal::ThreadedTaskGroup::AppendReal(this=0x00010232cfe0)>)::'lambda'()::operator()() const at task_group.cc:97:9 frame #9: 0x00010a8dbd9d libarrow.100.dylib`decltype(__f=0x00010232cfe0)>)::'lambda'()&>(fp)()) std::__1::__invoke)::'lambda'()&>(arrow::internal::ThreadedTaskGroup::AppendReal(std::__1::function)::'lambda'()&) at type_traits:4361:1 frame #10: 0x00010a8dbd4d libarrow.100.dylib`void std::__1::__invoke_void_return_wrapper::__call)::'lambda'()&>(arrow::internal::ThreadedTaskGroup::AppendReal(std::__1::function)::'lambda'()&) at __functional_base:349:9 frame #11: 0x00010a8dbd1d libarrow.100.dylib`std::__1::__function::__alloc_func)::'lambda'(), std::__1::allocator)::'lambda'()>, void ()>::operator(this=0x00010232cfe0)() at functional:1527:16 frame #12: 0x00010a8daa59 libarrow.100.dylib`std::__1::__function::__func)::'lambda'(), std::__1::allocator)::'lambda'()>, void ()>::operator(this=0x00010232cfd0)() at functional:1651:12 frame #13: 0x00010a8e5185 libarrow.100.dylib`std::__1::__function::__value_func::operator(this=0x7935ddf0)() const at functional:1799:16 frame #14: 0x00010a8e4d35 libarrow.100.dylib`std::__1::function::operator(this=0x7935ddf0)() const at functional:2347:12 frame #15: 0x00010a8e46fa libarrow.100.dylib`arrow::internal::WorkerLoop(state=std::__1::shared_ptr::element_type @ 0x00010092e548 strong=17 weak=1, it=std::__1::list >::iterator @ 0x7935dde8) at thread_pool.cc:88:9 frame #16: 0x00010a8e4451 libarrow.100.dylib`arrow::internal::ThreadPool::LaunchWorkersUnlocked(this=0x000100a1cde8)::$_1::operator()() const at thread_pool.cc:225:37 frame #17: 0x00010a8e43cd libarrow.100.dylib`decltype(__f=0x000100a1cde8)::$_1>(fp)()) std::__1::__invoke(arrow::internal::ThreadPool::LaunchWorkersUnlocked(int)::$_1&&) at type_traits:4361:1 frame #18: 0x00010a8e4335 libarrow.100.dylib`void std::__1::__thread_execute >, arrow::internal::ThreadPool::LaunchWorkersUnlocked(int)::$_1>(__t=size=2, (null)=__tuple_indices<> @ 0x7935deb8)::$_1>&, std::__1::__tuple_indices<>) at thread:342:5 frame #19: 0x00010a8e3b16 libarrow.100.dylib`void* std::__1::__thread_proxy >, arrow::internal::ThreadPool::LaunchWorkersUnlocked(int)::$_1> >(__vp=0x000100a1cde0) at thread:352:5 frame #20: 0x7fff729cb2eb libsystem_pthread.dylib`_pthread_body + 126 frame #21: 0x7fff729ce249 libsystem_pthread.dylib`_pthread_start + 66 frame #22: 0x7fff729ca40d libsystem_pthread.dylib`thread_start + 13 {code} > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > :
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958295#comment-16958295 ] Antoine Pitrou commented on ARROW-6977: --- You can try running the executable using "gdb --args". Another solution is to enable core dumps (perhaps "ulimit -c unlimited") and then run gdb on the core dump, like this: "gdb executable_file core_file". Once under the gdb, use "run" to run the application and then "bt" to get a backtrace. If debugging a core dump, you only need "bt". > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958294#comment-16958294 ] Neal Richardson commented on ARROW-6977: Update: I wiped my build dir and rebuilt with {{-DARROW_JEMALLOC=OFF}}. I no longer get the warning message, but I'm still able to trigger this abort. So it seems there's something new in master that triggers this, but it may not be jemalloc background thread. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958290#comment-16958290 ] Neal Richardson commented on ARROW-6977: With some handholding, I'm sure I could. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958288#comment-16958288 ] Antoine Pitrou commented on ARROW-6977: --- [~npr] can you produce a gdb backtrace for that error? > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958287#comment-16958287 ] Antoine Pitrou commented on ARROW-6977: --- The error message is misleading, it's about missing another system call. Unless we can find a reliable version check, disabling the background thread on macOS may be the safest course of action. [~uwe] > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958253#comment-16958253 ] Wes McKinney commented on ARROW-6977: - Not having pthread seems a bit weird to me, I'm not sure what that is all about? > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958219#comment-16958219 ] Neal Richardson commented on ARROW-6977: That said, I am experiencing this error occasionally today while running the R test suite locally. This is on master: {code} ... CsvTableReader: ..Assertion failed: (ec == 0), function unlock, file /BuildRoot/Library/Caches/com.apple.xbs/Sources/libcxx/libcxx-400.9.4/src/mutex.cpp, line 48. /bin/sh: line 1: 59468 Abort trap: 6 R --slave -e 'library(testthat); setwd(file.path(.libPaths()[1], "arrow", "tests")); system.time(test_check("arrow", filter="", reporter=ifelse(nchar(""), "", "summary")))' make: *** [test] Error 134 {code} > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958216#comment-16958216 ] Antoine Pitrou commented on ARROW-6977: --- Ah... can you run the tests fine? Also the C++ tests. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958215#comment-16958215 ] Neal Richardson commented on ARROW-6977: It's just a message, it doesn't appear to error, at least not immediately. > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0, 0.15.1 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958214#comment-16958214 ] Antoine Pitrou commented on ARROW-6977: --- I wonder why this didn't come up on CI. Is macOS younger on Travis? [~kszucs] > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958212#comment-16958212 ] Neal Richardson commented on ARROW-6977: I'm not sure, but it sounds like the kind of thing we'll hear bug reports about if we don't. For the CRAN R packages, it's not an issue because the macOS and Windows binaries are built with jemalloc disabled: * https://github.com/apache/arrow/blob/59a6788c76330cf055bdbcbc7bdae7b0106c6656/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb#L47 * https://github.com/apache/arrow/blob/59a6788c76330cf055bdbcbc7bdae7b0106c6656/ci/PKGBUILD#L85 > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6977) [C++] Only enable jemalloc background_thread if feature is supported
[ https://issues.apache.org/jira/browse/ARROW-6977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958205#comment-16958205 ] Antoine Pitrou commented on ARROW-6977: --- This sounds critical to get in for 0.15.1, right? > [C++] Only enable jemalloc background_thread if feature is supported > > > Key: ARROW-6977 > URL: https://issues.apache.org/jira/browse/ARROW-6977 > Project: Apache Arrow > Issue Type: Bug > Components: C++ > Environment: macOS 10.14, Homebrew >Reporter: Neal Richardson >Priority: Major > Fix For: 1.0.0 > > > Followup to ARROW-6910. When loading the R package after that patch merged, I > get this new message: > {code} > $ R > > library(arrow) > : option background_thread currently supports pthread only > {code} > https://github.com/jemalloc/jemalloc/blob/3d84bd57f4954a17059bd31330ec87d3c1876411/src/background_thread.c#L884-L887 > is where the message comes from. Tracing that further, > {{have_background_thread}} comes from > https://github.com/jemalloc/jemalloc/blob/21cfe59ff7b10a61dabe26cd3dbfb7a255e1f5e8/include/jemalloc/internal/jemalloc_preamble.h.in#L205-L211, > which gets set in {{configure.ac}} here: > https://github.com/jemalloc/jemalloc/blob/d2dddfb82aac9f2212922eb90324e84790704bfe/configure.ac#L2155-L2157 > In sum, on my system, that flag doesn't get set, so > {{have_background_thread}} is false, and when that is false and the > {{background_thread}} option is true, I get that message printed. And I do > not want to see that message. > cc [~wesm] -- This message was sent by Atlassian Jira (v8.3.4#803005)