[jira] [Commented] (ARROW-859) [C++] Do not build unit tests by default?
[ https://issues.apache.org/jira/browse/ARROW-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976596#comment-15976596 ] Wes McKinney commented on ARROW-859: The motivation was simplifying the build for thirdparties somewhat, see e.g. https://github.com/search?utf8=%E2%9C%93&q=-DARROW_BUILD_TESTS%3Doff&type=Code I don't feel super strongly, so I'm OK with leaving things as they are > [C++] Do not build unit tests by default? > - > > Key: ARROW-859 > URL: https://issues.apache.org/jira/browse/ARROW-859 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Wes McKinney > Fix For: 0.3.0 > > > This is strictly a subjective call -- since more people are using Arrow as a > thirdparty library, it might be preferably to only opt-in to running the unit > tests (vs. currently: explicitly opting out) for Arrow development. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARROW-859) [C++] Do not build unit tests by default?
[ https://issues.apache.org/jira/browse/ARROW-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976250#comment-15976250 ] Uwe L. Korn commented on ARROW-859: --- I'm a bit undecided on this. While compiling unit tests by default makes it easier for potential contributors to spot errors in their contribution, it costs unnecessary compilation time if you only consume arrow. [~wesmckinn] What was the motivation for this change? (I probably saw it but can't remember it anymore) > [C++] Do not build unit tests by default? > - > > Key: ARROW-859 > URL: https://issues.apache.org/jira/browse/ARROW-859 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Wes McKinney > Fix For: 0.3.0 > > > This is strictly a subjective call -- since more people are using Arrow as a > thirdparty library, it might be preferably to only opt-in to running the unit > tests (vs. currently: explicitly opting out) for Arrow development. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARROW-859) [C++] Do not build unit tests by default?
[ https://issues.apache.org/jira/browse/ARROW-859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975808#comment-15975808 ] Wes McKinney commented on ARROW-859: PR: https://github.com/apache/arrow/pull/570 > [C++] Do not build unit tests by default? > - > > Key: ARROW-859 > URL: https://issues.apache.org/jira/browse/ARROW-859 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Wes McKinney >Assignee: Wes McKinney > Fix For: 0.3.0 > > > This is strictly a subjective call -- since more people are using Arrow as a > thirdparty library, it might be preferably to only opt-in to running the unit > tests (vs. currently: explicitly opting out) for Arrow development. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
