[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17131175#comment-17131175 ] Beam JIRA Bot commented on BEAM-8572: - This issue was marked "stale-assigned" and has not received a public comment in 7 days. It is now automatically unassigned. If you are still working on it, you can assign it to yourself again. Please also give an update about the status of the work. > tox environment: assert on Cython source file presence > -- > > Key: BEAM-8572 > URL: https://issues.apache.org/jira/browse/BEAM-8572 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, testing >Reporter: Udi Meiri >Priority: P2 > > Add an assertion somewhere that checks if Cythonized files are present in the > sdist tarball in use. That is for "tox -e py27" assert that these files are > not present, for "tox -e py27-cython" assert that they are present. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17121820#comment-17121820 ] Kenneth Knowles commented on BEAM-8572: --- This issue is assigned but has not received an update in 30 days so it has been labeled "stale-assigned". If you are still working on the issue, please give an update and remove the label. If you are no longer working on the issue, please unassign so someone else may work on it. In 7 days the issue will be automatically unassigned. > tox environment: assert on Cython source file presence > -- > > Key: BEAM-8572 > URL: https://issues.apache.org/jira/browse/BEAM-8572 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, testing >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: P2 > Labels: stale-assigned > > Add an assertion somewhere that checks if Cythonized files are present in the > sdist tarball in use. That is for "tox -e py27" assert that these files are > not present, for "tox -e py27-cython" assert that they are present. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993794#comment-16993794 ] Udi Meiri commented on BEAM-8572: - Fix is in https://github.com/apache/beam/pull/10038 > tox environment: assert on Cython source file presence > -- > > Key: BEAM-8572 > URL: https://issues.apache.org/jira/browse/BEAM-8572 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, testing >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > Add an assertion somewhere that checks if Cythonized files are present in the > sdist tarball in use. That is for "tox -e py27" assert that these files are > not present, for "tox -e py27-cython" assert that they are present. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993127#comment-16993127 ] Udi Meiri commented on BEAM-8572: - We discussed this a while back on the mailing list, and the consensus IIRC was that Cython was being correctly installed, except that these tests weren't detecting it correctly. I've tracked it down to how utils.check_compiled() is used. It was pointed to a module that doesn't get cythonized (is always from a .py or .pyc file). https://github.com/apache/beam/pull/7606/files > tox environment: assert on Cython source file presence > -- > > Key: BEAM-8572 > URL: https://issues.apache.org/jira/browse/BEAM-8572 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, testing >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > Add an assertion somewhere that checks if Cythonized files are present in the > sdist tarball in use. That is for "tox -e py27" assert that these files are > not present, for "tox -e py27-cython" assert that they are present. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[
https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968716#comment-16968716
]
Udi Meiri commented on BEAM-8572:
-
Ideas:
1a. Migrate precommit unit testing to pytest, mark Cython requiring tests as
such (pytest.mark.cython), and only run them when
1b. Same migration, but add a flag to conftest.py that makes it verify that
cythonize has been run. (utils.check_compiled('apache_beam.coders')?)
> tox environment: assert on Cython source file presence
> --
>
> Key: BEAM-8572
> URL: https://issues.apache.org/jira/browse/BEAM-8572
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
>Reporter: Udi Meiri
>Assignee: Udi Meiri
>Priority: Major
>
> Add an assertion somewhere that checks if Cythonized files are present in the
> sdist tarball in use. That is for "tox -e py27" assert that these files are
> not present, for "tox -e py27-cython" assert that they are present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[
https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968713#comment-16968713
]
Udi Meiri commented on BEAM-8572:
-
Looks like some Cython-requiring tests are always skipped.
{code}
$ curl -s
https://builds.apache.org/job/beam_PreCommit_Python_Phrase/900/consoleText |
grep fast_coders_test.FastCoders consoleText
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
test_using_fast_impl (apache_beam.coders.fast_coders_test.FastCoders) ... SKIP:
Cython is not installed
{code}
> tox environment: assert on Cython source file presence
> --
>
> Key: BEAM-8572
> URL: https://issues.apache.org/jira/browse/BEAM-8572
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
>Reporter: Udi Meiri
>Assignee: Udi Meiri
>Priority: Major
>
> Add an assertion somewhere that checks if Cythonized files are present in the
> sdist tarball in use. That is for "tox -e py27" assert that these files are
> not present, for "tox -e py27-cython" assert that they are present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (BEAM-8572) tox environment: assert on Cython source file presence
[ https://issues.apache.org/jira/browse/BEAM-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968603#comment-16968603 ] Udi Meiri commented on BEAM-8572: - Assigned to myself, but feel free to take this if you wish. > tox environment: assert on Cython source file presence > -- > > Key: BEAM-8572 > URL: https://issues.apache.org/jira/browse/BEAM-8572 > Project: Beam > Issue Type: Bug > Components: sdk-py-core, testing >Reporter: Udi Meiri >Assignee: Udi Meiri >Priority: Major > > Add an assertion somewhere that checks if Cythonized files are present in the > sdist tarball in use. That is for "tox -e py27" assert that these files are > not present, for "tox -e py27-cython" assert that they are present. -- This message was sent by Atlassian Jira (v8.3.4#803005)
