[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-24 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=318085=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318085
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 25/Sep/19 05:12
Start Date: 25/Sep/19 05:12
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on pull request #9578: 
[BEAM-3372] remove duplicated zone
URL: https://github.com/apache/beam/pull/9578
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 318085)
Time Spent: 1.5h  (was: 1h 20m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-24 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=317799=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317799
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 24/Sep/19 20:03
Start Date: 24/Sep/19 20:03
Worklog Time Spent: 10m 
  Work Description: robertwb commented on issue #9578: [BEAM-3372] remove 
duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-534724952
 
 
   Good to merge?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 317799)
Time Spent: 1h 20m  (was: 1h 10m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=315352=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315352
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 19/Sep/19 23:11
Start Date: 19/Sep/19 23:11
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #9578: [BEAM-3372] 
remove duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-533342279
 
 
   run dataflow validatesrunner
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 315352)
Time Spent: 1h 10m  (was: 1h)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=315351=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315351
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 19/Sep/19 23:11
Start Date: 19/Sep/19 23:11
Worklog Time Spent: 10m 
  Work Description: kennknowles commented on issue #9578: [BEAM-3372] 
remove duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-533342250
 
 
   Looks good! Just for safety, I will run a big test suite.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 315351)
Time Spent: 1h  (was: 50m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=314817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314817
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 19/Sep/19 04:52
Start Date: 19/Sep/19 04:52
Worklog Time Spent: 10m 
  Work Description: DAAC commented on issue #9578: [BEAM-3372] remove 
duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-532965129
 
 
   r: @kennknowles
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 314817)
Time Spent: 50m  (was: 40m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-18 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=314800=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314800
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 19/Sep/19 03:40
Start Date: 19/Sep/19 03:40
Worklog Time Spent: 10m 
  Work Description: DAAC commented on issue #9578: [BEAM-3372] remove 
duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-532952007
 
 
   I checked GcpOptions extends PipelineOptions same as 
DataflowPipelineWorkerPoolOptions so I will changes that extends 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 314800)
Time Spent: 40m  (was: 0.5h)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=312711=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312711
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 15/Sep/19 21:03
Start Date: 15/Sep/19 21:03
Worklog Time Spent: 10m 
  Work Description: pabloem commented on issue #9578: [BEAM-3372] remove 
duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-531599161
 
 
   r: @kennknowles 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 312711)
Time Spent: 0.5h  (was: 20m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=312709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312709
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 15/Sep/19 20:40
Start Date: 15/Sep/19 20:40
Worklog Time Spent: 10m 
  Work Description: DAAC commented on issue #9578: [BEAM-3372] remove 
duplicated zone
URL: https://github.com/apache/beam/pull/9578#issuecomment-531597501
 
 
   r: @pabloem
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 312709)
Time Spent: 20m  (was: 10m)

> Duplicated 'zone' PipelineOption has inconsistent documentation
> ---
>
> Key: BEAM-3372
> URL: https://issues.apache.org/jira/browse/BEAM-3372
> Project: Beam
>  Issue Type: Bug
>  Components: io-java-gcp, runner-dataflow
>Reporter: Scott Wegner
>Priority: Minor
>  Labels: ccoss2019, newbie, starter, test
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Two different PipelineOptions interfaces defined a 'zone' option: GcpOptions 
> [1] and DataflowWorkerPoolOptions [2]. It's not an error for an option to be 
> redefined, and internally Beam checks that the definitions are compatible.
> In this case the two 'zone' definitions are compatible but they have 
> different descriptions. This can be confusing as setting one will also impact 
> the other.
> We should make improvements around duplicate PipelineOptions definitions for 
> a given runner. In this case, I propose we:
> a) Update the @Description's so that they match.
> b) Mark one of them as @Deprecated with a link to the other. Migrate code 
> references and plan to remove it on the next major version.
> c) Add a test which checks all PipelineOptions on the DataflowRunner 
> classpath and verify that any duplicates have the properties above 
> (equivalent definitions including @Description, and only one non-@Deprecated 
> version)
> [1] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcpOptions.java#L95
> [2] 
> https://github.com/apache/beam/blob/670941961845593d9a7e09b17c1bd117f27bf579/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java#L175



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Work logged] (BEAM-3372) Duplicated 'zone' PipelineOption has inconsistent documentation

2019-09-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/BEAM-3372?focusedWorklogId=312708=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312708
 ]

ASF GitHub Bot logged work on BEAM-3372:


Author: ASF GitHub Bot
Created on: 15/Sep/19 20:39
Start Date: 15/Sep/19 20:39
Worklog Time Spent: 10m 
  Work Description: DAAC commented on pull request #9578: [BEAM-3372] 
remove duplicated zone
URL: https://github.com/apache/beam/pull/9578
 
 
   **Please** add a meaningful description for your change here
   
   
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
- [ ] [**Choose 
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and 
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue, if applicable. This will automatically link the pull request to the 
issue.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   Post-Commit Tests Status (on master branch)
   

   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
 | --- | --- | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
 | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)
   Python | [![Build 
Status](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[![Build
 
Status](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[![Build