[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=325893=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325893 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 09/Oct/19 19:49 Start Date: 09/Oct/19 19:49 Worklog Time Spent: 10m Work Description: lukecwik commented on issue #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337#issuecomment-540161257 I think we used System.out.println so that users who have incorrect logging configuration would still get some output when they submit a job. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 325893) Time Spent: 1h (was: 50m) > DataflowRunner writes to System.out instead of logging > -- > > Key: BEAM-7977 > URL: https://issues.apache.org/jira/browse/BEAM-7977 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Sebastian Jambor >Assignee: Sebastian Jambor >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > DataflowRunner writes two lines to stdout for every job, which bypasses the > logger setup. This is slightly annoying, especially if many jobs are started > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=323622=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323622 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 04/Oct/19 17:50 Start Date: 04/Oct/19 17:50 Worklog Time Spent: 10m Work Description: pabloem commented on issue #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337#issuecomment-538497321 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323622) Time Spent: 40m (was: 0.5h) > DataflowRunner writes to System.out instead of logging > -- > > Key: BEAM-7977 > URL: https://issues.apache.org/jira/browse/BEAM-7977 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Sebastian Jambor >Assignee: Sebastian Jambor >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > DataflowRunner writes two lines to stdout for every job, which bypasses the > logger setup. This is slightly annoying, especially if many jobs are started > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=323623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323623 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 04/Oct/19 17:50 Start Date: 04/Oct/19 17:50 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 323623) Time Spent: 50m (was: 40m) > DataflowRunner writes to System.out instead of logging > -- > > Key: BEAM-7977 > URL: https://issues.apache.org/jira/browse/BEAM-7977 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Sebastian Jambor >Assignee: Sebastian Jambor >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > DataflowRunner writes two lines to stdout for every job, which bypasses the > logger setup. This is slightly annoying, especially if many jobs are started > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=294693=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294693 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 14/Aug/19 11:16 Start Date: 14/Aug/19 11:16 Worklog Time Spent: 10m Work Description: sgrj commented on issue #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337#issuecomment-521204748 R: pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294693) Time Spent: 0.5h (was: 20m) > DataflowRunner writes to System.out instead of logging > -- > > Key: BEAM-7977 > URL: https://issues.apache.org/jira/browse/BEAM-7977 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Sebastian Jambor >Assignee: Sebastian Jambor >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > DataflowRunner writes two lines to stdout for every job, which bypasses the > logger setup. This is slightly annoying, especially if many jobs are started > programmatically. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=294692=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294692 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 14/Aug/19 11:16 Start Date: 14/Aug/19 11:16 Worklog Time Spent: 10m Work Description: sgrj commented on issue #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337#issuecomment-521204710 I did a quick grep for other instances of System.out and System.err. They all seem to be in tests, examples, or command line apps, which seem like valid usages. The only other instance that might be changed is https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L700; but since that seems to be used for debugging only, writing to stdout seems to be ok here as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294692) Time Spent: 20m (was: 10m) > DataflowRunner writes to System.out instead of logging > -- > > Key: BEAM-7977 > URL: https://issues.apache.org/jira/browse/BEAM-7977 > Project: Beam > Issue Type: Bug > Components: runner-dataflow >Reporter: Sebastian Jambor >Assignee: Sebastian Jambor >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > DataflowRunner writes two lines to stdout for every job, which bypasses the > logger setup. This is slightly annoying, especially if many jobs are started > programmatically. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (BEAM-7977) DataflowRunner writes to System.out instead of logging
[ https://issues.apache.org/jira/browse/BEAM-7977?focusedWorklogId=294689=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294689 ] ASF GitHub Bot logged work on BEAM-7977: Author: ASF GitHub Bot Created on: 14/Aug/19 11:13 Start Date: 14/Aug/19 11:13 Worklog Time Spent: 10m Work Description: sgrj commented on pull request #9337: [BEAM-7977] use LOG.info instead of System.out.println in DataflowRunner URL: https://github.com/apache/beam/pull/9337 DataflowRunner writes two lines to stdout, bypassing the regular logger. This diff aligns this by logging info statements instead. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)[