[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389845=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389845 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 20/Feb/20 08:45 Start Date: 20/Feb/20 08:45 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588774280 Looks fine to update! The 1.13.0 essentially added two new enums to the types.Feature, but since these are specified by the user, all should be well. I also manually reran all the tests on version 1.13.0 without mocking the videointelligence client and they ran as expected. Cheers! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389845) Time Spent: 14h (was: 13h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 14h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389843=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389843 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 20/Feb/20 08:40 Start Date: 20/Feb/20 08:40 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588774280 Looks fine to update! The 1.13.0 essentially added two new enums to the types.Feature, but since these are specified by the user, all should be well. I also manually reran all the tests without mocking the videointelligence client and they ran as expected. Cheers! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389843) Time Spent: 13h 50m (was: 13h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389491=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389491 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 16:38 Start Date: 19/Feb/20 16:38 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588315698 @EDjur -- Thank you, merged this. Could we update 'google-cloud-videointelligence>=1.8.0<=1.12.1', to use the recently released 1.13.0 version as well? Do we need anything special? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389491) Time Spent: 13h 40m (was: 13.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389490 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 16:36 Start Date: 19/Feb/20 16:36 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389490) Time Spent: 13.5h (was: 13h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389418 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 12:36 Start Date: 19/Feb/20 12:36 Worklog Time Spent: 10m Work Description: kkucharc commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588193406 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389418) Time Spent: 13h 10m (was: 13h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389419 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 12:36 Start Date: 19/Feb/20 12:36 Worklog Time Spent: 10m Work Description: kkucharc commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588193611 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389419) Time Spent: 13h 20m (was: 13h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389417 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 12:35 Start Date: 19/Feb/20 12:35 Worklog Time Spent: 10m Work Description: kkucharc commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588203696 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389417) Time Spent: 13h (was: 12h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 13h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389411 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 12:13 Start Date: 19/Feb/20 12:13 Worklog Time Spent: 10m Work Description: kkucharc commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588193611 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389411) Time Spent: 12h 50m (was: 12h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389410=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389410 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 12:12 Start Date: 19/Feb/20 12:12 Worklog Time Spent: 10m Work Description: kkucharc commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588193406 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389410) Time Spent: 12h 40m (was: 12.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389395=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389395 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 19/Feb/20 11:27 Start Date: 19/Feb/20 11:27 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-588173559 Seems yapf doesn't format docstrings 路♂ Should be fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389395) Time Spent: 12.5h (was: 12h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389100 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 18/Feb/20 21:17 Start Date: 18/Feb/20 21:17 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-587865079 :sdks:python:test-suites:tox:pycommon:docs task is failing -- There might be pydocs issues in the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389100) Time Spent: 12h 20m (was: 12h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389023=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389023 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 18/Feb/20 19:30 Start Date: 18/Feb/20 19:30 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-587709629 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389023) Time Spent: 12h 10m (was: 12h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=389022=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-389022 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 18/Feb/20 19:28 Start Date: 18/Feb/20 19:28 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-587706660 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 389022) Time Spent: 12h (was: 11h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 12h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=388914=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388914 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 18/Feb/20 16:54 Start Date: 18/Feb/20 16:54 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-587562526 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 388914) Time Spent: 11h 50m (was: 11h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=388895=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-388895 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 18/Feb/20 16:42 Start Date: 18/Feb/20 16:42 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-587555706 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 388895) Time Spent: 11h 40m (was: 11.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=387501=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387501 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 14/Feb/20 17:34 Start Date: 14/Feb/20 17:34 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-586390187 Test error seems to be related to: https://github.com/apache/beam/pull/10856/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387501) Time Spent: 11.5h (was: 11h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=387263=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387263 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 14/Feb/20 10:13 Start Date: 14/Feb/20 10:13 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-586193093 Thanks for retesting! Test failures look unrelated to this PR. ``` 11:04:57 self = 11:04:57 watermark = 0, processing_time = 1 11:04:57 11:04:57 def advance_watermark(self, watermark, processing_time): 11:04:57 record = TestStreamFileRecord( 11:04:57 watermark=Timestamp.of(watermark).to_proto(), 11:04:57 > processing_time=Timestamp.of(processing_time).to_proto()) 11:04:57 E ValueError: Protocol message TestStreamFileRecord has no "processing_time" field. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387263) Time Spent: 11h 20m (was: 11h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=387262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387262 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 14/Feb/20 10:13 Start Date: 14/Feb/20 10:13 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-586193093 Test failures look unrelated to this PR. ``` 11:04:57 self = 11:04:57 watermark = 0, processing_time = 1 11:04:57 11:04:57 def advance_watermark(self, watermark, processing_time): 11:04:57 record = TestStreamFileRecord( 11:04:57 watermark=Timestamp.of(watermark).to_proto(), 11:04:57 > processing_time=Timestamp.of(processing_time).to_proto()) 11:04:57 E ValueError: Protocol message TestStreamFileRecord has no "processing_time" field. ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387262) Time Spent: 11h 10m (was: 11h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=387242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387242 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 14/Feb/20 09:36 Start Date: 14/Feb/20 09:36 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-586178567 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387242) Time Spent: 11h (was: 10h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 11h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386614=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386614 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 13:19 Start Date: 13/Feb/20 13:19 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585750091 I'm having a small discussion regarding the `video_context` with @kamilwu here: https://issues.apache.org/jira/browse/BEAM-9247 Perhaps this is something we should look at integrating to this PR before (or after considering the use-case seems small) merging too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386614) Time Spent: 10h 50m (was: 10h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386556=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386556 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 11:21 Start Date: 13/Feb/20 11:21 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585678000 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386556) Time Spent: 10h 40m (was: 10.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386533=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386533 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:37 Start Date: 13/Feb/20 10:37 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585648977 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386533) Time Spent: 10h 10m (was: 10h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386535=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386535 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:37 Start Date: 13/Feb/20 10:37 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585431841 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386535) Time Spent: 10.5h (was: 10h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386532=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386532 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:37 Start Date: 13/Feb/20 10:37 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585661147 > @EDjur your phrase triggers unfortunately won't trigger the tests - there are Jenkins restrictions that won't let you do it Gotcha. Thanks for triggering them! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386532) Time Spent: 10h (was: 9h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386534 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:37 Start Date: 13/Feb/20 10:37 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585603649 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386534) Time Spent: 10h 20m (was: 10h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 10h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386529=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386529 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:33 Start Date: 13/Feb/20 10:33 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585659326 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386529) Time Spent: 9h 40m (was: 9.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386530=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386530 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:33 Start Date: 13/Feb/20 10:33 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585659566 @EDjur your phrase triggers unfortunately won't trigger the tests - there are Jenkins restrictions that won't let you do it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386530) Time Spent: 9h 50m (was: 9h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386507=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386507 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 10:07 Start Date: 13/Feb/20 10:07 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585648977 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386507) Time Spent: 9.5h (was: 9h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386441 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 08:16 Start Date: 13/Feb/20 08:16 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585603857 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386441) Time Spent: 9h 20m (was: 9h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386440=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386440 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 08:15 Start Date: 13/Feb/20 08:15 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585605111 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386440) Time Spent: 9h 10m (was: 9h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386437=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386437 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 08:12 Start Date: 13/Feb/20 08:12 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585603857 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386437) Time Spent: 9h (was: 8h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 9h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386436=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386436 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 08:11 Start Date: 13/Feb/20 08:11 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585603649 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386436) Time Spent: 8h 50m (was: 8h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386435=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386435 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 08:11 Start Date: 13/Feb/20 08:11 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585603580 I cannot seem to make the tests fail locally so this is proving to be quite a struggle But hopefully this should fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386435) Time Spent: 8h 40m (was: 8.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386412=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386412 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 13/Feb/20 07:06 Start Date: 13/Feb/20 07:06 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585583201 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386412) Time Spent: 8.5h (was: 8h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386258 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:54 Start Date: 12/Feb/20 21:54 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585437008 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386258) Time Spent: 8h 20m (was: 8h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386247 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:41 Start Date: 12/Feb/20 21:41 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585431841 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386247) Time Spent: 8h 10m (was: 8h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386245 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:36 Start Date: 12/Feb/20 21:36 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585429958 > Some minor lint issues should be fixed with that last commit. But it seemed Jenkins was failing on something else: `ModuleNotFoundError: No module named 'pycodestyle'` when running the tests. Not sure if that is related to this PR. This is fixed in (https://github.com/apache/beam/pull/10844). You may need to rebase. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386245) Time Spent: 8h (was: 7h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 8h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386242=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386242 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:16 Start Date: 12/Feb/20 21:16 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585421104 Some minor lint issues should be fixed with that last commit. But it seemed Jenkins was failing on something else: `ModuleNotFoundError: No module named 'pycodestyle'` when running the tests. Not sure if that is related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386242) Time Spent: 7h 50m (was: 7h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386240=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386240 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:15 Start Date: 12/Feb/20 21:15 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585421104 Some minor lint issues should be fixed with that last commit. But it seemed Jenkins was failing on something else: `failed to import pycodestyle` when running the tests. Not sure that is related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386240) Time Spent: 7.5h (was: 7h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386241=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386241 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:15 Start Date: 12/Feb/20 21:15 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585421104 Some minor lint issues should be fixed with that last commit. But it seemed Jenkins was failing on something else: `failed to import pycodestyle` when running the tests. Not sure if that is related to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386241) Time Spent: 7h 40m (was: 7.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386239=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386239 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 21:14 Start Date: 12/Feb/20 21:14 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585420761 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386239) Time Spent: 7h 20m (was: 7h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386103=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386103 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 18:02 Start Date: 12/Feb/20 18:02 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585337024 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386103) Time Spent: 7h (was: 6h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=386104=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386104 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 18:02 Start Date: 12/Feb/20 18:02 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585337160 Finally, tests are running. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386104) Time Spent: 7h 10m (was: 7h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 7h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385839 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 12:01 Start Date: 12/Feb/20 12:01 Worklog Time Spent: 10m Work Description: mwalenia commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-585173351 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385839) Time Spent: 6h 50m (was: 6h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385624=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385624 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 02:11 Start Date: 12/Feb/20 02:11 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584983018 @EDjur - This LGTM. I would like to merge it but I cannot seem to trigger the tests @markflyhigh is there a manual way to run the tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385624) Time Spent: 6h 40m (was: 6.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385623 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 12/Feb/20 02:10 Start Date: 12/Feb/20 02:10 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584982808 tests, will you trigger? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385623) Time Spent: 6.5h (was: 6h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385332 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 11/Feb/20 18:16 Start Date: 11/Feb/20 18:16 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584776671 /cc @markflyhigh - Tests seems to be not triggering? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385332) Time Spent: 6h 20m (was: 6h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385326=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385326 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 11/Feb/20 18:12 Start Date: 11/Feb/20 18:12 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584775305 Could you also add a new feature note in https://github.com/apache/beam/blob/master/CHANGES.md This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385326) Time Spent: 6h 10m (was: 6h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385192 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 11/Feb/20 14:34 Start Date: 11/Feb/20 14:34 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584664469 > Seems tests aren't running properly in Jenkins. At the moment, only Beam commiters have permissions to trigger Jenkins jobs. But you can always ask someone on devlist to trigger them for you. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385192) Time Spent: 6h (was: 5h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 6h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385099=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385099 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 11/Feb/20 12:07 Start Date: 11/Feb/20 12:07 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584604776 Seems tests aren't running properly in Jenkins. But they all pass on my local machine. I'll let you re-trigger them and hope that it works. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385099) Time Spent: 5h 50m (was: 5h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=385012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-385012 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 11/Feb/20 08:17 Start Date: 11/Feb/20 08:17 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584520554 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 385012) Time Spent: 5h 40m (was: 5.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=384584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384584 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 10/Feb/20 17:18 Start Date: 10/Feb/20 17:18 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-584233466 LGTM. Triggering tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 384584) Time Spent: 5.5h (was: 5h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383834=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383834 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 07/Feb/20 21:16 Start Date: 07/Feb/20 21:16 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583616438 I like the idea of appending ml to the modules. Dropping the _ also seems prudent so it's consistent with most of io modules. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383834) Time Spent: 5h 20m (was: 5h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383772=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383772 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 07/Feb/20 18:26 Start Date: 07/Feb/20 18:26 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583541427 > > > Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. > > > > > > I think it is a good name reflects the underlying service as it is. Not very different from other gcp io with the similar names to the gcp services. > > I started work on https://issues.apache.org/jira/browse/BEAM-9247 to integrate the vision API in a similar PTransform. However, here the naming gets more complex. Consider e.g. > > ``` > from google.cloud import vision > from apache_beam.ml.gcp import vision > ``` > > One solution for the `vision` transforms is to rename the module `vision_api` instead. But I think we should be consistent across the different GCP ML APIs, so perhaps `video_intelligence` will need renaming too. > > What's your take? @aaltay I do not have a good idea. Users could solve this with something like the following: ``` from google.cloud import vision as gcp_vision_api from apache_beam.ml.gcp import vision ``` So, maybe it is not a big issue. I agree, it would be good if we can avoid this state. Related, in the io folder we have modules named `gcsio`, `bigtableio` etc. but we also have modules named `bigquery`, `pubsub`. So it is not very consistent. We can take the io example and change the names by appending ml, your example will look like: ``` from google.cloud import vision from apache_beam.ml.gcp import visionml from apache_beam.ml.gcp import videointelligenceml (Notice I also dropped _ between the words.) ``` What do you think? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383772) Time Spent: 5h 10m (was: 5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383520=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383520 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 07/Feb/20 12:33 Start Date: 07/Feb/20 12:33 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583370245 > > Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. > > I think it is a good name reflects the underlying service as it is. Not very different from other gcp io with the similar names to the gcp services. I started work on https://issues.apache.org/jira/browse/BEAM-9247 to integrate the vision API in a similar PTransform. However, here the naming gets more complex. Consider e.g. ``` from google.cloud import vision from apache_beam.ml.gcp import vision ``` One solution for the `vision` transforms is to rename the module `vision_api` instead. But I think we should be consistent across the different GCP ML APIs, so perhaps `video_intelligence` will need renaming too. What's your take? @aaltay This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383520) Time Spent: 5h (was: 4h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383518=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383518 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 07/Feb/20 12:30 Start Date: 07/Feb/20 12:30 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583370245 > > Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. > > I think it is a good name reflects the underlying service as it is. Not very different from other gcp io with the similar names to the gcp services. I started work on https://issues.apache.org/jira/browse/BEAM-9247 to integrate the vision API in a similar PTransform. However, here the naming gets more complex. Consider e.g. ``` from google.cloud import vision from apache_beam.ml.gcp import vision ``` One solution for the `vision` transforms is to rename the module `vision_api` instead. But I think we should be consistent across the different GCP ML APIs, so perhaps `video_intelligence` will need renaming too. What's your take? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383518) Time Spent: 4h 50m (was: 4h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 4h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383463=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383463 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 07/Feb/20 10:13 Start Date: 07/Feb/20 10:13 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583323796 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383463) Time Spent: 4h 40m (was: 4.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383075 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 19:15 Start Date: 06/Feb/20 19:15 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376029674 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,131 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from cachetools.func import ttl_cache +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +try: + from google.cloud import videointelligence +except ImportError: + raise ImportError( + 'Google Cloud Video Intelligence not supported for this execution environment ' + '(could not import google.cloud.videointelligence).') + +__all__ = ['AnnotateVideo'] + + +@ttl_cache(maxsize=128, ttl=3600) +def get_videointelligence_client(): + """Returns a Cloud Video Intelligence client.""" + _client = videointelligence.VideoIntelligenceServiceClient() + return _client + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, + features, + video_context=None, + location_id=None, + metadata=None, + timeout=120): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +timeout: (int) Optional. + The time in seconds to wait for the response from the Video Intelligence API +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata +self.timeout = timeout + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata, +timeout=self.timeout)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A DoFn that sends each input element to the GCP Video Intelligence API +service and outputs an element with the return result of the API +(``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``). + """ +def __init__(self, features, video_context, location_id, metadata, timeout): Review comment: We can default the timeout to 120 here. If you think that is a reasonable default. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383075) Time Spent: 4.5h (was: 4h 20m) > [Python] PTransform that integrates Video
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383026=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383026 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:33 Start Date: 06/Feb/20 18:33 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376008794 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket +response = self._client.annotate_video( +input_uri=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + elif isinstance(element, binary_type): # Is element raw bytes +response = self._client.annotate_video( +input_content=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + else: +raise TypeError( +"{}: input element needs to be either {} or {}" +" got {} instead".format( +self.__class__.__name__, text_type, binary_type,
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383025=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383025 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:32 Start Date: 06/Feb/20 18:32 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583046217 > Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. I think it is a good name reflects the underlying service as it is. Not very different from other gcp io with the similar names to the gcp services. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383025) Time Spent: 4h 10m (was: 4h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383024=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383024 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:31 Start Date: 06/Feb/20 18:31 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376007974 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket Review comment: Sounds good. Thank you for checking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383024) Time Spent: 4h (was: 3h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam >
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383020=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383020 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:26 Start Date: 06/Feb/20 18:26 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-583043711 Got one question regarding the naming. Is `video_intelligence` a good name for the module? I'm slightly worried it might cause confusion with the `google.cloud.videointelligence`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383020) Time Spent: 3h 50m (was: 3h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383018=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383018 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:23 Start Date: 06/Feb/20 18:23 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376004190 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket Review comment: As far as I can tell, it does not support batching https://cloud.google.com/video-intelligence/docs/reference/rest/v1/videos/annotate. But I may be wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383018) Time Spent: 3h 40m (was: 3.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key:
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383012=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383012 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:16 Start Date: 06/Feb/20 18:16 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376000832 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence_helper.py ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +Cloud Video Intelligence client + +For internal use only; no backwards-compatibility guarantees. +""" + +# pytype: skip-file + +from __future__ import absolute_import + +from cachetools.func import ttl_cache +from google.cloud import videointelligence + + +@ttl_cache(maxsize=128, ttl=3600) +def get_videointelligence_client(): Review comment: I don't think so no, so it would make sense to merge this code into the main videointelligence file. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383012) Time Spent: 3.5h (was: 3h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383009=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383009 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:15 Start Date: 06/Feb/20 18:15 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376000232 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket +response = self._client.annotate_video( +input_uri=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + elif isinstance(element, binary_type): # Is element raw bytes +response = self._client.annotate_video( +input_content=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + else: +raise TypeError( +"{}: input element needs to be either {} or {}" +" got {} instead".format( +self.__class__.__name__, text_type, binary_type,
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383010=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383010 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:15 Start Date: 06/Feb/20 18:15 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r376000343 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API Review comment: Gotcha, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383010) Time Spent: 3h 20m (was: 3h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=383008=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383008 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 18:11 Start Date: 06/Feb/20 18:11 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375997959 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket Review comment: Does the API have support for batching? If yes, it might be a good feature to support. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 383008) Time Spent: 3h (was: 2h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL:
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382992=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382992 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 17:43 Start Date: 06/Feb/20 17:43 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375981015 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ +def __init__(self, features, video_context, location_id, metadata): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.video_context = video_context + self.location_id = location_id + self.metadata = metadata + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, text_type): # Is element an URI to a GCS bucket +response = self._client.annotate_video( +input_uri=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + elif isinstance(element, binary_type): # Is element raw bytes +response = self._client.annotate_video( +input_content=element, +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata) + else: +raise TypeError( +"{}: input element needs to be either {} or {}" +" got {} instead".format( +self.__class__.__name__, text_type, binary_type,
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382994=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382994 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 17:43 Start Date: 06/Feb/20 17:43 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375982095 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence.py ## @@ -0,0 +1,107 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from future.utils import binary_type, text_type +from typing import Union + +from apache_beam import typehints +from apache_beam.ml.gcp import video_intelligence_helper as helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + +__all__ = ['AnnotateVideo'] + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + def __init__( + self, features, video_context=None, location_id=None, metadata=None): +""" + Args: +features: (List[``videointelligence_v1.enums.Feature``]) Required. + the Video Intelligence API features to detect +video_context: (dict, ``videointelligence_v1.types.VideoContext``) + Optional. + Additional video context and/or feature-specific parameters. +location_id: (str) Optional. + Cloud region where annotation should take place. + If no region is specified, a region will be determined + based on video file location. +metadata: (Sequence[Tuple[str, str]]) Optional. + Additional metadata that is provided to the method. +""" +super(AnnotateVideo, self).__init__() +self.features = features +self.video_context = video_context +self.location_id = location_id +self.metadata = metadata + + def expand(self, pvalue): +return pvalue | ParDo( +self._VideoAnnotateFn( +features=self.features, +video_context=self.video_context, +location_id=self.location_id, +metadata=self.metadata)) + + @typehints.with_input_types(Union[text_type, binary_type]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API Review comment: DoFn does not return a PCollection. Maybe we can update this to something like A DoFn that sends each input element to the GCP Video Intelligence API service and outputs an element with the return result of the API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382994) Time Spent: 2h 50m (was: 2h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382995=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382995 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 17:43 Start Date: 06/Feb/20 17:43 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375983683 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence_helper.py ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +Cloud Video Intelligence client + +For internal use only; no backwards-compatibility guarantees. +""" + +# pytype: skip-file + +from __future__ import absolute_import + +from cachetools.func import ttl_cache +from google.cloud import videointelligence + + +@ttl_cache(maxsize=128, ttl=3600) +def get_videointelligence_client(): Review comment: Are we expecting to use this for other APIs as well? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382995) Time Spent: 2h 50m (was: 2h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382993=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382993 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 17:43 Start Date: 06/Feb/20 17:43 Worklog Time Spent: 10m Work Description: aaltay commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375982972 ## File path: sdks/python/apache_beam/ml/gcp/video_intelligence_helper.py ## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" +Cloud Video Intelligence client + +For internal use only; no backwards-compatibility guarantees. +""" + +# pytype: skip-file + +from __future__ import absolute_import + +from cachetools.func import ttl_cache +from google.cloud import videointelligence Review comment: Should we guard this similar to other optional dependencies (example: https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/gcsio.py#L53) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382993) Time Spent: 2h 40m (was: 2.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382910=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382910 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 14:03 Start Date: 06/Feb/20 14:03 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582919453 Thanks for the feedback! I've adjusted the code to conform to py23 standards as well as added the extra arguments to annotate_video. I also added the `google-cloud-videointelligence` dependency which I've tested from version `1.8.0` up until `1.12.1`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382910) Time Spent: 2h 20m (was: 2h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382880=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382880 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 06/Feb/20 13:07 Start Date: 06/Feb/20 13:07 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582897313 > Related question, what is a good location for these family of transforms? io/... does not sounds right in this case. How about a top level ml/ folder similar to io. These transform could be put under ml/gcp? I agree `io/...` can be somewhat misleading. `ml/gcp` sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382880) Time Spent: 2h 10m (was: 2h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382386 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 17:00 Start Date: 05/Feb/20 17:00 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582507019 Thank you @kamilwu for the comment. That makes sense to me. Related question, what is a good location for these family of transforms? `io/...` does not sounds right in this case. How about a top level `ml/` folder similar to `io`. These transform could be put under `ml/gcp`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382386) Time Spent: 2h (was: 1h 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382229=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382229 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 12:11 Start Date: 05/Feb/20 12:11 Worklog Time Spent: 10m Work Description: kamilwu commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375219876 ## File path: sdks/python/apache_beam/io/gcp/ai/video_intelligence.py ## @@ -0,0 +1,75 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from typing import Union + +from apache_beam import typehints +from apache_beam.io.gcp.ai import helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + + def __init__(self, features): +""" + Args: +features: (List[``videointelligence.enums.Feature``]) + the Video Intelligence API features to detect +""" +super(AnnotateVideo).__init__() +self.features = features + + def expand(self, pvalue): +return pvalue | ParDo(self._VideoAnnotateFn(features=self.features)) + + @typehints.with_input_types(Union[str, bytes]) + class _VideoAnnotateFn(DoFn): +""" A ``DoFn`` that sends every element to the GCP Video Intelligence API + and returns a PCollection of +``google.cloud.videointelligence_v1.types.AnnotateVideoResponse``. + """ + +def __init__(self, features): + super(AnnotateVideo._VideoAnnotateFn, self).__init__() + self._client = None + self.features = features + self.counter = Metrics.counter(self.__class__, "API Calls") + +def start_bundle(self): + self._client = helper.get_videointelligence_client() + +def process(self, element, *args, **kwargs): + if isinstance(element, str): # Is element an URI to a GCS bucket Review comment: In Python 2 `str` and `bytes` are the same. Since Beam still supports Python 2.7, this code must be compatible with both Python 2 and 3. Consider using `future.utils` module which provides some methods that can help you to check type of an element. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382229) Time Spent: 1h 50m (was: 1h 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382226=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382226 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 12:05 Start Date: 05/Feb/20 12:05 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375217397 ## File path: sdks/python/apache_beam/io/gcp/ai/video_intelligence.py ## @@ -0,0 +1,75 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from typing import Union + +from apache_beam import typehints +from apache_beam.io.gcp.ai import helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + + def __init__(self, features): Review comment: Good idea, thanks! I'll have a look after we've finished the discussion with @aaltay about the usefulness of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382226) Time Spent: 1h 40m (was: 1.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382194=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382194 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 10:53 Start Date: 05/Feb/20 10:53 Worklog Time Spent: 10m Work Description: kamilwu commented on pull request #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#discussion_r375186324 ## File path: sdks/python/apache_beam/io/gcp/ai/video_intelligence.py ## @@ -0,0 +1,75 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +""" +A connector for sending API requests to the GCP Video Intelligence API. +""" +from __future__ import absolute_import + +from typing import Union + +from apache_beam import typehints +from apache_beam.io.gcp.ai import helper +from apache_beam.metrics import Metrics +from apache_beam.transforms import DoFn, ParDo, PTransform + + +class AnnotateVideo(PTransform): + """A ``PTransform`` for annotating video using the GCP Video Intelligence API + ref: https://cloud.google.com/video-intelligence/docs + """ + + def __init__(self, features): Review comment: I think we should also accept other parameters, not only `features`. A must have is `video_context`, because sometimes it provides additional feature-specific parameters. Others are `location_id` and possibly `metadata`. Take a look at the interface of `annotate_video()` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382194) Time Spent: 1.5h (was: 1h 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382187=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382187 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 10:43 Start Date: 05/Feb/20 10:43 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582347463 @EDjur Because you've added a new dependency, we have to specify it in setup.py file (`sdks/python/setup.py`) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382187) Time Spent: 1h 20m (was: 1h 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382185=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382185 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 10:40 Start Date: 05/Feb/20 10:40 Worklog Time Spent: 10m Work Description: kamilwu commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582346491 Thanks @EDjur. `tfx_bsl` seems to be useful only in some cases. One of these cases is [AI Platform Prediction](https://cloud.google.com/ai-platform/prediction/docs/overview), which, by the way, we also would like to support in Beam in the nearest future. Video Intelligence API is pretty much different. We should treat it as a fully-managed machine learning service. There is no machine learning model which could be trained and deployed. Instead, videos are annotated using pre-trained custom model provided by Google. All a user has to do is to enable API and make a request (using REST API or client library). The only input is a GCS path to a video file. As a result, there is little behavior that could be shared. If you have any questions regarding tfx_bsl and how it connects with Beam, just let me know, as I'm currently working to provide support for remote inference (an ability to call into services) in tfx_bsl. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382185) Time Spent: 1h 10m (was: 1h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=382137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382137 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 08:16 Start Date: 05/Feb/20 08:16 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582291447 @aaltay No worries - I've learnt a lot by creating this PR anyway! Curious to hear @kamilwu's thoughts on it too. I'm open to modify / work on another PR related to tfx_bsl if needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 382137) Time Spent: 1h (was: 50m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=381965=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381965 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 05/Feb/20 00:22 Start Date: 05/Feb/20 00:22 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582181978 @EDjur - Sorry for the miscommunication. These types of decisions should have reflected on JIRA as well. I feel bad that you spent time on this and we are changing direction after your PR is out. I think what it means for this ticket is that: - If tfx_bsl has ability to call into services (which we need to add and TFX team agreed to support us with reviews) - We can add thin transforms for different things (e.g. AnnotateVideo) and each of these transform will have quite a bit of shared code and behavior. @kamilwu may have other thoughts, since he was also working on this. I would like to hear what is his opinion. For this PR, let's try to re-use as much as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381965) Time Spent: 50m (was: 40m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=381725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381725 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 04/Feb/20 17:14 Start Date: 04/Feb/20 17:14 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582016962 I see. I signed up to the dev mailing list just last week so must've missed that discussion. What does that mean in regards to this ticket? I agree that it would be nice to avoid duplicated behaviour across libraries. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381725) Time Spent: 40m (was: 0.5h) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=381714=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381714 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 04/Feb/20 17:00 Start Date: 04/Feb/20 17:00 Worklog Time Spent: 10m Work Description: aaltay commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-582010646 Thank you @EDjur. I was hoping that we can implement most of the functionality in tfx_bsl, and add cloud AI services by defining new endpoints. We had a discussion on dev list [1] related to this. [1] https://lists.apache.org/thread.html/r3d9b0e3270668fda989f363eab1f79e4ef0e7fa3e0fcbe9c26344f14%40%3Cdev.beam.apache.org%3E This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381714) Time Spent: 0.5h (was: 20m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=381620=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381620 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 04/Feb/20 14:21 Start Date: 04/Feb/20 14:21 Worklog Time Spent: 10m Work Description: EDjur commented on issue #10764: [BEAM-9146] Integrate GCP Video Intelligence functionality for Python SDK URL: https://github.com/apache/beam/pull/10764#issuecomment-581931863 R: @aaltay @kamilwu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 381620) Time Spent: 20m (was: 10m) > [Python] PTransform that integrates Video Intelligence functionality > > > Key: BEAM-9146 > URL: https://issues.apache.org/jira/browse/BEAM-9146 > Project: Beam > Issue Type: Sub-task > Components: io-py-gcp >Reporter: Kamil Wasilewski >Assignee: Kamil Wasilewski >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The goal is to create a PTransform that integrates Google Cloud Video > Intelligence functionality [1]. > The transform should be able to take both video GCS location or video data > bytes as an input. > The transform should be put into _sdks/python/apache_beam/io/gcp/ai_ folder. > [1] https://cloud.google.com/video-intelligence/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9146) [Python] PTransform that integrates Video Intelligence functionality
[ https://issues.apache.org/jira/browse/BEAM-9146?focusedWorklogId=381618=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381618 ] ASF GitHub Bot logged work on BEAM-9146: Author: ASF GitHub Bot Created on: 04/Feb/20 14:19 Start Date: 04/Feb/20 14:19 Worklog Time Spent: 10m Work Description: EDjur commented on pull request #10764: BEAM-9146/gcp video intelligence URL: https://github.com/apache/beam/pull/10764 This PR relates to https://issues.apache.org/jira/browse/BEAM-9146 and integrates GCP Video Intelligence functionality as part of a PTransform that implicitly accepts a PCollection of GCS URIs or base64-encoded bytes. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [![Build