[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=387641=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387641 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 14/Feb/20 19:52 Start Date: 14/Feb/20 19:52 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 387641) Time Spent: 1h 10m (was: 1h) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=386978=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386978 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 14/Feb/20 00:02 Start Date: 14/Feb/20 00:02 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-586031921 Rebased this. Struct parameters still unusable however bc of https://issues.apache.org/jira/browse/BEAM-9300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386978) Time Spent: 1h (was: 50m) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 1h > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=386857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386857 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 13/Feb/20 20:17 Start Date: 13/Feb/20 20:17 Worklog Time Spent: 10m Work Description: amaliujia commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-585951921 Sorry some how recently PRs that tagging me no longer appear on my email/pull request list so I lost track of pending PR. This PR LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 386857) Time Spent: 50m (was: 40m) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 50m > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=379671=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379671 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 30/Jan/20 23:58 Start Date: 30/Jan/20 23:58 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-580517806 I wrote a test (great idea, I know) and it fails anyway because we don't support structs in general: https://github.com/apache/beam/blob/e43ed3ca84881d8140c675e217bb1f45814ffd92/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L569-L571 So this is kind of pointless for now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 379671) Time Spent: 40m (was: 0.5h) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 40m > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=378961=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378961 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 29/Jan/20 18:20 Start Date: 29/Jan/20 18:20 Worklog Time Spent: 10m Work Description: apilloud commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-579891424 Run Java_Examples_Dataflow PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378961) Time Spent: 0.5h (was: 20m) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 0.5h > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=378584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378584 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 29/Jan/20 00:14 Start Date: 29/Jan/20 00:14 Worklog Time Spent: 10m Work Description: ibzib commented on issue #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707#issuecomment-579534521 I thought about substituting TypeKind (which is well-defined) for Type. However, in this case the error messages could be nonsensical, for example `Expected resolved parameter foo to have type Struct, but it has type Struct`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 378584) Time Spent: 20m (was: 10m) > ZetaSQL structs always cause exception > -- > > Key: BEAM-9212 > URL: https://issues.apache.org/jira/browse/BEAM-9212 > Project: Beam > Issue Type: Bug > Components: dsl-sql-zetasql >Reporter: Kyle Weaver >Assignee: Kyle Weaver >Priority: Major > Fix For: Not applicable > > Time Spent: 20m > Remaining Estimate: 0h > > Because of an unimplemented method in ZetaSQL [1], StructType.toString always > throws an exception. This is bad because we always call toString implicitly > in a String.format [2]. > [1] https://github.com/google/zetasql/issues/24 > [2] > https://github.com/apache/beam/blob/b02a325409d55f1ecb7f9fb6ecc4f60a974c810d/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java#L1010-L1012 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9212) ZetaSQL structs always cause exception
[ https://issues.apache.org/jira/browse/BEAM-9212?focusedWorklogId=378567=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378567 ] ASF GitHub Bot logged work on BEAM-9212: Author: ASF GitHub Bot Created on: 28/Jan/20 23:40 Start Date: 28/Jan/20 23:40 Worklog Time Spent: 10m Work Description: ibzib commented on pull request #10707: [BEAM-9212] fix zetasql struct exception URL: https://github.com/apache/beam/pull/10707 https://issues.apache.org/jira/browse/BEAM-9212 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)[