[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409936=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409936 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 22:19 Start Date: 25/Mar/20 22:19 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409936) Time Spent: 2h 10m (was: 2h) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409838 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 21:37 Start Date: 25/Mar/20 21:37 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604100957 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409838) Time Spent: 2h (was: 1h 50m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409837 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 21:34 Start Date: 25/Mar/20 21:34 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099816 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409837) Time Spent: 1h 50m (was: 1h 40m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409836 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 21:34 Start Date: 25/Mar/20 21:34 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099693 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409836) Time Spent: 1h 40m (was: 1.5h) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409835=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409835 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 21:34 Start Date: 25/Mar/20 21:34 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099649 thanks Sam! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409835) Time Spent: 1.5h (was: 1h 20m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409830=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409830 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 21:18 Start Date: 25/Mar/20 21:18 Worklog Time Spent: 10m Work Description: rohdesamuel commented on pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#discussion_r398175950 ## File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py ## @@ -150,9 +151,10 @@ def process(self, element): ] self.assertEqual(actual_reified, expected_reified) + @unittest.skipIf( + sys.version_info < (3, 6), + 'InteractiveRunner has a minimum Python version of 3.5.3.') Review comment: Yeah, sounds good. Testing it on 3.5.4 led to some elements being in non-deterministic order, so I fixed up the Dataframe equality logic to also do a sort. Though interestingly enough this passes on later version of Python. This is probably because the dict ordering respects insertion ordering on later version, 3.6+ if I'm not mistaken. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409830) Time Spent: 1h 20m (was: 1h 10m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409760=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409760 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 19:40 Start Date: 25/Mar/20 19:40 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#discussion_r398120887 ## File path: sdks/python/apache_beam/runners/interactive/interactive_runner_test.py ## @@ -150,9 +151,10 @@ def process(self, element): ] self.assertEqual(actual_reified, expected_reified) + @unittest.skipIf( + sys.version_info < (3, 6), + 'InteractiveRunner has a minimum Python version of 3.5.3.') Review comment: should we skip if sys.version_info < 3,5,3? so we'll test on 3.5 if it's the right subversion? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409760) Time Spent: 1h 10m (was: 1h) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409759 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 19:39 Start Date: 25/Mar/20 19:39 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604045227 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409759) Time Spent: 1h (was: 50m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409758=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409758 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 19:37 Start Date: 25/Mar/20 19:37 Worklog Time Spent: 10m Work Description: rohdesamuel commented on pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227 Change-Id: I9caaf395fd0fc58565e54a8458e8289af761815f The InteractiveRunner requires Python3.5.3+. We have a pattern in which we disable the tests that fail on Python2.7. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[![Build
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409311 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 04:43 Start Date: 25/Mar/20 04:43 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11215: [BEAM-9601] unbreaking precommits URL: https://github.com/apache/beam/pull/11215#issuecomment-603637189 I've merged to clear up precommits. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409311) Time Spent: 40m (was: 0.5h) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409310 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 04:42 Start Date: 25/Mar/20 04:42 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11215: [BEAM-9601] unbreaking precommits URL: https://github.com/apache/beam/pull/11215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409310) Time Spent: 0.5h (was: 20m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409296 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 03:02 Start Date: 25/Mar/20 03:02 Worklog Time Spent: 10m Work Description: pabloem commented on issue #11215: [BEAM-9601] unbreaking precommits URL: https://github.com/apache/beam/pull/11215#issuecomment-603613569 r: @udim This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 409296) Time Spent: 20m (was: 10m) > Interactive test_streaming_wordcount failing > > > Key: BEAM-9601 > URL: https://issues.apache.org/jira/browse/BEAM-9601 > Project: Beam > Issue Type: Bug > Components: runner-py-interactive, test-failures >Reporter: Pablo Estrada >Assignee: Sam Rohde >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (BEAM-9601) Interactive test_streaming_wordcount failing
[ https://issues.apache.org/jira/browse/BEAM-9601?focusedWorklogId=409290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409290 ] ASF GitHub Bot logged work on BEAM-9601: Author: ASF GitHub Bot Created on: 25/Mar/20 02:50 Start Date: 25/Mar/20 02:50 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #11215: [BEAM-9601] unbreaking precommits URL: https://github.com/apache/beam/pull/11215 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`). - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier). Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)[