[GitHub] sijie commented on issue #1113: BP-28: Etcd as metadata store

2018-02-02 Thread GitBox
sijie commented on issue #1113: BP-28: Etcd as metadata store URL: https://github.com/apache/bookkeeper/pull/1113#issuecomment-362567530 @jvrao : https://github.com/sijie/bookkeeper/blob/19590b58a0aa54c9714b339ffedc2ded13ec4160/site/bps/BP-28-etcd-as-metadata-store.md

Jenkins build is back to normal : bookkeeper_release_branch #47

2018-02-02 Thread Apache Jenkins Server
See

Jenkins build is back to stable : bookkeeper_postcommit_master_java9 #30

2018-02-02 Thread Apache Jenkins Server
See

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165711899 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java ## @@ -1430,19

[GitHub] sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r165718676 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165681334 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165681356 ## File path: .gitignore ## @@ -20,3 +20,4 @@ lib/ log/ target/

[GitHub] eolivelli commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-362631969 @sijie I have addressed all of your review comments, except from dropping *pendingAddsSequenceHead*, because now we

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165689136 ## File path:

[GitHub] reddycharan commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r165711029 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165681963 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165682170 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165681674 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165689136 ## File path:

[GitHub] eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#discussion_r165683039 ## File path:

[GitHub] sijie commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
sijie commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-362654400 @eolivelli is this still "WIP" or ready for review? This

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165720124 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java ## @@ -1430,19 +1432,44 @@

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165722458 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165725190 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] sijie commented on issue #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
sijie commented on issue #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115#issuecomment-362698987 @yzang : make `FlatLedgerManagerFactory` as `@deprecated`

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165728368 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165728252 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@ -61,7

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165733498 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14 +46,17

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165733652 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7 +91,18

[GitHub] sijie commented on issue #1116: Cleanup registration client interface

2018-02-02 Thread GitBox
sijie commented on issue #1116: Cleanup registration client interface URL: https://github.com/apache/bookkeeper/pull/1116#issuecomment-362693360 @jiazhai since you did the interface abstraction, can you take a look to see if this work for you. @merlimat since pulsar is the main user

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165759553 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java ## @@ -1430,19

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165763335 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14 +46,17

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165763534 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7 +91,18

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165726882 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165732674 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7 +91,18

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165757994 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@ -61,7

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165754551 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165764523 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14 +46,17

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165764894 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7 +91,18

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165725190 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165758468 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165733931 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperAdminTest.java ## @@ -61,7 +61,7 @@

[GitHub] sijie commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165734169 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14 +46,17

[GitHub] sijie commented on issue #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
sijie commented on issue #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115#issuecomment-362693556 > Maybe we can add @deprecated annotations to FlatLedgerManagerFactory class? good idea

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165754551 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-02 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-362783315 @jvrao @reddycharan: since you guys contributed a lot of shell commands, it would be great that you guys can spend some time on reviewing this one.

[GitHub] sijie commented on issue #1118: Travis CI should not use a hardcoded release version for check-release script

2018-02-02 Thread GitBox
sijie commented on issue #1118: Travis CI should not use a hardcoded release version for check-release script URL: https://github.com/apache/bookkeeper/pull/1118#issuecomment-362782237 retest this please This is an automated

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-02 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-362783195 This change is ready to review now This is an automated message from the Apache Git

[GitHub] eolivelli commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-02 Thread GitBox
eolivelli commented on issue #853: WIP - BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-362680500 It is ready This is an automated message from the

[GitHub] sijie opened a new pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
sijie opened a new pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115 Descriptions of the changes in this PR: the discussion can be found at :

[GitHub] sijie opened a new pull request #1116: Cleanup registration client interface

2018-02-02 Thread GitBox
sijie opened a new pull request #1116: Cleanup registration client interface URL: https://github.com/apache/bookkeeper/pull/1116 Descriptions of the changes in this PR: This change is mainly to remove `zookeeper` reference from metadata interface. The existence of `Optional` is to

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165753916 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165756792 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] sijie closed pull request #1111: Update PR template

2018-02-02 Thread GitBox
sijie closed pull request #: Update PR template URL: https://github.com/apache/bookkeeper/pull/ This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] eolivelli commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-02 Thread GitBox
eolivelli commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-362730853 Please fix checkstyle, which wants the java doc comment

[GitHub] reddycharan commented on issue #1097: Use loopback network interface for testcases.

2018-02-02 Thread GitBox
reddycharan commented on issue #1097: Use loopback network interface for testcases. URL: https://github.com/apache/bookkeeper/pull/1097#issuecomment-362750692 @sijie I made changes to the initial commit and replaced the initial commit. Can you sign-off on this. Thanks.

[GitHub] sijie closed pull request #1077: ISSUE #1067: PendingReadOp: recovery, return NoSuchEntry on wQ-aQ+1 errors

2018-02-02 Thread GitBox
sijie closed pull request #1077: ISSUE #1067: PendingReadOp: recovery, return NoSuchEntry on wQ-aQ+1 errors URL: https://github.com/apache/bookkeeper/pull/1077 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed issue #1067: RecoveryReadOp: a single hanging bookie can prevent a ledger from fencing

2018-02-02 Thread GitBox
sijie closed issue #1067: RecoveryReadOp: a single hanging bookie can prevent a ledger from fencing URL: https://github.com/apache/bookkeeper/issues/1067 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #1097: Use loopback network interface for testcases.

2018-02-02 Thread GitBox
sijie commented on issue #1097: Use loopback network interface for testcases. URL: https://github.com/apache/bookkeeper/pull/1097#issuecomment-362750747 @reddycharan I don't think the failures are related. This is an

[GitHub] sijie closed pull request #1096: BP-26 (task 4): run dlog tests when pull requests modify dlog modules

2018-02-02 Thread GitBox
sijie closed pull request #1096: BP-26 (task 4): run dlog tests when pull requests modify dlog modules URL: https://github.com/apache/bookkeeper/pull/1096 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie commented on issue #1117: BP-29: Metadata API module

2018-02-02 Thread GitBox
sijie commented on issue #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#issuecomment-362744290 @jvrao as discussed, here is the proposal :

[GitHub] sijie closed pull request #1095: BP-26 (task 3) : Build dlog shaded jar in bookkeeper way

2018-02-02 Thread GitBox
sijie closed pull request #1095: BP-26 (task 3) : Build dlog shaded jar in bookkeeper way URL: https://github.com/apache/bookkeeper/pull/1095 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments

2018-02-02 Thread GitBox
sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments URL: https://github.com/apache/bookkeeper/pull/1085#issuecomment-362752654 @eolivelli can you review this again? @jiazhai already addressed your comment. @revans2

[GitHub] jiazhai commented on a change in pull request #1113: BP-28: Etcd as metadata store

2018-02-02 Thread GitBox
jiazhai commented on a change in pull request #1113: BP-28: Etcd as metadata store URL: https://github.com/apache/bookkeeper/pull/1113#discussion_r165800469 ## File path: site/bps/BP-28-etcd-as-metadata-store.md ## @@ -0,0 +1,102 @@ +--- +title: "BP-28: use etcd as

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165777075 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -44,14

[GitHub] sijie commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115#discussion_r165787436 ## File path: deploy/kubernetes/gke/bookkeeper.statefulset.yml ## @@ -39,8 +39,6

[GitHub] sijie opened a new pull request #1117: BP-29: Metadata API module

2018-02-02 Thread GitBox
sijie opened a new pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117 Descriptions of the changes in this PR: Related to BP-28 (#1113), this proposal is to propose how we want to organize the metadata modules, to support different

[GitHub] reddycharan commented on issue #1097: Use loopback network interface for testcases.

2018-02-02 Thread GitBox
reddycharan commented on issue #1097: Use loopback network interface for testcases. URL: https://github.com/apache/bookkeeper/pull/1097#issuecomment-362750431 I ran locally AuditorLedgerCheckerTest and BookieClientTest multiple times and they are running fine. Not sure why tests failed

[GitHub] reddycharan commented on issue #1097: Use loopback network interface for testcases.

2018-02-02 Thread GitBox
reddycharan commented on issue #1097: Use loopback network interface for testcases. URL: https://github.com/apache/bookkeeper/pull/1097#issuecomment-362750431 I ran locally AuditorLedgerCheckerTest and BookieClientTest multiple times and they are running fine. Not sure why tests failed

[GitHub] sijie opened a new pull request #1118: Travis CI should not use a hardcoded release version for check-release script

2018-02-02 Thread GitBox
sijie opened a new pull request #1118: Travis CI should not use a hardcoded release version for check-release script URL: https://github.com/apache/bookkeeper/pull/1118 Descriptions of the changes in this PR: CI is going to be broken when we bumped to 4.8.0. since travis CI is

[GitHub] jiazhai commented on a change in pull request #1117: BP-29: Metadata API module

2018-02-02 Thread GitBox
jiazhai commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r165799985 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] reddycharan commented on a change in pull request #1100: Improve decomission test

2018-02-02 Thread GitBox
reddycharan commented on a change in pull request #1100: Improve decomission test URL: https://github.com/apache/bookkeeper/pull/1100#discussion_r165777903 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieDecommissionTest.java ## @@ -86,7

[GitHub] eolivelli commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115#discussion_r165779555 ## File path: deploy/kubernetes/gke/bookkeeper.yaml ## @@ -30,8 +30,6 @@

[GitHub] eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception URL: https://github.com/apache/bookkeeper/pull/1110#discussion_r165780705 ## File path:

[GitHub] eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #1110: Issue 1109: Error out pending ops on TLS key mismatch exception URL: https://github.com/apache/bookkeeper/pull/1110#discussion_r165780957 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/TestTLS.java

[GitHub] sijie closed pull request #1112: Update release schedule

2018-02-02 Thread GitBox
sijie closed pull request #1112: Update release schedule URL: https://github.com/apache/bookkeeper/pull/1112 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] sijie commented on issue #1100: Improve decommission test

2018-02-02 Thread GitBox
sijie commented on issue #1100: Improve decommission test URL: https://github.com/apache/bookkeeper/pull/1100#issuecomment-362753771 @reddycharan since this branch depends on #1099 . I will address your comments here as we discussed offline after #1099 is in.

[GitHub] eolivelli commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical`

2018-02-02 Thread GitBox
eolivelli commented on a change in pull request #1115: Change default ledger manager factory from `Flat` to `Hierachical` URL: https://github.com/apache/bookkeeper/pull/1115#discussion_r165779742 ## File path: deploy/kubernetes/gke/bookkeeper.statefulset.yml ## @@ -39,8

[GitHub] sijie commented on issue #1091: Issue 1063: Write keeps refCnt longer

2018-02-02 Thread GitBox
sijie commented on issue #1091: Issue 1063: Write keeps refCnt longer URL: https://github.com/apache/bookkeeper/pull/1091#issuecomment-362750080 thanks @jvrao . merge it and also cherry-picked to branch-4.6, since it is a good fix to be picked at 4.6.

[GitHub] sijie closed pull request #1091: Issue 1063: Write keeps refCnt longer

2018-02-02 Thread GitBox
sijie closed pull request #1091: Issue 1063: Write keeps refCnt longer URL: https://github.com/apache/bookkeeper/pull/1091 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client

2018-02-02 Thread GitBox
sijie commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client URL: https://github.com/apache/bookkeeper/pull/970#issuecomment-362750216 @eolivelli can you review this again? @athanatos addressed your comment.

[GitHub] sijie closed issue #1063: PendingAddOp keeps refCnt onthe toSend buffer longer than needed.

2018-02-02 Thread GitBox
sijie closed issue #1063: PendingAddOp keeps refCnt onthe toSend buffer longer than needed. URL: https://github.com/apache/bookkeeper/issues/1063 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed pull request #1104: Revamped downloads page

2018-02-02 Thread GitBox
sijie closed pull request #1104: Revamped downloads page URL: https://github.com/apache/bookkeeper/pull/1104 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] sijie closed pull request #1097: Use loopback network interface for testcases.

2018-02-02 Thread GitBox
sijie closed pull request #1097: Use loopback network interface for testcases. URL: https://github.com/apache/bookkeeper/pull/1097 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jiazhai commented on a change in pull request #1117: BP-29: Metadata API module

2018-02-02 Thread GitBox
jiazhai commented on a change in pull request #1117: BP-29: Metadata API module URL: https://github.com/apache/bookkeeper/pull/1117#discussion_r165799985 ## File path: site/bps/BP-29-metadata-store-api-module.md ## @@ -0,0 +1,87 @@ +--- +title: "BP-29: Metadata API module"

[GitHub] sijie opened a new pull request #1113: BP-28: Etcd as metadata store

2018-02-02 Thread GitBox
sijie opened a new pull request #1113: BP-28: Etcd as metadata store URL: https://github.com/apache/bookkeeper/pull/1113 Descriptions of the changes in this PR: This BP is exploring using Etcd as the metadata store.

[GitHub] sijie commented on issue #1114: BP-28 (prototype): use Etcd as metadata store

2018-02-02 Thread GitBox
sijie commented on issue #1114: BP-28 (prototype): use Etcd as metadata store URL: https://github.com/apache/bookkeeper/pull/1114#issuecomment-362562660 @jvrao as we discussed today, I pushed my prototype changes here and raised a BP for discussion.

[GitHub] sijie opened a new pull request #1111: Update PR template

2018-02-02 Thread GitBox
sijie opened a new pull request #: Update PR template URL: https://github.com/apache/bookkeeper/pull/ Descriptions of the changes in this PR: - JIRA is not used anymore. Remove it from PR template. This

[GitHub] sijie opened a new pull request #1112: Update release schedule

2018-02-02 Thread GitBox
sijie opened a new pull request #1112: Update release schedule URL: https://github.com/apache/bookkeeper/pull/1112 Descriptions of the changes in this PR: - update current feature release to 4.7.0 and its release window - add a section in release guide for instructions to update

[GitHub] sijie commented on a change in pull request #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#discussion_r165578182 ## File path:

[GitHub] sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

2018-02-02 Thread GitBox
sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r165578640 ## File path:

Build failed in Jenkins: distributedlog-nightly-build #565

2018-02-02 Thread Apache Jenkins Server
See -- [...truncated 252.15 KB...] [INFO] Downloaded: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/34/commons-parent-34.pom (56 kB at 3.7 MB/s)

Build failed in Jenkins: distributedlog-release-nightly-snapshot #155

2018-02-02 Thread Apache Jenkins Server
See -- [...truncated 295.12 KB...] [INFO] Downloaded: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/34/commons-parent-34.pom (56 kB at