[GitHub] ivankelly commented on issue #1131: Split all versions images into released and latest

2018-02-14 Thread GitBox
ivankelly commented on issue #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131#issuecomment-365544555 retest this please This is an automated message from the

[GitHub] ivankelly commented on issue #1142: Gather disk information before CI build

2018-02-14 Thread GitBox
ivankelly commented on issue #1142: Gather disk information before CI build URL: https://github.com/apache/bookkeeper/pull/1142#issuecomment-365614153 @sijie @eolivelli I checked with the infra folks on hipchat. they say it's fine

Jenkins build is still unstable: bookkeeper_release_branch #59

2018-02-14 Thread Apache Jenkins Server
See

Jenkins build is still unstable: bookkeeper_postcommit_master_java8 #41

2018-02-14 Thread Apache Jenkins Server
See

[GitHub] ivankelly commented on issue #1135: Specify repo in MavenClassLoader

2018-02-14 Thread GitBox
ivankelly commented on issue #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135#issuecomment-365638484 retest this please This is an automated message from the Apache Git Service. To

Jenkins build is back to stable : bookkeeper_release_nightly_snapshot #59

2018-02-14 Thread Apache Jenkins Server
See

Jenkins build is back to stable : bookkeeper_postcommit_master_java9 #42

2018-02-14 Thread Apache Jenkins Server
See

[GitHub] ivankelly closed pull request #1131: Split all versions images into released and latest

2018-02-14 Thread GitBox
ivankelly closed pull request #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

2018-02-14 Thread GitBox
sijie commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#issuecomment-365671775 retest this please

[GitHub] kishorvpatil opened a new pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

2018-02-14 Thread GitBox
kishorvpatil opened a new pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125 Descriptions of the changes in this PR: The PR contains the fix to cleanup non-existent

[GitHub] sijie closed pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

2018-02-14 Thread GitBox
sijie closed pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168240944 ## File path:

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168241554 ## File path:

[GitHub] reddycharan commented on issue #1100: Improve decommission test

2018-02-14 Thread GitBox
reddycharan commented on issue #1100: Improve decommission test URL: https://github.com/apache/bookkeeper/pull/1100#issuecomment-365696547 LGTM +1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

2018-02-14 Thread GitBox
sijie commented on issue #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#issuecomment-365681168 retest this please This is an

[GitHub] sijie commented on issue #1133: Integration smoke test

2018-02-14 Thread GitBox
sijie commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-365695215 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed pull request #1135: Specify repo in MavenClassLoader

2018-02-14 Thread GitBox
sijie closed pull request #1135: Specify repo in MavenClassLoader URL: https://github.com/apache/bookkeeper/pull/1135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-14 Thread GitBox
sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365680586 @merlimat do you need any help to fix the checkstyle problem, so we can move forward with

[GitHub] merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-14 Thread GitBox
merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365684412 I'd close this one in favor of #1141

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168261214 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java ##

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168261389 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java ## @@ -0,0

[GitHub] ivankelly commented on issue #1142: Gather disk information before CI build

2018-02-14 Thread GitBox
ivankelly commented on issue #1142: Gather disk information before CI build URL: https://github.com/apache/bookkeeper/pull/1142#issuecomment-365664712 Merging this. This is an automated message from the Apache Git Service.

[GitHub] sijie commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing URL: https://github.com/apache/bookkeeper/pull/1140#discussion_r168245303 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java

[GitHub] sijie commented on issue #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

2018-02-14 Thread GitBox
sijie commented on issue #1110: Issue 1109: Error out pending ops on TLS key mismatch exception URL: https://github.com/apache/bookkeeper/pull/1110#issuecomment-365679452 @jiazhai since you were in reviewing this PR, can you review this again since @kishorekasi addressed your comment?

[GitHub] sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1099: Fix auditor shutdown logic and move decommision tests out of BookKeeperAdminTest URL: https://github.com/apache/bookkeeper/pull/1099#discussion_r168249000 ## File path:

[GitHub] sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments

2018-02-14 Thread GitBox
sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments URL: https://github.com/apache/bookkeeper/pull/1085#issuecomment-365681541 ping @eolivelli This is an

[GitHub] sijie commented on issue #1087: ISSUE #1075: Add a noop digest implentation

2018-02-14 Thread GitBox
sijie commented on issue #1087: ISSUE #1075: Add a noop digest implentation URL: https://github.com/apache/bookkeeper/pull/1087#issuecomment-365681417 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-14 Thread GitBox
sijie commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365688896 @merlimat yeah. this PR is good for 4.6.2. so if you can fix the checkstyle here, I can

[GitHub] ivankelly commented on issue #1131: Split all versions images into released and latest

2018-02-14 Thread GitBox
ivankelly commented on issue #1131: Split all versions images into released and latest URL: https://github.com/apache/bookkeeper/pull/1131#issuecomment-365596160 retest this please This is an automated message from the

[GitHub] jvrao commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
jvrao commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168311642 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365749653 Adding a 'Ignore ci' comment. This will enable merge of this patch in spite of ci failures

[GitHub] jvrao commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
jvrao commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365751061 Thanks @eolivelli . Ignore CI comment on the pull request? If that is the process, I must have missed it. Doesn't BP make it implicit to the

[GitHub] dlg99 commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)

2018-02-14 Thread GitBox
dlg99 commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#issuecomment-365740314 @sijie sorry for the delay, missed

[GitHub] jvrao commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
jvrao commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168311020 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] jvrao commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
jvrao commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365747490 @sijie Not sure how to resolve Jenkin's failures for this Issue MD file. This is

[GitHub] eolivelli commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
eolivelli commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168313262 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] eolivelli commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
eolivelli commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168313486 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365749801 Ignore CI This is an automated message from the Apache Git Service. To respond

[GitHub] eolivelli commented on issue #1141: Replace DoubleByteBuf with ByteBufList

2018-02-14 Thread GitBox
eolivelli commented on issue #1141: Replace DoubleByteBuf with ByteBufList URL: https://github.com/apache/bookkeeper/pull/1141#issuecomment-365750662 Tests cannot compile due to a warning, can you fix it please? So that we can move forward

[GitHub] dlg99 commented on a change in pull request #1141: Replace DoubleByteBuf with ByteBufList

2018-02-14 Thread GitBox
dlg99 commented on a change in pull request #1141: Replace DoubleByteBuf with ByteBufList URL: https://github.com/apache/bookkeeper/pull/1141#discussion_r168315873 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ## @@

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365772210 > Is there any command to list all bookies and their state? For example, by default, we list all bookies running in the cluster and their running mode if

[GitHub] reddycharan commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365776717 yeah, there is value in printing all bookies if no option is set. But in your earlier change you were printing all bookies for -rw option.

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365779270 @reddycharan yes. I fixed that after your first comment. your second comment was asking for printing bookies when "one and only one flag is set". so does it

[GitHub] reddycharan commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365780225 I have an issue with "-rw" and "-ro" print both". In your logic if both the options are provided then you are printing both "-rw" and "-ro" bookies

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365781973 @reddycharan okay I will update headlines like "readwrite bookies" and "readonly bookies". does that make sense?

[GitHub] reddycharan commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365782689 yes, with clear logging it should be good. This is an automated message from the

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168349884 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: any reason for

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168349715 ## File path:

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168349626 ## File path:

[GitHub] ivankelly closed pull request #1142: Gather disk information before CI build

2018-02-14 Thread GitBox
ivankelly closed pull request #1142: Gather disk information before CI build URL: https://github.com/apache/bookkeeper/pull/1142 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager

2018-02-14 Thread GitBox
sijie commented on issue #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#issuecomment-365678080 ping @jvrao This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1127: BP-29 (task 1) : Introduce `metadataServiceUrl`

2018-02-14 Thread GitBox
sijie commented on issue #1127: BP-29 (task 1) : Introduce `metadataServiceUrl` URL: https://github.com/apache/bookkeeper/pull/1127#issuecomment-365678201 ping @jvrao This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #1110: Issue 1109: Error out pending ops on TLS key mismatch exception

2018-02-14 Thread GitBox
sijie commented on issue #1110: Issue 1109: Error out pending ops on TLS key mismatch exception URL: https://github.com/apache/bookkeeper/pull/1110#issuecomment-365680205 retest this please This is an automated message from

[GitHub] sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments

2018-02-14 Thread GitBox
sijie commented on issue #1085: [Merge Yahoo repo]: YBK-160: Doing distributed random verification of ledger fragments URL: https://github.com/apache/bookkeeper/pull/1085#issuecomment-365681563 retest this please This is an

[GitHub] merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12

2018-02-14 Thread GitBox
merlimat commented on issue #1108: Replace DoubleByteBuf with CompositeByteBuf because of perf regression with Netty > 4.1.12 URL: https://github.com/apache/bookkeeper/pull/1108#issuecomment-365684674 (maybe this PR could be used for 4.6.2, but for 4.7.0 I'd rather go with the #1441

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365694176 @reddycharan I have addressed your comments. please review it again. This is an automated

[GitHub] yzang commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
yzang commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168268922 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java ##

[GitHub] eolivelli commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager

2018-02-14 Thread GitBox
eolivelli commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r168317638 ## File path:

[GitHub] sijie commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)

2018-02-14 Thread GitBox
sijie commented on issue #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#issuecomment-365758418 @dlg99 sgtm

[GitHub] eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
eolivelli commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365759111 See https://github.com/apache/bookkeeper/pull/1145 This is an automated

[GitHub] sijie commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r168329867 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java

[GitHub] eolivelli commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager

2018-02-14 Thread GitBox
eolivelli commented on a change in pull request #1130: handle zookeeper session expire in zk ledger manager URL: https://github.com/apache/bookkeeper/pull/1130#discussion_r168317638 ## File path:

[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-14 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-365771167 @sijie ok to merge this? This is an automated message from the Apache Git Service. To

[GitHub] ivankelly opened a new pull request #1146: Include yahoo custom version in all versions image

2018-02-14 Thread GitBox
ivankelly opened a new pull request #1146: Include yahoo custom version in all versions image URL: https://github.com/apache/bookkeeper/pull/1146 To ensure compatibility between versions during the merge, we need the yahoo custom version of bookkeeper. The most straightforward

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351975 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: the thought here is

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365788948 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365788909 @reddycharan I updated this PR to make listbookies to list all bookies if no args is provided or both args are provided.

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168352326 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: to un this shell

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168354161 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168355576 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: @sijie after

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168356754 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] athanatos commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client

2018-02-14 Thread GitBox
athanatos commented on issue #970: ISSUE #966: Expose quorum write complete latency to the client URL: https://github.com/apache/bookkeeper/pull/970#issuecomment-365794149 @eolivelli repushed with fix This is an automated

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365796214 retest this please

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365796195 @jvrao can you review this PR again since you were involved in this PR?

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168359420 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: do you run with a clean

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168359769 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168359983 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java ## @@

[GitHub] sijie opened a new issue #1147: Move bookkeeper-server/{bin,conf} to root module

2018-02-14 Thread GitBox
sijie opened a new issue #1147: Move bookkeeper-server/{bin,conf} to root module URL: https://github.com/apache/bookkeeper/issues/1147 since 4.7, we are shipping the binary distribution using bookkeeper-dist modules. so it is making more sense to have {bin,conf} directory at root module,

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168361120 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365798669 @reddycharan I have addressed your comments. please take a look again. This is an automated

[GitHub] sijie commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
sijie commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-36573 @eolivelli in general, I think we should use "Ignore CI" just before a committer is about to merge it, and it should be the committer who is merging

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168366800 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168366800 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] sijie commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365808654 @reddycharan updated this PR to use "bookkeeper-cli" instead of "bookie-shell" in the command output, to avoid confusion.

[GitHub] sijie commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168363317 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] sijie commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#discussion_r168363075 ## File path: site/bps/BP-31-durability ## @@ -0,0 +1,134 @@ + +--- +title: "BP-31: BookKeeper

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364631 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: probably not..and

[GitHub] sijie commented on issue #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on issue #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-365807809 @reddycharan I'd like to clarify this PR is the first change for BP-27, it just tries to setup the skeleton and port only 3 commands. more changes

[GitHub] sijie commented on issue #1138: BP-31 BookKeeper Durability Anchor

2018-02-14 Thread GitBox
sijie commented on issue #1138: BP-31 BookKeeper Durability Anchor URL: https://github.com/apache/bookkeeper/pull/1138#issuecomment-365800410 @jvrao the jenkins CI failed because changing default ledger manager class from flat to hierarchical. #1137 has fixed this. in this case, you can

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168367655 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java ## @@

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168367675 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] sijie commented on a change in pull request #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-14 Thread GitBox
sijie commented on a change in pull request #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168369025 ## File path:

[GitHub] reddycharan commented on a change in pull request #1094: BP-27 (part 1): New BookKeeper CLI Skeleton

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168396304 ## File path: bookkeeper-tools/src/main/java/org/apache/bookkeeper/tools/cli/BookKeeperCLI.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364008 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364008 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] jvrao commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

2018-02-14 Thread GitBox
jvrao commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r168380594 ## File

[GitHub] jvrao commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy

2018-02-14 Thread GitBox
jvrao commented on a change in pull request #1088: ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load) URL: https://github.com/apache/bookkeeper/pull/1088#discussion_r168380451 ## File

  1   2   >