[GitHub] philipsu522 commented on issue #1168: Fix TestBKSyncLogReader

philipsu522 commented on issue #1168: Fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#issuecomment-370009640 LGTM +1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171930561 ## File path:

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171949745 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171962627 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171962703 ## File path:

[GitHub] sijie commented on issue #1168: Fix TestBKSyncLogReader

sijie commented on issue #1168: Fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#issuecomment-370017379 @jiazhai @yzang @philipsu522 I have changed the way how the test was written. can you guys review it again?

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171937543 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171939731 ## File path:

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171945877 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171943988 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171949224 ## File path:

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171948589 ## File path:

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171944363 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171943920 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171945675 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171946538 ## File path:

[GitHub] sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

sijie commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171945469 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171933046 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171962644 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171962565 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171929602 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941016 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941922 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941313 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171942205 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941658 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171941537 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171960386 ## File path:

[GitHub] sijie closed pull request #1224: Improve Travis Build

sijie closed pull request #1224: Improve Travis Build URL: https://github.com/apache/bookkeeper/pull/1224 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] sijie commented on issue #1224: Improve Travis Build

sijie commented on issue #1224: Improve Travis Build URL: https://github.com/apache/bookkeeper/pull/1224#issuecomment-370106432 IGNORE IT CI This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] eolivelli commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

eolivelli commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171974871 ## File path:

[GitHub] sijie commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370085706 @reddycharan it is okay to go in 4.7. I also have a few features to close for 4.7, that's why I

[GitHub] yzang commented on a change in pull request #1168: Fix TestBKSyncLogReader

yzang commented on a change in pull request #1168: Fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#discussion_r171987812 ## File path: stream/distributedlog/core/src/test/java/org/apache/distributedlog/TestBKSyncLogReader.java ## @@ -184,26

[GitHub] sijie commented on issue #1168: Fix TestBKSyncLogReader

sijie commented on issue #1168: Fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168#issuecomment-370101837 > Why do we remove the sleep between read? What if the polling speed is faster than the read ahead reading speed, and when we try to read the 21st record, we

[GitHub] sijie commented on issue #1224: Improve Travis Build

sijie commented on issue #1224: Improve Travis Build URL: https://github.com/apache/bookkeeper/pull/1224#issuecomment-370106223 The travis CI passed. the failure is on jenkins integration tests job (timeout at building docker image)

[GitHub] sijie closed pull request #1168: Fix TestBKSyncLogReader

sijie closed pull request #1168: Fix TestBKSyncLogReader URL: https://github.com/apache/bookkeeper/pull/1168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] reddycharan commented on issue #570: Multiple active entrylogs

reddycharan commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369856263 As far as I understood, EntryLogger is the abstraction layer for all of the operations on entrylog files. Be it how entries are written to entrylog

[GitHub] reddycharan commented on issue #570: Multiple active entrylogs

reddycharan commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369856263 As far as I understood, EntryLogger is the abstraction layer for all of the operations on entrylog files. Be it how entries are written to entrylog

[GitHub] sijie commented on issue #570: Multiple active entrylogs

sijie commented on issue #570: Multiple active entrylogs URL: https://github.com/apache/bookkeeper/issues/570#issuecomment-369860731 @reddycharan thank you so much for the response. the plan looks good to me. +1 to proceed.

[GitHub] sijie opened a new pull request #1224: (WIP) Use travis_wait on running mvn install

sijie opened a new pull request #1224: (WIP) Use travis_wait on running mvn install URL: https://github.com/apache/bookkeeper/pull/1224 Descriptions of the changes in this PR: This is an automated message from the

Jenkins build is back to stable : bookkeeper_postcommit_master_java9 #58

See

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171810861 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on issue #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-369887146 @reddycharan Could you summarize the email in PR description?

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171811434 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171812979 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171813550 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r171809299 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171814530 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchrnoization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r171812297 ## File path:

Jenkins build is back to stable : bookkeeper_postcommit_master_java8 #58

See

[GitHub] ivankelly commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping

ivankelly commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-369951213 @jiazhai @sijie @merlimat Can we close this in the end? That yellow line on the spreadsheet is bugging

Jenkins build is back to stable : bookkeeper_release_nightly_snapshot #78

See

Build failed in Jenkins: distributedlog-release-nightly-snapshot #183

See -- [...truncated 298.74 KB...] [INFO] Downloaded: https://repo.maven.apache.org/maven2/io/netty/netty-all/4.1.12.Final/netty-all-4.1.12.Final.pom (25 kB at