[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172119279 ## File path:

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172119053 ## File path:

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172115608 ## File path:

[GitHub] ivankelly commented on issue #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on issue #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#issuecomment-370368461 > I think the original implementation is much simpler approach. The original implementation had race conditions,

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172142404 ## File path:

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172122411 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172122421 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172125347 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172126626 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172130455 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172144582 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172130878 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172135535 ## File path:

[GitHub] ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ivankelly commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172134274 ## File path:

Jenkins build became unstable: bookkeeper_release_nightly_snapshot #85

See

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172255761 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172250275 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172252472 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172258386 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172257226 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172250114 ## File path:

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172278443 ## File path:

[GitHub] merlimat commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

merlimat commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172260549 ## File path:

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172287563 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172283513 ## File path:

[GitHub] reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on issue #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#issuecomment-370517921 @sijie I think this fix should be good to go now.

[GitHub] sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172308922 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172311201 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172307998 ## File path:

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172291826 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172304656 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172312290 ## File path:

[GitHub] dlg99 opened a new issue #1229: PendingAddOp can get recycled before it gets executed

dlg99 opened a new issue #1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/issues/1229 **BUG REPORT** Scenario: many async writes submitted/pending for the same ledger. Write fails due to not enough bookies. Ledge handle

[GitHub] sijie commented on issue #1229: PendingAddOp can get recycled before it gets executed

sijie commented on issue #1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/issues/1229#issuecomment-370583498 @dlg99 nice catch. I believed I saw similar NPE at pulsar. but didn't get a chance to look into why.

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172351072 ## File path:

[GitHub] reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

reddycharan commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172354228 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172313330 ## File path:

[GitHub] ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

ivankelly commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172317752 ## File path:

[GitHub] ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

ivankelly commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172314429 ## File path:

[GitHub] sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172315834 ## File path:

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172317243 ## File path:

[GitHub] sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage

sijie commented on a change in pull request #1225: Issue #570: getting rid of unnecessary synchronization in InterleavedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1225#discussion_r172317362 ## File path:

[GitHub] sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

sijie commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172319905 ## File path:

[GitHub] dlg99 commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

dlg99 commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230#issuecomment-370608766 thank you, @sijie awesome and simple fix.

[GitHub] sijie opened a new pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

sijie opened a new pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230 Descriptions of the changes in this PR: *Problem* The PendingAddOp can be recycled when it is cancelled before it is

[GitHub] reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel

reddycharan commented on a change in pull request #1228: Issue #570: Move logic of unpersistedbytes to bufferedchannel URL: https://github.com/apache/bookkeeper/pull/1228#discussion_r172278443 ## File path:

[GitHub] sijie commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

sijie commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230#issuecomment-370610080 @dlg99 since the test case in SlowBookieTest is not really catching the bug here, I added another test case

[GitHub] dlg99 commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

dlg99 commented on issue #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230#issuecomment-370614984 @sijie test lgtm This is an automated message from

[GitHub] sijie closed pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

sijie closed pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed issue #1229: PendingAddOp can get recycled before it gets executed

sijie closed issue #1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/issues/1229 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] jvrao commented on issue #1229: PendingAddOp can get recycled before it gets executed

jvrao commented on issue #1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/issues/1229#issuecomment-370597467 good catch @dlg99 It will be an interesting fix. :) This

[GitHub] dlg99 commented on a change in pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed

dlg99 commented on a change in pull request #1230: Issue 1229: PendingAddOp can get recycled before it gets executed URL: https://github.com/apache/bookkeeper/pull/1230#discussion_r172367852 ## File path:

[GitHub] ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle

ArvinDevel commented on a change in pull request #832: Issue 620: Close the fileChannels for read when they are idle URL: https://github.com/apache/bookkeeper/pull/832#discussion_r172388151 ## File path:

[GitHub] eolivelli commented on issue #1201: ISSUE #570: Entrylog per ledger

eolivelli commented on issue #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#issuecomment-370676862 We should close this PR pr change the title This is an automated message from the

[GitHub] eolivelli commented on issue #1201: ISSUE #570: Entrylog per ledger

eolivelli commented on issue #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#issuecomment-370681131 Something like a prefix DRAFT or DO NOT MERGE /cc @sijie This is an

[GitHub] reddycharan commented on issue #1201: ISSUE #570: Entrylog per ledger

reddycharan commented on issue #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#issuecomment-370679871 @eolivelli I just want to have option for reviewers to see the full picture. Im ok to change the PR title. any suggestions?

[GitHub] jvrao commented on issue #1201: ISSUE #570: Entrylog per ledger

jvrao commented on issue #1201: ISSUE #570: Entrylog per ledger URL: https://github.com/apache/bookkeeper/pull/1201#issuecomment-370682220 > Something like a prefix DRAFT or DO NOT MERGE @reddycharan as I suggested RFC (Request For Comments) may convey the message.