Build failed in Jenkins: bookkeeper_postcommit_master_java9 #78

2018-03-22 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Build failed in Jenkins: bookkeeper_release_nightly_snapshot #106

2018-03-22 Thread Apache Jenkins Server
See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H23 (ubuntu xenial) in workspace

Jenkins build is still unstable: bookkeeper_release_branch #96

2018-03-22 Thread Apache Jenkins Server
See

Jenkins build became unstable: bookkeeper_postcommit_master_java8 #78

2018-03-22 Thread Apache Jenkins Server
See

[GitHub] dmsergeevp44 opened a new pull request #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
dmsergeevp44 opened a new pull request #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285 Descriptions of the changes in this PR: (PR description content here)... Master Issue: # > --- > Be sure to do all of the following to help us

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176476938 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -52,25

[GitHub] eolivelli opened a new pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
eolivelli opened a new pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286 This change prevents errors seen when Bookie runs on Java 9. In some cases response messages

[GitHub] eolivelli closed pull request #1277: WIP - Use ByteBufOutputStream to serialize ProtoBuf messages

2018-03-22 Thread GitBox
eolivelli closed pull request #1277: WIP - Use ByteBufOutputStream to serialize ProtoBuf messages URL: https://github.com/apache/bookkeeper/pull/1277 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176473048 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] eolivelli commented on issue #1277: WIP - Use ByteBufOutputStream to serialize ProtoBuf messages

2018-03-22 Thread GitBox
eolivelli commented on issue #1277: WIP - Use ByteBufOutputStream to serialize ProtoBuf messages URL: https://github.com/apache/bookkeeper/pull/1277#issuecomment-375366545 Closing this PR in favour of #1286 This is an

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176460672 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] sijie commented on a change in pull request #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176520016 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] sijie commented on a change in pull request #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176535276 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -52,25

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639 > Could you give a sequence of events for how the other race occurs? I am using your diagram and using the existing logic ``` | Read Fi

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639 > Could you give a sequence of events for how the other race occurs? I am using your diagram and using the existing logic ``` | Read Fi

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639 > Could you give a sequence of events for how the other race occurs? I am using your diagram and using the existing logic ``` | Read Fi

[GitHub] ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
ivankelly commented on a change in pull request #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#discussion_r176516627 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileInfoBackingCache.java ## @@ -92,8

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639 > Could you give a sequence of events for how the other race occurs? I am using your diagram and using the existing logic ``` | Read Fi

[GitHub] sijie commented on issue #1284: Improve FileInfoBackingCache

2018-03-22 Thread GitBox
sijie commented on issue #1284: Improve FileInfoBackingCache URL: https://github.com/apache/bookkeeper/pull/1284#issuecomment-375420639 > Could you give a sequence of events for how the other race occurs? I am using your diagram and using the existing logic ``` | Read Fi

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176549632 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176549929 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] dmsergeevp44 commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
dmsergeevp44 commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375470136 @sijie how would I go about retesting this? This is an automated message from the

[GitHub] merlimat commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
merlimat commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375471495 > @sijie how would I go about retesting this? No worries, that's a command for Jenkins CI to get retriggered :)

[GitHub] merlimat commented on a change in pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
merlimat commented on a change in pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#discussion_r176585565 ## File path:

[GitHub] sijie commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
sijie commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375464762 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176331968 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176332343 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieInitializationTest.java

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176331262 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -116,6

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176332233 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java ## @@

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176332723 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -1441,4

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176336059 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -802,88

[GitHub] sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
sijie commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176336283 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@ -802,88

[GitHub] sijie opened a new issue #1287: NPE at DNS.reverse

2018-03-22 Thread GitBox
sijie opened a new issue #1287: NPE at DNS.reverse URL: https://github.com/apache/bookkeeper/issues/1287 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run the test - What did you expect to see? tests should pass

[GitHub] sijie commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
sijie commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375530739 IGNORE CI This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
sijie commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375530945 merged. @dmsergeevp44 thank you for your contribution! This is an automated message

[GitHub] sijie closed pull request #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
sijie closed pull request #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager.

2018-03-22 Thread GitBox
reddycharan commented on a change in pull request #1281: Issue #570: Introducing EntryLogManager. URL: https://github.com/apache/bookkeeper/pull/1281#discussion_r176638435 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryLogger.java ## @@

[GitHub] eolivelli commented on a change in pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
eolivelli commented on a change in pull request #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#discussion_r176586775 ## File path:

[GitHub] eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375474232 I will also change the decoder side once we agree on this approach

[GitHub] sijie commented on issue #1285: Fixed typos in README.md

2018-03-22 Thread GitBox
sijie commented on issue #1285: Fixed typos in README.md URL: https://github.com/apache/bookkeeper/pull/1285#issuecomment-375474920 @dmsergeevp44 haha, it is a command for Jenkins CI, not for you. sorry for confusion.

[GitHub] eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
eolivelli commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375474825 retest this please

[GitHub] sijie commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder

2018-03-22 Thread GitBox
sijie commented on issue #1286: WIP - Implement directly ChannelOutboundHandlerAdapter in BookieProtoEncoding#ResponseEncoder URL: https://github.com/apache/bookkeeper/pull/1286#issuecomment-375477291 change looks good to me.

[GitHub] sijie closed pull request #1280: Improve write rejection in DbLedgerStorage

2018-03-22 Thread GitBox
sijie closed pull request #1280: Improve write rejection in DbLedgerStorage URL: https://github.com/apache/bookkeeper/pull/1280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a