[GitHub] sijie commented on issue #1509: solve #1476 issue.

2018-06-13 Thread GitBox
sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396835111 @infodog thank you. @jiazhai @yzang @eolivelli can you guys review this change? This is an a

[GitHub] ivankelly opened a new pull request #1515: Issue #1511: Upgrade nokogiri to version 1.8.2

2018-06-13 Thread GitBox
ivankelly opened a new pull request #1515: Issue #1511: Upgrade nokogiri to version 1.8.2 URL: https://github.com/apache/bookkeeper/pull/1515 Version <1.8.2 contain a security vulnerability. Descriptions of the changes in this PR:

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396851422 rebuild java8 This is an automated message fr

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396851335 run bookkeeper-server bookie tests This is an

[GitHub] sijie closed issue #458: Stats Provider jars not included in "server-bin" package

2018-06-13 Thread GitBox
sijie closed issue #458: Stats Provider jars not included in "server-bin" package URL: https://github.com/apache/bookkeeper/issues/458 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] sijie commented on issue #458: Stats Provider jars not included in "server-bin" package

2018-06-13 Thread GitBox
sijie commented on issue #458: Stats Provider jars not included in "server-bin" package URL: https://github.com/apache/bookkeeper/issues/458#issuecomment-396852302 Closed this. - server binary distribution includes prometheus provider by default. - all binary distribution include

[GitHub] ivankelly commented on issue #1515: Issue #1511: Upgrade nokogiri to version 1.8.2

2018-06-13 Thread GitBox
ivankelly commented on issue #1515: Issue #1511: Upgrade nokogiri to version 1.8.2 URL: https://github.com/apache/bookkeeper/pull/1515#issuecomment-396861306 @eolivelli Cheers. merging This is an automated message from the Ap

[GitHub] ivankelly closed pull request #1515: Issue #1511: Upgrade nokogiri to version 1.8.2

2018-06-13 Thread GitBox
ivankelly closed pull request #1515: Issue #1511: Upgrade nokogiri to version 1.8.2 URL: https://github.com/apache/bookkeeper/pull/1515 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly closed issue #1511: [website] upgrade nokogiri to be newer than 1.8.2

2018-06-13 Thread GitBox
ivankelly closed issue #1511: [website] upgrade nokogiri to be newer than 1.8.2 URL: https://github.com/apache/bookkeeper/issues/1511 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] eolivelli commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
eolivelli commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#discussion_r195014568 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ReadL

[GitHub] eolivelli commented on issue #1436: BP-14 force() API - client side implementation

2018-06-13 Thread GitBox
eolivelli commented on issue #1436: BP-14 force() API - client side implementation URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396881301 @sijie @jvrao FYI I have added a commit to drop 'error out pending adds" in case of failure in force operation. So we are *n

[GitHub] eolivelli commented on issue #1514: Clean up javadoc mojos execution

2018-06-13 Thread GitBox
eolivelli commented on issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514#issuecomment-396893239 The error is hidden in the logs during the build of bookkeeper-server module you can find this kind of lines: > [INFO] --- maven-jav

Jenkins build is back to stable : bookkeeper_postcommit_validation_master #15

2018-06-13 Thread Apache Jenkins Server
See

[GitHub] infodog commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
infodog commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#discussion_r195091390 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ReadLas

[GitHub] eolivelli commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
eolivelli commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#discussion_r195097819 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ReadL

Jenkins build became unstable: bookkeeper_release_branch_46 #66

2018-06-13 Thread Apache Jenkins Server
See

Build failed in Jenkins: bookkeeper_codecoverage #113

2018-06-13 Thread Apache Jenkins Server
See Changes: [sijie] ISSUE #1490: BookieJournalForceTest is flaky [ivank] Issue #1511: Upgrade nokogiri to version 1.8.2 -- [...truncated 652.08 KB...] 2018-06-13T1

[GitHub] sijie commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on a change in pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#discussion_r195132458 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/ReadLastC

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396982473 run bookkeeper-server bookie tests This is an

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396982532 rubuild java8 This is an automated message fr

Jenkins build is back to normal : bookkeeper_postcommit_master_java9 #168

2018-06-13 Thread Apache Jenkins Server
See

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-397034654 run bookkeeper-server bookie tests This is an

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-397053718 run bookkeeper-server bookie tests This is an

[GitHub] sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

2018-06-13 Thread GitBox
sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#issuecomment-397053990 run bookkeeper-server bookie tests run integration tests --

[GitHub] sijie commented on issue #1514: Clean up javadoc mojos execution

2018-06-13 Thread GitBox
sijie commented on issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514#issuecomment-397054298 @eolivelli does it fail the build? This is an automated message from the Apache Git

[GitHub] eolivelli commented on issue #1514: Clean up javadoc mojos execution

2018-06-13 Thread GitBox
eolivelli commented on issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514#issuecomment-397059459 No, I think this is only a reason of slow down. Anyway logs are messy. We can tidy up. This is not a blocker problem and it is no

[GitHub] eolivelli commented on issue #1514: Clean up javadoc mojos execution

2018-06-13 Thread GitBox
eolivelli commented on issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514#issuecomment-397059793 @sijie don't you see always the same logs at every build? This is an automated m

[GitHub] sijie commented on issue #1344: Allow to configure read-only mode in ZooKeeperClient

2018-06-13 Thread GitBox
sijie commented on issue #1344: Allow to configure read-only mode in ZooKeeperClient URL: https://github.com/apache/bookkeeper/pull/1344#issuecomment-397061958 run integration tests This is an automated message from the Apach

[GitHub] nicmichael commented on a change in pull request #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

2018-06-13 Thread GitBox
nicmichael commented on a change in pull request #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#discussion_r195214627 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/Cl

[GitHub] sijie closed pull request #1344: Allow to configure read-only mode in ZooKeeperClient

2018-06-13 Thread GitBox
sijie closed pull request #1344: Allow to configure read-only mode in ZooKeeperClient URL: https://github.com/apache/bookkeeper/pull/1344 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] sijie closed issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

2018-06-13 Thread GitBox
sijie closed issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/issues/1489 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] sijie closed pull request #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

2018-06-13 Thread GitBox
sijie closed pull request #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-397132580 retest this please This is an automated messa

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-397132803 (somehow the jenkins precommit checks are not running after rebased. trying to close and reopen)

[GitHub] sijie closed pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie closed pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] infodog opened a new pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
infodog opened a new pull request #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509 Descriptions of the changes in this PR: The issue #1476 is caused by peculative reads with object recycling, same req

[GitHub] sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp

2018-06-13 Thread GitBox
sijie commented on issue #1509: Issue 1476: LedgerEntry is recycled twice at ReadLastConfirmedAndEntryOp URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-397190260 run bookkeeper-server bookie tests run bookkeeper-server tls tests run pr validation ---