[GitHub] eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata

eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#discussion_r206491617 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ##

[GitHub] ivankelly commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata

ivankelly commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#discussion_r206492026 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ##

[GitHub] eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata

eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#discussion_r206492237 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java

Build failed in Jenkins: bookkeeper_release_branch_47_integrationtests #102

See -- [...truncated 10.68 KB...] root 570 2 0 Jul 25 0.0 0.0 [edac-poller] root 625 2 0 Jul 25 0.0 0.0 [kipmi0] root

Jenkins build is still unstable: bookkeeper_release_branch_46 #112

See

[GitHub] ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata

ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#issuecomment-409224427 rerun integration test This is an automated message from the

Jenkins build is still unstable: bookkeeper_release_branch_47_java9 #114

See

Jenkins build is back to stable : bookkeeper_postcommit_master_java8 #214

See

Jenkins build is back to stable : bookkeeper_codecoverage #161

See

[GitHub] ivankelly commented on issue #1573: LedgerManager should return the metadata just written

ivankelly commented on issue #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#issuecomment-409171897 rerun bookkeeper-server bookie tests This is an automated

[GitHub] ivankelly opened a new pull request #1574: Disallow direct access to LedgerHandle#metadata

ivankelly opened a new pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574 This object has been accessed and mutated all over the client, which makes it hard to do anything with the object. This patch removes the

[GitHub] eolivelli commented on a change in pull request #1576: Record ctime for urledger mark time.

eolivelli commented on a change in pull request #1576: Record ctime for urledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#discussion_r206760168 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkLedgerUnderreplicationManager.java

[GitHub] eolivelli commented on a change in pull request #1576: Record ctime for urledger mark time.

eolivelli commented on a change in pull request #1576: Record ctime for urledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576#discussion_r206760198 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java ## @@ -931,14

[GitHub] eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata

eolivelli commented on a change in pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#discussion_r206492237 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedOp.java

[GitHub] ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable

ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#discussion_r206660994 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable

ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#discussion_r206660056 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java

[GitHub] ivankelly commented on issue #1575: Make each ensemble in ensemble list immutable

ivankelly commented on issue #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#issuecomment-409346272 retest this please // making sure fails aren't environmental (ran cleanly locally)

[GitHub] ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable

ivankelly commented on a change in pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#discussion_r206660056 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java

[GitHub] eolivelli commented on a change in pull request #1575: Make each ensemble in ensemble list immutable

eolivelli commented on a change in pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#discussion_r206643188 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java ##

[GitHub] eolivelli commented on a change in pull request #1575: Make each ensemble in ensemble list immutable

eolivelli commented on a change in pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575#discussion_r206642328 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java

[GitHub] ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata

ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#issuecomment-409285590 rerun integration tests This is an automated message from the

[GitHub] ivankelly opened a new pull request #1575: Make each ensemble in ensemble list immutable

ivankelly opened a new pull request #1575: Make each ensemble in ensemble list immutable URL: https://github.com/apache/bookkeeper/pull/1575 Previously, the ensemble list was a Map>. ArrayList is by definition mutable, so ensemble passed to metadata users are always mutable.

[GitHub] ivankelly closed pull request #1574: Disallow direct access to LedgerHandle#metadata

ivankelly closed pull request #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

Build failed in Jenkins: bookkeeper_release_nightly_snapshot #81

See -- Started by timer [EnvInject] - Loading node environment variables. Building remotely on H35 (ubuntu xenial) in workspace

[GitHub] ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata

ivankelly commented on issue #1574: Disallow direct access to LedgerHandle#metadata URL: https://github.com/apache/bookkeeper/pull/1574#issuecomment-409301440 merging so I can push the next This is an automated message

[GitHub] reddycharan opened a new pull request #1576: Record ctime for urledger mark time.

reddycharan opened a new pull request #1576: Record ctime for urledger mark time. URL: https://github.com/apache/bookkeeper/pull/1576 Descriptions of the changes in this PR: Enable the Auditor to use system time as underreplicated ledger mark time. If this is enabled, Auditor

[GitHub] eolivelli commented on issue #1573: LedgerManager should return the metadata just written

eolivelli commented on issue #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#issuecomment-409164869 To me as soon as CI is green we can merge this one. It won't create any harm

[GitHub] ivankelly closed issue #610: Make LedgerMetadata Immutable

ivankelly closed issue #610: Make LedgerMetadata Immutable URL: https://github.com/apache/bookkeeper/issues/610 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] ivankelly commented on issue #610: Make LedgerMetadata Immutable

ivankelly commented on issue #610: Make LedgerMetadata Immutable URL: https://github.com/apache/bookkeeper/issues/610#issuecomment-409157054 Dupe of #281 This is an automated message from the Apache Git Service. To respond

[GitHub] ivankelly opened a new pull request #1573: LedgerManager should return the metadata just written

ivankelly opened a new pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573 First part of changes to make ledger metadata immutable. The client should only act on metadata which has been written to zookeeper. To

[GitHub] eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written

eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206458659 ## File path:

[GitHub] ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written

ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206459810 ## File path:

[GitHub] eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written

eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206460189 ## File path:

[GitHub] ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written

ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206460005 ## File path:

[GitHub] eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written

eolivelli commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206460888 ## File path:

[GitHub] ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written

ivankelly commented on a change in pull request #1573: LedgerManager should return the metadata just written URL: https://github.com/apache/bookkeeper/pull/1573#discussion_r206460818 ## File path: