eolivelli commented on a change in pull request #1087: ISSUE #1075: Add a noop
digest implentation
URL: https://github.com/apache/bookkeeper/pull/1087#discussion_r165891478
##########
File path:
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/BookKeeperApiTest.java
##########
@@ -162,6 +163,48 @@ public void testOpenLedgerUnauthorized() throws Exception
{
}
}
+ /**
+ * Verify the functionality Ledgers with different digests.
+ *
+ * @throws Exception
+ */
+ @Test
+ public void testLedgerDigests() throws Exception {
+ DigestType[] types = new DigestType[] {
+ DigestType.CRC32,
Review comment:
Sine this is an *enum* we should use DigestType.values() so that we are sure
to cover new types in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
