[GitHub] eolivelli commented on a change in pull request #1160: Dump config
eolivelli commented on a change in pull request #1160: Dump config
URL: https://github.com/apache/bookkeeper/pull/1160#discussion_r169027861
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##
@@ -618,4 +618,22 @@ public String getTLSEnabledProtocols() {
* Trickery to allow inheritance with fluent style.
*/
protected abstract T getThis();
+
+/**
+ * converts the config into string format, by appending the config values
+ * and separated by 'separator'.
+ *
+ * @param separator
+ *separator to separate the configs in string
+ */
+public String configAsString(String separator) {
Review comment:
okay for JSON for me
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1160: Dump config
eolivelli commented on a change in pull request #1160: Dump config
URL: https://github.com/apache/bookkeeper/pull/1160#discussion_r169008985
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##
@@ -618,4 +618,22 @@ public String getTLSEnabledProtocols() {
* Trickery to allow inheritance with fluent style.
*/
protected abstract T getThis();
+
+/**
+ * converts the config into string format, by appending the config values
+ * and separated by 'separator'.
+ *
+ * @param separator
+ *separator to separate the configs in string
+ */
+public String configAsString(String separator) {
Review comment:
PropertiesConfiguration -> I never noticed this utility, thank you
I think having the config in JSON format inside log files is not very
intuitive, but I can live with it, as far as they are "pretty printed"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1160: Dump config
eolivelli commented on a change in pull request #1160: Dump config
URL: https://github.com/apache/bookkeeper/pull/1160#discussion_r169000949
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
##
@@ -618,4 +618,22 @@ public String getTLSEnabledProtocols() {
* Trickery to allow inheritance with fluent style.
*/
protected abstract T getThis();
+
+/**
+ * converts the config into string format, by appending the config values
+ * and separated by 'separator'.
+ *
+ * @param separator
+ *separator to separate the configs in string
+ */
+public String configAsString(String separator) {
Review comment:
I am ok for the json version, but it can be a second change.
I have this method which dumps the config in several projects.
I have an additional use case:
I start the bookie programmatically and then I dump the actual
configuration to a file so that it is possible to use bookkeeper shell commands.
So I like this function
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
