eolivelli commented on a change in pull request #1249: Fixed Journal static empty array list recycling URL: https://github.com/apache/bookkeeper/pull/1249#discussion_r173965159
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java ########## @@ -66,7 +66,7 @@ private static final RecyclableArrayList.Recycler<QueueEntry> entryListRecycler = new RecyclableArrayList.Recycler<QueueEntry>(); - private static final RecyclableArrayList<QueueEntry> EMPTY_ARRAY_LIST = entryListRecycler.newInstance(); + private static final RecyclableArrayList<QueueEntry> EMPTY_ARRAY_LIST = new RecyclableArrayList<>(); Review comment: I can't remember why we can't use a simple ArrayList if we cannot recycle it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services