eolivelli commented on a change in pull request #1599: Fix master versions 
(4.8.0-SNAPSHOT->4.9.0-SNAPSHOT)
URL: https://github.com/apache/bookkeeper/pull/1599#discussion_r209444536
 
 

 ##########
 File path: stream/distributedlog/core/pom.xml
 ##########
 @@ -146,7 +146,7 @@
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
         <configuration>
-          
<suppressionsLocation>distributedlog/suppressions.xml</suppressionsLocation>
+          
<suppressionsLocation>buildtools/src/main/resources/distributedlog/suppressions.xml</suppressionsLocation>
 
 Review comment:
   Is this path relative?
   How can this work?
   Does it work if you run
   mvn validate
   From a non root directory?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to