[GitHub] eolivelli commented on issue #1575: Make each ensemble in ensemble list immutable

2018-08-01 Thread GitBox
eolivelli commented on issue #1575: Make each ensemble in ensemble list 
immutable
URL: https://github.com/apache/bookkeeper/pull/1575#issuecomment-409510716
 
 
   Okay #shipit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] eolivelli commented on issue #1575: Make each ensemble in ensemble list immutable

2018-08-01 Thread GitBox
eolivelli commented on issue #1575: Make each ensemble in ensemble list 
immutable
URL: https://github.com/apache/bookkeeper/pull/1575#issuecomment-409487792
 
 
   @ivankelly it seemed to me that there were also compilation errors, not only 
javac, let's see CI


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] eolivelli commented on issue #1575: Make each ensemble in ensemble list immutable

2018-08-01 Thread GitBox
eolivelli commented on issue #1575: Make each ensemble in ensemble list 
immutable
URL: https://github.com/apache/bookkeeper/pull/1575#issuecomment-409475295
 
 
   @ivankelly seems we have compilation errors, check CI
   
   apart from that this patch can go for me, as you will soon re-refactor the 
code in which I left comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services