[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

2018-02-13 Thread GitBox
ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-365328837 Merging This is an automated message from the Apache Git Service.

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

2018-02-12 Thread GitBox
ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-365045286 @sijie pared down This is an automated message from the Apache Git

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

2018-02-12 Thread GitBox
ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364958045 If lifecycle changes are coming from multiple threads, it should be capable of concurrent access. Otherwise it's broken and should be

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

2018-02-12 Thread GitBox
ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364877305 @sijie yes, that change would also fix the immediate issue. It could also be fixed in a number of one-line ways. - synchronization

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

2018-02-09 Thread GitBox
ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-364432260 retest this please This is an automated message from the Apache Git