[GitHub] jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-13 Thread GitBox 
jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should 
trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365487833
 
 
   @sijie Thanks for the comments. changed the code. CI failure seems caused by 
other un-related issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-06 Thread GitBox 
jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should 
trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-363656988
 
 
   will wait for #898.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-05 Thread GitBox 
jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should 
trigger callback with error when ledger is empty
URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-363274346
 
 
   Thank @sijie @eolivelli . cherry-pick 372a99db49 was handling in 
https://github.com/apache/bookkeeper/pull/898.  will add a sync call of 
`asyncReadLastEntry` here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services