reddycharan opened a new issue #1346: incomplete fix for exception handling in flushRotatedLogs method and need of ConcurrentList for rotatedLogChannels URL: https://github.com/apache/bookkeeper/issues/1346 **BUG REPORT** 1. Please describe the issue you observed: As part of this bug https://issues.apache.org/jira/projects/BOOKKEEPER/issues/BOOKKEEPER-1044, following fix has been made https://github.com/apache/bookkeeper/pull/286/commits/cfe8bce5bf07532f5ca165b0e65272a43a013e8a but this seems to be an incomplete fix. If there is an exception while closing fileChannel (closeFileChannel(channel)) then it is not handled with this fix. Also it would be much simpler to use some sort of ConcurrentList for rotatedLogChannels, since it would remove the need of guard of synchronization on EntryLogger/EntryLogManager instance and it would be much simpler to implement function which access / operate on rotatedLogChannels.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
