[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

2018-06-11 Thread GitBox 
sijie commented on a change in pull request #1508: ISSUE-1490 
BookieJournalForceTest is flaky
URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194597969
 
 

 ##
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java
 ##
 @@ -320,6 +322,7 @@ public void testForceLedger() throws Exception {
 Bookie.checkDirectoryStructure(Bookie.getCurrentDirectory(journalDir));
 
 ServerConfiguration conf = 
TestBKConfiguration.newServerConfiguration();
+conf.setJournalFlushWhenQueueEmpty(false);
 
 Review comment:
   it is still unclear to me how this would cause the flakiness? can you 
explain more?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

2018-06-10 Thread GitBox 
sijie commented on a change in pull request #1508: ISSUE-1490 
BookieJournalForceTest is flaky
URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194267511
 
 

 ##
 File path: 
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/BookieJournalForceTest.java
 ##
 @@ -302,6 +302,8 @@ public void writeComplete(int rc, long ledgerId, long 
entryId, BookieSocketAddre
 LinkedBlockingQueue supportQueue = new 
LinkedBlockingQueue<>();
 BlockingQueue forceWriteRequests = 
mock(BlockingQueue.class);
 doAnswer((Answer) (InvocationOnMock iom) -> {
+log.error("something put " + iom.getArgument(0) + " on journal 
queue",
 
 Review comment:
   use `{}`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sijie commented on a change in pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

2018-06-10 Thread GitBox 
sijie commented on a change in pull request #1508: ISSUE-1490 
BookieJournalForceTest is flaky
URL: https://github.com/apache/bookkeeper/pull/1508#discussion_r194267504
 
 

 ##
 File path: 
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
 ##
 @@ -390,6 +390,16 @@ public int process(boolean shouldForceWrite) throws 
IOException {
 }
 }
 
+@Override
+public String toString() {
 
 Review comment:
   use `StringBuilder`.
   
   or use lomok `ToString` annotation
   
   or use guava `ToStringHelper` 
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services