[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-368789336 @merlimat it seems that we don't need this change any more, shall we close it or you want to wait until pulsar completes bumping the bookkeeper version? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-364621406 @merlimat can you check if we still need this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-360402574 @merlimat > I think in one place the hostname was used vs the IP in the other and that was leading to no caching. if that is the case, I don't think we need this change before in master `useHostName` was introduced to DNSToSwitchMapping. It ensures the resolver either gets ip or hostname. https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/net/DNSToSwitchMapping.java#L67 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-359679451 @merlimat @sboobna can any of you take a look at @jiazhai 's comment? It would be good to understand the motivation of this change and how is this used by pulsar. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
sijie commented on issue #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping URL: https://github.com/apache/bookkeeper/pull/1012#issuecomment-358737031 hmm, I think this change will break BC, because it changes the interface of DNSToSwitchMapping, which is allowed to be provided by users when constructing the bookkeeper. @merlimat @sboobna do you guys have any more context about this change? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
